Compare commits

...

31 Commits

Author SHA1 Message Date
Purwa Shrivastava
2ab340f3f1 React rendering Errors for few apps. 2019-12-06 11:11:25 +01:00
Purwa Shrivastava
8ba826a0ea Corrected the react error when componentDidUpdate is called. So the error message is uniformly shown in both analysis and edit mode. 2019-12-06 10:12:07 +01:00
Purwa Shrivastava
d2446395e2 Merge pull request #77 from qlik-oss/QB-331/PivotPagination
Pivot Pagination Fix.
2019-12-05 13:41:29 +01:00
Purwa Shrivastava
f17a7b7714 Merge pull request #79 from qlik-oss/QB-493/wrongDataDisplay
Qb 493/wrong data display
2019-12-05 09:15:42 +01:00
Purwa Shrivastava
8aa86275f0 Changed the rendering of each data cell to check for the headers of each dimesnsion and measure where it shall be written. 2019-12-04 11:15:14 +01:00
Purwa Shrivastava
3ebc2b9e29 Adding Dim 2 to the rendering logic. 2019-11-29 16:17:49 +01:00
Purwa Shrivastava
ce81549011 Merge pull request #78 from qlik-oss/QB-498/disableConversion
Conversion led to different sort orders of data in different objects …
2019-11-28 13:40:45 +01:00
Purwa Shrivastava
e64af66dab Conversion led to different sort orders of data in different objects so disabling it. 2019-11-27 14:54:42 +01:00
Purwa Shrivastava
fd9e645fc1 Pivot Pagination Fix. 2019-11-21 10:59:28 +01:00
Philip Olsén
ca1b1a9b53 Merge pull request #75 from qlik-oss/pol/bd
Update black duck link
2019-09-20 15:33:56 +02:00
Philip Olsén
a65f843008 Update black duck link 2019-09-20 14:23:37 +02:00
Purwa Shrivastava
be9570e0aa Merge pull request #74 from qlik-oss/atq/about
Updated the About info for the smart pivot.
2019-07-12 12:40:29 +02:00
Purwa Shrivastava
41d3a7c9af Updated the About info for the smart pivot. 2019-07-11 11:01:42 +02:00
Albert Backenhof
1e0a7c1204 Merge pull request #72 from qlik-oss/DEB-211/ContextMenuExportExcel
Moved Excel export to context menu
2019-06-27 12:35:04 +02:00
Albert Backenhof
17b5df296c Moved Excel export to context menu
-Not showing context menu option for desktop
 users.

Issue: DEB-211
2019-06-26 13:41:07 +02:00
Albert Backenhof
64b778b1af Merge pull request #71 from qlik-oss/DEB-244/ExcelRow
Suppress missing values and use correct cube size
2019-06-17 13:37:05 +02:00
Albert Backenhof
be6718ccf4 Merge pull request #73 from qlik-oss/DEB-250/ImprovedSelection
Selecting with backendApi instead of Field
2019-06-17 09:30:27 +02:00
Albert Backenhof
28e6237a43 Selecting with backendApi instead of Field
-Makes it possible to select master fields with
 different names than the original field.

-Alternate state is no longer a problem when using
 this technique to select.

Issue: DEB-250
2019-06-14 08:30:57 +02:00
Albert Backenhof
4fab3b5933 Suppress missing values and use correct cube size
Issue: DEB-244
2019-05-29 15:17:17 +02:00
Albert Backenhof
79339a8963 Merge pull request #70 from qlik-oss/QLIK-95962/SpanWidth
Add option to fit cells to chart width
2019-05-29 12:19:59 +02:00
Albert Backenhof
a6faeeb656 Add option to fit cells to chart width
-To achieve pixel perfection the container of both
 header and data needs to calculate the size of the
 child tables' cells.

Issue: QLIK-95962
2019-05-28 07:44:40 +02:00
Albert Backenhof
c22b7f5c6b Merge pull request #61 from qlik-oss/DEB-232/DoubleMeasure
Made the table cell keys more unique
2019-05-27 14:37:07 +02:00
Albert Backenhof
80f97602e4 Merge pull request #69 from qlik-oss/DEB-242/ExportInContainer
Excel export inside container
2019-05-27 14:36:31 +02:00
Albert Backenhof
f745656b4c Excel export inside container
-No tid-element available when inside native container.
 Therefore, use root element to find table cells instead.

Issue: DEB-242
2019-05-27 14:33:43 +02:00
Albert Backenhof
f7e780b92e Merge pull request #68 from qlik-oss/excelType
Specifying excel type of excel download
2019-05-27 14:28:26 +02:00
Albert Backenhof
d7a76c7db9 Merge pull request #63 from qlik-oss/QLIK-95802/AltStateFix
Fixed alternate state support
2019-05-27 14:26:58 +02:00
Albert Backenhof
16c380e1c6 Fixed alternate state support
-Previously, the shown data always followed
 default state, and not the set state.
-Previously, the selections made in smart pivot
 sometimes used the previous alternate state.

Issue: QLIK-95802
2019-05-27 14:24:02 +02:00
Albert Backenhof
072a3b80c4 Merge pull request #62 from qlik-oss/DEB-233/Selections
Handle selection toggle properly
2019-05-27 14:12:43 +02:00
Albert Backenhof
e26d5fded8 Specifying excel type of excel download 2019-05-20 10:12:22 +02:00
Albert Backenhof
1436463f59 Made the table cell keys more unique
-This makes it possible to use the same measurement
 multiple times within the same smart-pivot chart.

Issue: DEB-232
2019-05-13 13:12:32 +02:00
Albert Backenhof
729a31920d Handle selection toggle properly
-Previously, the cell selection would toggle
 the current selection. This meant, if a column
 is already selected when making a cell selection,
 the column selection would toggle off. With this
 fix the column selection stays on.

Issue: DEB-233
2019-05-13 09:43:41 +02:00
21 changed files with 655 additions and 506 deletions

View File

@@ -20,7 +20,7 @@ jobs:
command: npm install command: npm install
- run: - run:
name: BlackDuck scan name: BlackDuck scan
command: curl -s https://blackducksoftware.github.io/hub-detect/hub-detect.sh | bash -s -- \ command: curl -s https://detect.synopsys.com/detect.sh | bash -s -- \
--blackduck.url="https://qliktech.blackducksoftware.com" \ --blackduck.url="https://qliktech.blackducksoftware.com" \
--blackduck.trust.cert=true \ --blackduck.trust.cert=true \
--blackduck.username="svc-blackduck" \ --blackduck.username="svc-blackduck" \

Binary file not shown.

Before

Width:  |  Height:  |  Size: 2.2 KiB

View File

@@ -9,22 +9,33 @@ class DataCell extends React.PureComponent {
} }
handleSelect () { handleSelect () {
const { data: { meta: { dimensionCount } }, general: { allowFilteringByClick }, measurement, qlik } = this.props; const {
data: {
meta: {
dimensionCount
}
},
general: {
allowFilteringByClick
},
measurement,
component
} = this.props;
const hasSecondDimension = dimensionCount > 1; const hasSecondDimension = dimensionCount > 1;
if (!allowFilteringByClick) { if (!allowFilteringByClick) {
return; return;
} }
qlik.backendApi.selectValues(0, [measurement.parents.dimension1.elementNumber], true); component.backendApi.selectValues(0, [measurement.parents.dimension1.elementNumber], false);
if (hasSecondDimension) { if (hasSecondDimension) {
qlik.backendApi.selectValues(1, [measurement.parents.dimension2.elementNumber], true); component.backendApi.selectValues(1, [measurement.parents.dimension2.elementNumber], false);
} }
} }
render () { render () {
const { const {
general, cellWidth,
measurement, measurement,
styleBuilder, styleBuilder,
styling styling
@@ -37,17 +48,15 @@ class DataCell extends React.PureComponent {
...styleBuilder.getStyle(), ...styleBuilder.getStyle(),
paddingLeft: '5px', paddingLeft: '5px',
textAlign: textAlignment, textAlign: textAlignment,
minWidth: general.cellWidth, minWidth: cellWidth,
maxWidth: general.cellWidth maxWidth: cellWidth
}; };
const isEmptyCell = measurement.displayValue === ''; const isEmptyCell = measurement.displayValue === '';
let formattedMeasurementValue; let formattedMeasurementValue;
if (isEmptyCell) { if (isEmptyCell || styleBuilder.hasComments()) {
formattedMeasurementValue = ''; formattedMeasurementValue = '';
cellStyle.cursor = 'default'; cellStyle.cursor = 'default';
} else if (styleBuilder.hasComments()) {
formattedMeasurementValue = '.';
} else { } else {
formattedMeasurementValue = formatMeasurementValue(measurement, styling); formattedMeasurementValue = formatMeasurementValue(measurement, styling);
} }
@@ -86,20 +95,22 @@ class DataCell extends React.PureComponent {
} }
DataCell.propTypes = { DataCell.propTypes = {
cellWidth: PropTypes.string.isRequired,
data: PropTypes.shape({ data: PropTypes.shape({
headers: PropTypes.shape({ headers: PropTypes.shape({
measurements: PropTypes.array.isRequired measurements: PropTypes.array.isRequired
}).isRequired,
meta: PropTypes.shape({
dimensionCount: PropTypes.number.isRequired
}).isRequired }).isRequired
}).isRequired, }).isRequired,
general: PropTypes.shape({ general: PropTypes.shape({}).isRequired,
cellWidth: PropTypes.string.isRequired
}).isRequired,
measurement: PropTypes.shape({ measurement: PropTypes.shape({
format: PropTypes.string, format: PropTypes.string,
name: PropTypes.string, name: PropTypes.string,
value: PropTypes.any value: PropTypes.any
}).isRequired, }).isRequired,
qlik: PropTypes.shape({ component: PropTypes.shape({
backendApi: PropTypes.shape({ backendApi: PropTypes.shape({
selectValues: function (props, propName) { selectValues: function (props, propName) {
if (props.isSnapshot || typeof props[propName] === 'function') { if (props.isSnapshot || typeof props[propName] === 'function') {

View File

@@ -5,101 +5,143 @@ import DataCell from './data-cell.jsx';
import RowHeader from './row-header.jsx'; import RowHeader from './row-header.jsx';
import { injectSeparators } from '../utilities'; import { injectSeparators } from '../utilities';
const DataTable = ({ data, general, qlik, renderData, styling }) => { // eslint-disable-next-line react/prefer-stateless-function
const { class DataTable extends React.PureComponent {
headers: { render () {
dimension1, const {
measurements cellWidth,
}, columnSeparatorWidth,
matrix component,
} = data; data,
general,
renderData,
styling
} = this.props;
return ( const {
<div className="row-wrapper"> headers: {
<table> dimension1,
<tbody> dimension2,
{dimension1.map((dimensionEntry, dimensionIndex) => { measurements
const rowHeaderText = dimensionEntry.displayValue || ''; },
if (rowHeaderText === '-') { matrix
return null; } = data;
}
const styleBuilder = new StyleBuilder(styling);
if (styling.hasCustomFileStyle) {
styleBuilder.parseCustomFileStyle(rowHeaderText);
} else {
styleBuilder.applyStandardAttributes(dimensionIndex);
styleBuilder.applyCustomStyle({
fontSize: `${14 + styling.options.fontSizeAdjustment}px`
});
}
const rowStyle = {
fontFamily: styling.options.fontFamily,
width: '230px',
...styleBuilder.getStyle()
};
return ( const separatorStyle = {
<tr key={dimensionEntry.displayValue}> minWidth: columnSeparatorWidth,
{!renderData ? maxWidth: columnSeparatorWidth
<RowHeader };
entry={dimensionEntry}
qlik={qlik} const renderMeasurementData = (dimIndex, atEvery) => {
rowStyle={rowStyle} const injectSeparatorsArray = injectSeparators(
styleBuilder={styleBuilder} matrix[dimIndex],
styling={styling} columnSeparatorWidth,
/> : null atEvery
);
if (dimension2.length <= 0) {
return injectSeparatorsArray;
}
let measurementDataRow = [],
index = 0;
dimension2.forEach((dim2) => {
measurements.forEach((measure) => {
for (index = 0; index < injectSeparatorsArray.length; index++) {
if (injectSeparatorsArray[index].parents && dimension1[dimIndex].displayValue === injectSeparatorsArray[index].parents.dimension1.header) {
if (dim2.displayValue === injectSeparatorsArray[index].parents.dimension2.header) {
if (measure.name === injectSeparatorsArray[index].parents.measurement.header) {
measurementDataRow.push(injectSeparatorsArray[index]);
break;
} }
{renderData && injectSeparators( }
matrix[dimensionIndex], }
styling.useSeparatorColumns, }
{ atEvery: measurements.length } });
).map((measurementData, index) => { });
if (measurementData.isSeparator) { return measurementDataRow;
const separatorStyle = { };
color: 'white',
fontFamily: styling.options.fontFamily,
fontSize: `${12 + styling.options.fontSizeAdjustment}px`
};
return ( return (
<td <div className="row-wrapper">
className="empty" <table>
key={`${dimensionEntry.displayValue}-${index}-separator`} <tbody>
style={separatorStyle} {dimension1.map((dimensionEntry, dimensionIndex) => {
> const rowHeaderText = dimensionEntry.displayValue || '';
* if (rowHeaderText === '-') {
</td> return null;
); }
} const styleBuilder = new StyleBuilder(styling);
if (styling.hasCustomFileStyle) {
styleBuilder.parseCustomFileStyle(rowHeaderText);
} else {
styleBuilder.applyStandardAttributes(dimensionIndex);
styleBuilder.applyCustomStyle({
fontSize: `${14 + styling.options.fontSizeAdjustment}px`
});
}
const rowStyle = {
fontFamily: styling.options.fontFamily,
width: '230px',
...styleBuilder.getStyle()
};
const { dimension1: dimension1Info, dimension2, measurement } = measurementData.parents; return (
const id = `${dimension1Info.elementNumber}-${dimension2 && dimension2.elementNumber}-${measurement.header}`; <tr key={dimensionEntry.displayValue}>
return ( {!renderData ?
<DataCell <RowHeader
data={data} component={component}
general={general} entry={dimensionEntry}
key={`${dimensionEntry.displayValue}-${id}`} rowStyle={rowStyle}
measurement={measurementData}
qlik={qlik}
styleBuilder={styleBuilder} styleBuilder={styleBuilder}
styling={styling} styling={styling}
/> /> : null
); }
})} {renderData && renderMeasurementData(dimensionIndex, { atEvery: measurements.length }).map((measurementData, index) => {
</tr> if (measurementData.isSeparator) {
); return (
})} <td
</tbody> className="empty"
</table> key={`${dimensionEntry.displayValue}-${index}-separator`}
</div> style={separatorStyle}
); />
}; );
}
// eslint-disable-next-line no-shadow
const { dimension1: dimension1Info, dimension2, measurement } = measurementData.parents;
const id = `${dimension1Info.elementNumber}-${dimension2 && dimension2.elementNumber}-${measurement.header}-${measurement.index}`;
return (
<DataCell
cellWidth={cellWidth}
component={component}
data={data}
general={general}
key={`${dimensionEntry.displayValue}-${id}`}
measurement={measurementData}
styleBuilder={styleBuilder}
styling={styling}
/>
);
})}
</tr>
);
})}
</tbody>
</table>
</div>
);
}
}
DataTable.defaultProps = { DataTable.defaultProps = {
renderData: true renderData: true
}; };
DataTable.propTypes = { DataTable.propTypes = {
cellWidth: PropTypes.string.isRequired,
columnSeparatorWidth: PropTypes.string.isRequired,
component: PropTypes.shape({}).isRequired,
data: PropTypes.shape({ data: PropTypes.shape({
headers: PropTypes.shape({ headers: PropTypes.shape({
dimension1: PropTypes.array.isRequired dimension1: PropTypes.array.isRequired
@@ -107,7 +149,6 @@ DataTable.propTypes = {
matrix: PropTypes.arrayOf(PropTypes.array.isRequired).isRequired matrix: PropTypes.arrayOf(PropTypes.array.isRequired).isRequired
}).isRequired, }).isRequired,
general: PropTypes.shape({}).isRequired, general: PropTypes.shape({}).isRequired,
qlik: PropTypes.shape({}).isRequired,
renderData: PropTypes.bool, renderData: PropTypes.bool,
styling: PropTypes.shape({ styling: PropTypes.shape({
hasCustomFileStyle: PropTypes.bool.isRequired hasCustomFileStyle: PropTypes.bool.isRequired

View File

@@ -11,13 +11,13 @@ class RowHeader extends React.PureComponent {
} }
handleSelect () { handleSelect () {
const { entry, qlik } = this.props; const { component, entry } = this.props;
qlik.backendApi.selectValues(0, [entry.elementNumber], true); component.backendApi.selectValues(0, [entry.elementNumber], false);
} }
render () { render () {
const { entry, rowStyle, styleBuilder, styling, qlik } = this.props; const { entry, rowStyle, styleBuilder, styling, component } = this.props;
const inEditState = qlik.inEditState(); const inEditState = component.inEditState();
return ( return (
<td <td
@@ -43,9 +43,10 @@ class RowHeader extends React.PureComponent {
RowHeader.propTypes = { RowHeader.propTypes = {
entry: PropTypes.shape({ entry: PropTypes.shape({
displayValue: PropTypes.string.isRequired displayValue: PropTypes.string.isRequired,
elementNumber: PropTypes.number.isRequired
}).isRequired, }).isRequired,
qlik: PropTypes.shape({ component: PropTypes.shape({
backendApi: PropTypes.shape({ backendApi: PropTypes.shape({
selectValues: function (props, propName) { selectValues: function (props, propName) {
if (props.isSnapshot || typeof props[propName] === 'function') { if (props.isSnapshot || typeof props[propName] === 'function') {

View File

@@ -6,39 +6,66 @@ function createCube (definition, app) {
}); });
} }
async function buildDataCube (originCubeDefinition, hasTwoDimensions, app) { async function buildDataCube (originCubeDefinition, originCube, app, requestPage) {
const cubeDefinition = { const cubeDefinition = {
...originCubeDefinition, ...originCubeDefinition,
qInitialDataFetch: [ qInitialDataFetch: [
{ {
// eslint-disable-next-line no-undefined
qTop: requestPage === undefined ? 0 : requestPage[0].qTop,
qLeft: 0,
qHeight: 1000, qHeight: 1000,
qWidth: 10 qWidth: originCube.qSize.qcx
} }
], ],
qDimensions: [originCubeDefinition.qDimensions[0]], qDimensions: [originCubeDefinition.qDimensions[0]],
qMeasures: originCubeDefinition.qMeasures qMeasures: originCubeDefinition.qMeasures
}; };
if (hasTwoDimensions) { if (originCube.qDimensionInfo.length === 2) {
cubeDefinition.qDimensions.push(originCubeDefinition.qDimensions[1]); cubeDefinition.qDimensions.push(originCubeDefinition.qDimensions[1]);
} }
const cube = await createCube(cubeDefinition, app); const cube = await createCube(cubeDefinition, app);
return cube.qHyperCube.qDataPages[0].qMatrix; const cubeMatrix = cube.qHyperCube.qDataPages[0].qMatrix;
app.destroySessionObject(cube.qInfo.qId);
return cubeMatrix;
} }
export async function initializeDataCube (component, layout) { export async function initializeDataCube (component, layout) {
if (component.backendApi.isSnapshot) { if (component.backendApi.isSnapshot) {
return layout.snapshotData.dataCube; return layout.snapshotData.dataCube;
} }
const app = qlik.currApp(component); const app = qlik.currApp(component);
const properties = (await component.backendApi.getProperties()); const properties = (await component.backendApi.getProperties());
const rowCount = component.backendApi.getRowCount();
const cellCount = rowCount * layout.qHyperCube.qSize.qcx;
const maxLoops = layout.maxloops;
// If this is a master object, fetch the hyperCubeDef of the original object // If this is a master object, fetch the hyperCubeDef of the original object
const hyperCubeDef = properties.qExtendsId let hyperCubeDef = properties.qExtendsId
? (await app.getObjectProperties(properties.qExtendsId)).properties.qHyperCubeDef ? (await app.getObjectProperties(properties.qExtendsId)).properties.qHyperCubeDef
: properties.qHyperCubeDef; : properties.qHyperCubeDef;
hyperCubeDef = JSON.parse(JSON.stringify(hyperCubeDef));
return buildDataCube(hyperCubeDef, layout.qHyperCube.qDimensionInfo.length === 2, app); hyperCubeDef.qStateName = layout.qStateName;
const pagedCube = {};
let lastRow = 0;
if (cellCount < (maxLoops * 10000)) {
for (let index = 0; cellCount > lastRow; index += 1) {
const requestPage = [
{
qHeight: 1000,
qLeft: 0,
qTop: lastRow,
qWidth: 10 // should be # of columns
}
];
// eslint-disable-next-line no-await-in-loop
pagedCube[index] = await buildDataCube(hyperCubeDef, layout.qHyperCube, app, requestPage);
lastRow = lastRow + 1000;
}
return pagedCube;
}
return null;
} }
export function initializeDesignList (component, layout) { export function initializeDesignList (component, layout) {

View File

@@ -39,7 +39,7 @@ const definition = {
component: 'text' component: 'text'
}, },
paragraph1: { paragraph1: {
label: `P&L pivot is a Qlik Sense extension which allows you to display Profit & Loss label: `P&L pivot is a Qlik Sense chart which allows you to display Profit & Loss
reporting with color and font customizations.`, reporting with color and font customizations.`,
component: 'text' component: 'text'
}, },

View File

@@ -23,30 +23,6 @@ const pagination = {
{ {
value: 4, value: 4,
label: '40k cells' label: '40k cells'
},
{
value: 5,
label: '50k cells'
},
{
value: 6,
label: '60k cells'
},
{
value: 7,
label: '70k cells'
},
{
value: 8,
label: '80k cells'
},
{
value: 9,
label: '90k cells'
},
{
value: 10,
label: '100k cells'
} }
], ],
defaultValue: 2 defaultValue: 2
@@ -55,7 +31,8 @@ const pagination = {
ref: 'errormessage', ref: 'errormessage',
label: 'Default error message', label: 'Default error message',
type: 'string', type: 'string',
defaultValue: 'Unable to display all the data. Apply more filters to limit the amount of displayed data.' defaultValue: `Unable to display all the data.
Change the pagination size supported or apply more filters to limit the amount of displayed data.`
} }
} }
}; };

View File

@@ -209,6 +209,23 @@ const tableFormat = {
], ],
defaultValue: 'right' defaultValue: 'right'
}, },
FitChartWidth: {
ref: 'fitchartwidth',
type: 'boolean',
component: 'switch',
label: 'Fill chart width',
options: [
{
value: true,
label: 'On'
},
{
value: false,
label: 'Off'
}
],
defaultValue: false
},
ColumnWidthSlider: { ColumnWidthSlider: {
type: 'number', type: 'number',
component: 'slider', component: 'slider',
@@ -217,7 +234,8 @@ const tableFormat = {
min: 20, min: 20,
max: 250, max: 250,
step: 10, step: 10,
defaultValue: 50 defaultValue: 50,
show: data => !data.fitchartwidth
}, },
SymbolForNulls: { SymbolForNulls: {
ref: 'symbolfornulls', ref: 'symbolfornulls',

View File

@@ -7,13 +7,12 @@ function cleanupNodes (node) {
}); });
} }
function buildTableHTML (id, title, subtitle, footnote) { function buildTableHTML (containerElement, title, subtitle, footnote) {
const titleHTML = `<p style="font-size:15pt"><b>${title}</b></p>`; const titleHTML = `<p style="font-size:15pt"><b>${title}</b></p>`;
const subtitleHTML = `<p style="font-size:11pt">${subtitle}</p>`; const subtitleHTML = `<p style="font-size:11pt">${subtitle}</p>`;
const footnoteHTML = `<p style="font-size:11pt">${footnote}</p>`; const footnoteHTML = `<p style="font-size:11pt">${footnote}</p>`;
const container = document.querySelector(`[tid="${id}"]`); const kpiTableClone = containerElement[0].querySelector('.kpi-table').cloneNode(true);
const kpiTableClone = container.querySelector('.kpi-table').cloneNode(true); const dataTableClone = containerElement[0].querySelector('.data-table').cloneNode(true);
const dataTableClone = container.querySelector('.data-table').cloneNode(true);
cleanupNodes(kpiTableClone); cleanupNodes(kpiTableClone);
cleanupNodes(kpiTableClone); cleanupNodes(kpiTableClone);
@@ -83,7 +82,7 @@ function buildTableHTML (id, title, subtitle, footnote) {
function downloadXLS (html) { function downloadXLS (html) {
const filename = 'analysis.xls'; const filename = 'analysis.xls';
const blobObject = new Blob([html]); const blobObject = new Blob([html], { type: 'application/vnd.ms-excel' });
// IE/Edge // IE/Edge
if (window.navigator.msSaveOrOpenBlob) { if (window.navigator.msSaveOrOpenBlob) {
@@ -100,8 +99,8 @@ function downloadXLS (html) {
return true; return true;
} }
export function exportXLS (id, title, subtitle, footnote) { export function exportXLS (containerElement, title, subtitle, footnote) {
// original was removing icon when starting export, disable and some spinner instead, shouldn't take enough time to warrant either..? // original was removing icon when starting export, disable and some spinner instead, shouldn't take enough time to warrant either..?
const table = buildTableHTML(id, title, subtitle, footnote); const table = buildTableHTML(containerElement, title, subtitle, footnote);
downloadXLS(table); downloadXLS(table);
} }

View File

@@ -1,42 +0,0 @@
import React from 'react';
import PropTypes from 'prop-types';
import { exportXLS } from './excel-export';
class ExportButton extends React.PureComponent {
constructor (props) {
super(props);
this.handleExport = this.handleExport.bind(this);
}
handleExport () {
const { id, excelExport, general } = this.props;
const { title, subtitle, footnote } = general;
if (excelExport) {
exportXLS(id, title, subtitle, footnote);
}
}
render () {
const { excelExport } = this.props;
return excelExport === true && (
<input
className="icon-xls"
onClick={this.handleExport}
src="/Extensions/qlik-smart-pivot/Excel.png"
type="image"
/>
);
}
}
ExportButton.defaultProps = {
excelExport: false
};
ExportButton.propTypes = {
id: PropTypes.string.isRequired,
excelExport: PropTypes.bool,
general: PropTypes.shape({}).isRequired
};
export default ExportButton;

View File

@@ -10,13 +10,13 @@ class ColumnHeader extends React.PureComponent {
} }
handleSelect () { handleSelect () {
const { entry, qlik } = this.props; const { component, entry } = this.props;
qlik.backendApi.selectValues(1, [entry.elementNumber], true); component.backendApi.selectValues(1, [entry.elementNumber], false);
} }
render () { render () {
const { baseCSS, cellWidth, colSpan, entry, styling, qlik } = this.props; const { baseCSS, cellWidth, colSpan, component, entry, styling } = this.props;
const inEditState = qlik.inEditState(); const inEditState = component.inEditState();
const isMediumFontSize = styling.headerOptions.fontSizeAdjustment === HEADER_FONT_SIZE.MEDIUM; const isMediumFontSize = styling.headerOptions.fontSizeAdjustment === HEADER_FONT_SIZE.MEDIUM;
const style = { const style = {
@@ -53,13 +53,9 @@ ColumnHeader.defaultProps = {
ColumnHeader.propTypes = { ColumnHeader.propTypes = {
baseCSS: PropTypes.shape({}).isRequired, baseCSS: PropTypes.shape({}).isRequired,
cellWidth: PropTypes.string, cellWidth: PropTypes.string.isRequired,
colSpan: PropTypes.number, colSpan: PropTypes.number,
entry: PropTypes.shape({ component: PropTypes.shape({
elementNumber: PropTypes.number.isRequired,
name: PropTypes.string.isRequired
}).isRequired,
qlik: PropTypes.shape({
backendApi: PropTypes.shape({ backendApi: PropTypes.shape({
selectValues: function (props, propName) { selectValues: function (props, propName) {
if (props.isSnapshot || typeof props[propName] === 'function') { if (props.isSnapshot || typeof props[propName] === 'function') {
@@ -69,6 +65,10 @@ ColumnHeader.propTypes = {
} }
}).isRequired }).isRequired
}).isRequired, }).isRequired,
entry: PropTypes.shape({
displayValue: PropTypes.string.isRequired,
elementNumber: PropTypes.number.isRequired
}).isRequired,
styling: PropTypes.shape({ styling: PropTypes.shape({
headerOptions: PropTypes.shape({ headerOptions: PropTypes.shape({
fontSizeAdjustment: PropTypes.number.isRequired fontSizeAdjustment: PropTypes.number.isRequired

View File

@@ -1,9 +1,10 @@
import React from 'react'; import React from 'react';
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import ExportButton from '../export-button.jsx';
import { HEADER_FONT_SIZE } from '../initialize-transformed'; import { HEADER_FONT_SIZE } from '../initialize-transformed';
import Tooltip from '../tooltip/index.jsx';
const ExportColumnHeader = ({ id, baseCSS, general, title, allowExcelExport, hasSecondDimension, styling }) => { const Dim1Header = ({ component, baseCSS, title, hasSecondDimension, styling }) => {
const inEditState = component.inEditState();
const rowSpan = hasSecondDimension ? 2 : 1; const rowSpan = hasSecondDimension ? 2 : 1;
const isMediumFontSize = styling.headerOptions.fontSizeAdjustment === HEADER_FONT_SIZE.MEDIUM; const isMediumFontSize = styling.headerOptions.fontSizeAdjustment === HEADER_FONT_SIZE.MEDIUM;
const style = { const style = {
@@ -21,21 +22,20 @@ const ExportColumnHeader = ({ id, baseCSS, general, title, allowExcelExport, has
rowSpan={rowSpan} rowSpan={rowSpan}
style={style} style={style}
> >
<ExportButton <Tooltip
id={id} isTooltipActive={!inEditState}
excelExport={allowExcelExport} styling={styling}
general={general} tooltipText={title}
/> >
{title} {title}
</Tooltip>
</th> </th>
); );
}; };
ExportColumnHeader.propTypes = { Dim1Header.propTypes = {
id: PropTypes.string.isRequired,
allowExcelExport: PropTypes.bool.isRequired,
baseCSS: PropTypes.shape({}).isRequired, baseCSS: PropTypes.shape({}).isRequired,
general: PropTypes.shape({}).isRequired, component: PropTypes.shape({}).isRequired,
hasSecondDimension: PropTypes.bool.isRequired, hasSecondDimension: PropTypes.bool.isRequired,
styling: PropTypes.shape({ styling: PropTypes.shape({
headerOptions: PropTypes.shape({ headerOptions: PropTypes.shape({
@@ -45,4 +45,4 @@ ExportColumnHeader.propTypes = {
title: PropTypes.string.isRequired title: PropTypes.string.isRequired
}; };
export default ExportColumnHeader; export default Dim1Header;

View File

@@ -1,124 +1,124 @@
import React from 'react'; import React from 'react';
import PropTypes from 'prop-types'; import PropTypes from 'prop-types';
import ExportColumnHeader from './export-column-header.jsx'; import Dim1Header from './dim1-header.jsx';
import ColumnHeader from './column-header.jsx'; import ColumnHeader from './column-header.jsx';
import MeasurementColumnHeader from './measurement-column-header.jsx'; import MeasurementColumnHeader from './measurement-column-header.jsx';
import { injectSeparators } from '../utilities'; import { injectSeparators } from '../utilities';
const HeadersTable = ({ data, general, qlik, styling, isKpi }) => { class HeadersTable extends React.PureComponent {
const baseCSS = { render () {
backgroundColor: styling.headerOptions.colorSchema, const {
color: styling.headerOptions.textColor, cellWidth,
fontFamily: styling.options.fontFamily, columnSeparatorWidth,
textAlign: styling.headerOptions.alignment component,
}; data,
isKpi,
styling
} = this.props;
const { const baseCSS = {
dimension1, backgroundColor: styling.headerOptions.colorSchema,
dimension2, color: styling.headerOptions.textColor,
measurements fontFamily: styling.options.fontFamily,
} = data.headers; textAlign: styling.headerOptions.alignment
};
const hasSecondDimension = dimension2.length > 0; const {
dimension1,
dimension2,
measurements
} = data.headers;
return ( const hasSecondDimension = dimension2.length > 0;
<div className="header-wrapper">
<table className="header">
<tbody>
<tr>
{isKpi ?
<ExportColumnHeader
id={qlik.options.id}
allowExcelExport={general.allowExcelExport}
baseCSS={baseCSS}
general={general}
hasSecondDimension={hasSecondDimension}
styling={styling}
title={dimension1[0].name}
/> : null
}
{!isKpi && !hasSecondDimension && measurements.map(measurementEntry => (
<MeasurementColumnHeader
baseCSS={baseCSS}
general={general}
hasSecondDimension={hasSecondDimension}
key={`${measurementEntry.displayValue}-${measurementEntry.name}`}
measurement={measurementEntry}
styling={styling}
/>
))}
{!isKpi && hasSecondDimension && injectSeparators(dimension2, styling.useSeparatorColumns).map((entry, index) => {
if (entry.isSeparator) {
const separatorStyle = {
color: 'white',
fontFamily: styling.options.fontFamily,
fontSize: `${13 + styling.headerOptions.fontSizeAdjustment}px`
};
return ( const separatorStyle = {
<th minWidth: columnSeparatorWidth,
className="empty" maxWidth: columnSeparatorWidth
key={index} };
style={separatorStyle}
> return (
* <div className="header-wrapper">
</th> <table className="header">
); <tbody>
} <tr>
return ( {isKpi ?
<ColumnHeader <Dim1Header
baseCSS={baseCSS} baseCSS={baseCSS}
cellWidth={general.cellWidth} component={component}
colSpan={measurements.length} hasSecondDimension={hasSecondDimension}
entry={entry} styling={styling}
key={entry.displayValue} title={dimension1[0].name}
qlik={qlik} /> : null
}
{!isKpi && !hasSecondDimension && measurements.map(measurementEntry => (
<MeasurementColumnHeader
baseCSS={baseCSS}
cellWidth={cellWidth}
hasSecondDimension={hasSecondDimension}
key={`${measurementEntry.displayValue}-${measurementEntry.name}-${measurementEntry.index}`}
measurement={measurementEntry}
styling={styling} styling={styling}
/> />
); ))}
})} {!isKpi && hasSecondDimension && injectSeparators(dimension2, columnSeparatorWidth).map((entry, index) => {
</tr> if (entry.isSeparator) {
{!isKpi && hasSecondDimension && (
<tr>
{injectSeparators(dimension2, styling.useSeparatorColumns).map((dimensionEntry, index) => {
if (dimensionEntry.isSeparator) {
const separatorStyle = {
color: 'white',
fontFamily: styling.options.fontFamily,
fontSize: `${12 + styling.headerOptions.fontSizeAdjustment}px`
};
return ( return (
<th <th
className="empty" className="empty"
key={index} key={index}
style={separatorStyle} style={separatorStyle}
> />
*
</th>
); );
} }
return measurements.map(measurementEntry => ( return (
<MeasurementColumnHeader <ColumnHeader
baseCSS={baseCSS} baseCSS={baseCSS}
dimensionEntry={dimensionEntry} cellWidth={cellWidth}
general={general} colSpan={measurements.length}
hasSecondDimension={hasSecondDimension} component={component}
key={`${measurementEntry.displayValue}-${measurementEntry.name}-${dimensionEntry.name}`} entry={entry}
measurement={measurementEntry} key={entry.displayValue}
styling={styling} styling={styling}
/> />
)); );
})} })}
</tr> </tr>
)} {!isKpi && hasSecondDimension && (
</tbody> <tr>
</table> {injectSeparators(dimension2, columnSeparatorWidth).map((dimensionEntry, index) => {
</div> if (dimensionEntry.isSeparator) {
); return (
}; <th
className="empty"
key={index}
style={separatorStyle}
/>
);
}
return measurements.map(measurementEntry => (
<MeasurementColumnHeader
baseCSS={baseCSS}
cellWidth={cellWidth}
dimensionEntry={dimensionEntry}
hasSecondDimension={hasSecondDimension}
key={`${measurementEntry.displayValue}-${measurementEntry.name}-${measurementEntry.index}-${dimensionEntry.name}`}
measurement={measurementEntry}
styling={styling}
/>
));
})}
</tr>
)}
</tbody>
</table>
</div>
);
}
}
HeadersTable.propTypes = { HeadersTable.propTypes = {
cellWidth: PropTypes.string.isRequired,
columnSeparatorWidth: PropTypes.string.isRequired,
data: PropTypes.shape({ data: PropTypes.shape({
headers: PropTypes.shape({ headers: PropTypes.shape({
dimension1: PropTypes.array, dimension1: PropTypes.array,
@@ -126,17 +126,7 @@ HeadersTable.propTypes = {
measurements: PropTypes.array measurements: PropTypes.array
}) })
}).isRequired, }).isRequired,
general: PropTypes.shape({}).isRequired, component: PropTypes.shape({}).isRequired,
qlik: PropTypes.shape({
backendApi: PropTypes.shape({
selectValues: function (props, propName) {
if (props.isSnapshot || typeof props[propName] === 'function') {
return null;
}
return new Error('Missing implementation of qlik.backendApi.selectValues.');
}
}).isRequired
}).isRequired,
styling: PropTypes.shape({ styling: PropTypes.shape({
headerOptions: PropTypes.shape({}), headerOptions: PropTypes.shape({}),
options: PropTypes.shape({}) options: PropTypes.shape({})

View File

@@ -3,25 +3,27 @@ import PropTypes from 'prop-types';
import { HEADER_FONT_SIZE } from '../initialize-transformed'; import { HEADER_FONT_SIZE } from '../initialize-transformed';
import Tooltip from '../tooltip/index.jsx'; import Tooltip from '../tooltip/index.jsx';
const MeasurementColumnHeader = ({ baseCSS, general, hasSecondDimension, measurement, styling }) => { const MeasurementColumnHeader = ({ baseCSS, cellWidth, hasSecondDimension, measurement, styling }) => {
const title = `${measurement.name}`; const title = `${measurement.name}`;
const { fontSizeAdjustment } = styling.headerOptions; const { fontSizeAdjustment } = styling.headerOptions;
const isMediumFontSize = fontSizeAdjustment === HEADER_FONT_SIZE.MEDIUM; const isMediumFontSize = fontSizeAdjustment === HEADER_FONT_SIZE.MEDIUM;
const cellStyle = {
...baseCSS,
verticalAlign: 'middle',
minWidth: cellWidth,
maxWidth: cellWidth
};
if (hasSecondDimension) { if (hasSecondDimension) {
const isPercentageFormat = measurement.format.substring(measurement.format.length - 1) === '%'; const isPercentageFormat = measurement.format.substring(measurement.format.length - 1) === '%';
let baseFontSize = 14; let baseFontSize = 14;
if (isPercentageFormat) { if (isPercentageFormat) {
baseFontSize = 13; baseFontSize = 13;
} }
const cellStyle = { cellStyle.fontSize = `${baseFontSize + fontSizeAdjustment}px`;
...baseCSS, cellStyle.height = isMediumFontSize ? '45px' : '35px';
fontSize: `${baseFontSize + fontSizeAdjustment}px`,
height: isMediumFontSize ? '45px' : '35px',
verticalAlign: 'middle',
minWidth: general.cellWidth,
maxWidth: general.cellWidth
};
return ( return (
<th <th
className="grid-cells" className="grid-cells"
@@ -37,18 +39,12 @@ const MeasurementColumnHeader = ({ baseCSS, general, hasSecondDimension, measure
); );
} }
const style = { cellStyle.fontSize = `${15 + fontSizeAdjustment}px`;
...baseCSS, cellStyle.height = isMediumFontSize ? '90px' : '70px';
fontSize: `${15 + fontSizeAdjustment}px`,
height: isMediumFontSize ? '90px' : '70px',
verticalAlign: 'middle',
minWidth: general.cellWidth,
maxWidth: general.cellWidth
};
return ( return (
<th <th
className="grid-cells" className="grid-cells"
style={style} style={cellStyle}
> >
<Tooltip <Tooltip
tooltipText={title} tooltipText={title}
@@ -66,9 +62,7 @@ MeasurementColumnHeader.defaultProps = {
MeasurementColumnHeader.propTypes = { MeasurementColumnHeader.propTypes = {
baseCSS: PropTypes.shape({}).isRequired, baseCSS: PropTypes.shape({}).isRequired,
general: PropTypes.shape({ cellWidth: PropTypes.string.isRequired,
cellWidth: PropTypes.string.isRequired
}).isRequired,
hasSecondDimension: PropTypes.bool, hasSecondDimension: PropTypes.bool,
measurement: PropTypes.shape({ measurement: PropTypes.shape({
name: PropTypes.string.isRequired name: PropTypes.string.isRequired

View File

@@ -1,21 +1,19 @@
import definition from './definition'; import definition from "./definition";
import { initializeDataCube, initializeDesignList } from './dataset'; import { exportXLS } from "./excel-export";
import initializeStore from './store'; import { initializeDataCube, initializeDesignList } from "./dataset";
import React from 'react'; import initializeStore from "./store";
import ReactDOM from 'react-dom'; import qlik from "qlik";
import Root from './root.jsx'; import React from "react";
import './main.less'; import ReactDOM from "react-dom";
import Root from "./root.jsx";
import "./main.less";
if (!window._babelPolyfill) { // eslint-disable-line no-underscore-dangle if (!window._babelPolyfill) {
require('@babel/polyfill'); // eslint-disable-line global-require // eslint-disable-line no-underscore-dangle
require("@babel/polyfill"); // eslint-disable-line global-require
} }
export default { export default {
controller: [
'$scope',
'$timeout',
function controller () {}
],
design: { design: {
dimensions: { dimensions: {
max: 1, max: 1,
@@ -24,20 +22,23 @@ export default {
}, },
data: { data: {
dimensions: { dimensions: {
max: function (nMeasures) { max (nMeasures) {
return nMeasures < 9 ? 2 : 1; return nMeasures < 9 ? 2 : 1;
}, },
min: 1, min: 1,
uses: 'dimensions' uses: 'dimensions'
}, },
measures: { measures: {
max: function (nDims) { max (nDims) {
return nDims < 2 ? 9 : 8; return nDims < 2 ? 9 : 8;
}, },
min: 1, min: 1,
uses: 'measures' uses: 'measures'
} }
}, },
// Prevent conversion from and to this object
exportProperties: null,
importProperties: null,
definition, definition,
initialProperties: { initialProperties: {
version: 1.0, version: 1.0,
@@ -45,11 +46,14 @@ export default {
qDimensions: [], qDimensions: [],
qInitialDataFetch: [ qInitialDataFetch: [
{ {
qHeight: 1, qTop: 0,
qWidth: 10 qLeft: 0,
qWidth: 50,
qHeight: 50
} }
], ],
qMeasures: [] qMeasures: [],
qSuppressZero: false
} }
}, },
support: { support: {
@@ -57,23 +61,32 @@ export default {
exportData: true, exportData: true,
snapshot: true snapshot: true
}, },
paint: async function ($element, layout) { async paint ($element, layout, requestPage) {
const dataCube = await initializeDataCube(this, layout); const dataCube = await initializeDataCube(this, layout, requestPage);
const designList = await initializeDesignList(this, layout);
const state = await initializeStore({
$element,
component: this,
dataCube,
designList,
layout
});
const editmodeClass = this.inAnalysisState() ? '' : 'edit-mode'; const editmodeClass = this.inAnalysisState() ? '' : 'edit-mode';
let state, designList;
if (dataCube === null) {
state = {
$element,
component: this,
dataCube,
designList,
layout,
error: true
};
} else {
designList = await initializeDesignList(this, layout);
state = await initializeStore({
$element,
component: this,
dataCube,
designList,
layout,
error: false
});
}
const jsx = ( const jsx = (
<Root <Root editmodeClass={editmodeClass} component={this} state={state} />
editmodeClass={editmodeClass}
qlik={this}
state={state}
/>
); );
ReactDOM.render(jsx, $element[0]); ReactDOM.render(jsx, $element[0]);
@@ -81,10 +94,41 @@ export default {
snapshot: { snapshot: {
canTakeSnapshot: true canTakeSnapshot: true
}, },
setSnapshotData: async function (snapshotLayout) { async setSnapshotData (snapshotLayout) {
snapshotLayout.snapshotData.dataCube = await initializeDataCube(this, snapshotLayout); snapshotLayout.snapshotData.dataCube = await initializeDataCube(
snapshotLayout.snapshotData.designList = await initializeDesignList(this, snapshotLayout); this,
snapshotLayout
);
snapshotLayout.snapshotData.designList = await initializeDesignList(
this,
snapshotLayout
);
return snapshotLayout; return snapshotLayout;
}, },
async getContextMenu (obj, menu) {
const app = qlik.currApp(this);
const isPersonalResult = await app.global.isPersonalMode();
if (
!this.$scope.layout.allowexportxls ||
(isPersonalResult && isPersonalResult.qReturn)
) {
return menu;
}
menu.addItem({
translation: 'Export as XLS',
tid: 'export-excel',
icon: 'export',
select: () => {
exportXLS(
this.$element,
this.$scope.layout.title,
this.$scope.layout.subtitle,
this.$scope.layout.footnote
);
}
});
return menu;
},
version: 1.0 version: 1.0
}; };

View File

@@ -64,63 +64,64 @@ function generateMatrixCell ({ cell, dimension1Information, dimension2Informatio
if (dimension2Information) { if (dimension2Information) {
matrixCell.parents.dimension2 = { matrixCell.parents.dimension2 = {
elementNumber: dimension2Information.qElemNumber elementNumber: dimension2Information.qElemNumber,
header: dimension2Information.qText
}; };
} }
return matrixCell; return matrixCell;
} }
let lastRow = 0;
function generateDataSet (
component, dimensionsInformation, measurementsInformation, dataCube) {
function generateDataSet (component, dimensionsInformation, measurementsInformation, dataCube) {
const measurements = generateMeasurements(measurementsInformation); const measurements = generateMeasurements(measurementsInformation);
let dimension1 = []; let dimension1 = [];
let dimension2 = []; let dimension2 = [];
let matrix = []; let matrix = [];
const hasSecondDimension = dimensionsInformation.length > 1; const hasSecondDimension = dimensionsInformation.length > 1;
dataCube.forEach(row => { // eslint-disable-next-line no-undefined
lastRow += 1; for (let index = 0; dataCube[index] !== undefined; index++) {
const dimension1Entry = generateDimensionEntry(dimensionsInformation[0], row[0]); // eslint-disable-next-line no-loop-func
dimension1.push(dimension1Entry); dataCube[index].forEach(row => {
let dimension2Entry; const dimension1Entry = generateDimensionEntry(dimensionsInformation[0], row[0]);
let firstDataCell = 1; dimension1.push(dimension1Entry);
if (hasSecondDimension) { let dimension2Entry;
dimension2Entry = generateDimensionEntry(dimensionsInformation[1], row[1]); let firstDataCell = 1;
dimension2.push(dimension2Entry); if (hasSecondDimension) {
firstDataCell = 2; dimension2Entry = generateDimensionEntry(dimensionsInformation[1], row[1]);
} dimension2.push(dimension2Entry);
let matrixRow = row firstDataCell = 2;
.slice(firstDataCell, row.length) }
.map((cell, cellIndex) => { let matrixRow = row
const measurementInformation = measurements[cellIndex]; .slice(firstDataCell, row.length)
measurementInformation.index = cellIndex; .map((cell, cellIndex) => {
const dimension1Information = row[0]; // eslint-disable-line prefer-destructuring const measurementInformation = measurements[cellIndex];
const dimension2Information = hasSecondDimension ? row[1] : null; measurementInformation.index = cellIndex;
const generatedCell = generateMatrixCell({ const dimension1Information = row[0]; // eslint-disable-line prefer-destructuring
cell, const dimension2Information = hasSecondDimension ? row[1] : null;
dimension1Information, const generatedCell = generateMatrixCell({
dimension2Information, cell,
measurementInformation dimension1Information,
dimension2Information,
measurementInformation
});
return generatedCell;
}); });
return generatedCell; let appendToRowIndex = matrix.length;
}); if (hasSecondDimension) {
let appendToRowIndex = matrix.length;
if (hasSecondDimension) {
// See if there already is a row for the current dim1 // See if there already is a row for the current dim1
for (let i = 0; i < matrix.length; i++) { for (let i = 0; i < matrix.length; i++) {
if (matrix[i][0].parents.dimension1.header === matrixRow[0].parents.dimension1.header) { if (matrix[i][0].parents.dimension1.header === matrixRow[0].parents.dimension1.header) {
appendToRowIndex = i; appendToRowIndex = i;
matrixRow = matrix[i].concat(matrixRow); matrixRow = matrix[i].concat(matrixRow);
}
} }
} }
} matrix[appendToRowIndex] = matrixRow;
matrix[appendToRowIndex] = matrixRow; });
}); }
// filter header dimensions to only have distinct values // filter header dimensions to only have distinct values
dimension1 = distinctArray(dimension1); dimension1 = distinctArray(dimension1);
@@ -141,7 +142,7 @@ function generateDataSet (
let rowDataIndex = 0; let rowDataIndex = 0;
dimension2.forEach(dim => { dimension2.forEach(dim => {
rowDataIndex = appendMissingCells( rowDataIndex = appendMissingCells(
row, newRow, rowDataIndex, measurements, rowIndex, dim.elementNumber); row, newRow, rowDataIndex, measurements, rowIndex, dim, dimension1);
}); });
} else { } else {
appendMissingCells(row, newRow, 0, measurements, rowIndex); appendMissingCells(row, newRow, 0, measurements, rowIndex);
@@ -165,14 +166,11 @@ function generateDataSet (
* index of the dimension2 value being processed. * index of the dimension2 value being processed.
*/ */
function appendMissingCells ( function appendMissingCells (
sourceRow, destRow, sourceIndex, measurements, dim1ElementNumber, dim2ElementNumber = -1) { sourceRow, destRow, sourceIndex, measurements, matrixIndex, dim2, dim1) {
let index = sourceIndex; let index = sourceIndex;
measurements.forEach((measurement, measureIndex) => { measurements.forEach((measurement, measureIndex) => {
if (index < sourceRow.length if (index < sourceRow.length) {
&& (dim2ElementNumber === -1
|| sourceRow[index].parents.dimension2.elementNumber === dim2ElementNumber)
&& sourceRow[index].parents.measurement.header === measurement.name) {
// Source contains the expected cell // Source contains the expected cell
destRow.push(sourceRow[index]); destRow.push(sourceRow[index]);
index++; index++;
@@ -181,8 +179,14 @@ function appendMissingCells (
destRow.push({ destRow.push({
displayValue: '', displayValue: '',
parents: { parents: {
dimension1: { elementNumber: dim1ElementNumber }, dimension1: {
dimension2: { elementNumber: dim2ElementNumber }, elementNumber: dim1[matrixIndex].elementNumber,
header: dim1[matrixIndex].displayValue
},
dimension2: {
elementNumber: dim2.elementNumber,
header: dim2.displayValue
},
measurement: { measurement: {
header: measurement.name, header: measurement.name,
index: measureIndex index: measureIndex
@@ -194,12 +198,10 @@ function appendMissingCells (
return index; return index;
} }
function initializeTransformed ({ $element, component, dataCube, designList, layout }) { function initializeTransformed ({ component, dataCube, designList, layout }) {
const dimensionsInformation = component.backendApi.getDimensionInfos(); const dimensionsInformation = component.backendApi.getDimensionInfos();
const measurementsInformation = component.backendApi.getMeasureInfos(); const measurementsInformation = component.backendApi.getMeasureInfos();
const dimensionCount = layout.qHyperCube.qDimensionInfo.length; const dimensionCount = layout.qHyperCube.qDimensionInfo.length;
const rowCount = component.backendApi.getRowCount();
const maxLoops = layout.maxloops;
const { const {
dimension1, dimension1,
dimension2, dimension2,
@@ -227,6 +229,18 @@ function initializeTransformed ({ $element, component, dataCube, designList, lay
} }
} }
let cellWidth;
if (layout.fitchartwidth) {
// The widths are calculated based on the current element width. Note: this could use % to set
// the widths as percentages of the available width. However, this often results in random
// columns getting 1px wider than the others because of rounding necessary to fill the width.
// This 1px causes missalignment between the data- and header tables.
cellWidth = '';
} else {
// If using the previous solution just set 60px
cellWidth = `${layout.columnwidthslider > 10 ? layout.columnwidthslider : 60}px`;
}
// top level properties could be reducers and then components connect to grab what they want, // top level properties could be reducers and then components connect to grab what they want,
// possibly with reselect for some presentational transforms (moving some of the presentational logic like formatting and such) // possibly with reselect for some presentational transforms (moving some of the presentational logic like formatting and such)
const transformedProperties = { const transformedProperties = {
@@ -244,13 +258,12 @@ function initializeTransformed ({ $element, component, dataCube, designList, lay
general: { general: {
allowExcelExport: layout.allowexportxls, allowExcelExport: layout.allowexportxls,
allowFilteringByClick: layout.filteroncellclick, allowFilteringByClick: layout.filteroncellclick,
// If using the previous solution just set 60px cellWidth: cellWidth,
cellWidth: `${layout.columnwidthslider > 10 ? layout.columnwidthslider : 60}px`,
errorMessage: layout.errormessage, errorMessage: layout.errormessage,
footnote: layout.footnote, footnote: layout.footnote,
maxLoops,
subtitle: layout.subtitle, subtitle: layout.subtitle,
title: layout.title title: layout.title,
useColumnSeparator: layout.separatorcols && dimensionCount > 1
}, },
selection: { selection: {
dimensionSelectionCounts: dimensionsInformation.map(dimensionInfo => dimensionInfo.qStateCounts.qSelected) dimensionSelectionCounts: dimensionsInformation.map(dimensionInfo => dimensionInfo.qStateCounts.qSelected)
@@ -304,25 +317,10 @@ function initializeTransformed ({ $element, component, dataCube, designList, lay
} }
}, },
symbolForNulls: layout.symbolfornulls, symbolForNulls: layout.symbolfornulls,
usePadding: layout.indentbool, usePadding: layout.indentbool
useSeparatorColumns: dimensionCount === 1 ? false : layout.separatorcols
} }
}; };
if (rowCount > lastRow && rowCount <= (maxLoops * 1000)) {
const requestPage = [
{
qHeight: Math.min(1000, rowCount - lastRow),
qLeft: 0,
qTop: matrix.length,
qWidth: 10 // should be # of columns
}
];
component.backendApi.getData(requestPage).then(() => {
component.paint($element, layout);
});
}
return transformedProperties; return transformedProperties;
} }

View File

@@ -33,7 +33,7 @@ class LinkedScrollWrapper extends React.PureComponent {
unlinkComponent (component) { unlinkComponent (component) {
const componentIndex = this.scrollElements.map(element => element.component).indexOf(component); const componentIndex = this.scrollElements.map(element => element.component).indexOf(component);
if (componentIndex !== -1) { if (componentIndex !== -1) {
this.scrollElements.removeAt(componentIndex); this.scrollElements.splice(componentIndex, 1);
// eslint-disable-next-line react/no-find-dom-node // eslint-disable-next-line react/no-find-dom-node
const node = ReactDOM.findDOMNode(component); const node = ReactDOM.findDOMNode(component);
node.onscroll = null; node.onscroll = null;

View File

@@ -57,10 +57,8 @@
} }
.empty { .empty {
width: 3%;
background: #fff; background: #fff;
min-width: 4px !important; padding: 0 !important;
max-width: 4px !important;
} }
th.main-kpi { th.main-kpi {
@@ -107,6 +105,20 @@
width: 100%; width: 100%;
} }
.error {
position: absolute; /*Define position */
width: 100%; /* Full width (cover the whole page) */
height: 100%; /* Full height (cover the whole page) */
top: 0;
left: 0;
right: 0;
bottom: 0;
z-index: 1000; /* Specify a stack order in case you're using a different order for other elements */
display: flex;
justify-content: center;
align-items: center;
}
.kpi-table .fdim-cells, .kpi-table .fdim-cells,
.data-table td { .data-table td {
line-height: 1em !important; line-height: 1em !important;

View File

@@ -1,64 +1,143 @@
import React from 'react'; import React from "react";
import PropTypes from 'prop-types'; import PropTypes from "prop-types";
import HeadersTable from './headers-table/index.jsx'; import HeadersTable from "./headers-table/index.jsx";
import DataTable from './data-table/index.jsx'; import DataTable from "./data-table/index.jsx";
import { LinkedScrollWrapper, LinkedScrollSection } from './linked-scroll'; import { LinkedScrollWrapper, LinkedScrollSection } from "./linked-scroll";
const Root = ({ state, qlik, editmodeClass }) => ( class Root extends React.PureComponent {
<div className="root"> constructor (props) {
<LinkedScrollWrapper> super(props);
<div className={`kpi-table ${editmodeClass}`}> this.onDataTableRefSet = this.onDataTableRefSet.bind(this);
<HeadersTable this.renderedTableWidth = 0;
data={state.data} }
general={state.general}
isKpi componentDidUpdate () {
qlik={qlik} let tableWidth;
styling={state.styling} if (this.dataTableRef) {
/> tableWidth = this.dataTableRef.getBoundingClientRect().width;
<LinkedScrollSection linkVertical> if (this.renderedTableWidth !== tableWidth) {
<DataTable this.forceUpdate();
data={state.data} }
general={state.general} }
qlik={qlik} }
renderData={false}
styling={state.styling} onDataTableRefSet (element) {
/> this.dataTableRef = element;
</LinkedScrollSection> this.forceUpdate();
}
render () {
const { editmodeClass, component, state } = this.props;
const { data, general, styling, error } = state;
// Determine cell- and column separator width
let cellWidth = '0px';
let columnSeparatorWidth = '';
if (this.dataTableRef) {
const tableWidth = this.dataTableRef.getBoundingClientRect().width;
this.renderedTableWidth = tableWidth;
if (general.cellWidth) {
cellWidth = general.cellWidth;
if (general.useColumnSeparator) {
columnSeparatorWidth = '8px';
}
} else {
const headerMarginRight = 8;
const borderWidth = 1;
const rowCellCount = data.matrix[0].length;
let separatorCount = 0;
let separatorWidth = 0;
if (general.useColumnSeparator) {
separatorCount = data.headers.dimension2.length - 1;
separatorWidth = Math.min(
Math.floor((tableWidth * 0.2) / separatorCount),
8
);
columnSeparatorWidth = `${separatorWidth}px`;
}
const separatorWidthSum =
(separatorWidth + borderWidth) * separatorCount;
cellWidth = `${Math.floor(
(tableWidth - separatorWidthSum - headerMarginRight - borderWidth) /
rowCellCount) - borderWidth}px`;
}
}
return (
<div className="root">
{error ? (
<div className={`error ${editmodeClass}`}>
{state.layout.errormessage}
</div>
) : (
<LinkedScrollWrapper>
<div className={`kpi-table ${editmodeClass}`}>
<HeadersTable
cellWidth={cellWidth}
columnSeparatorWidth={columnSeparatorWidth}
component={component}
data={data}
general={general}
isKpi
styling={styling}
/>
<LinkedScrollSection linkVertical>
<DataTable
cellWidth={cellWidth}
columnSeparatorWidth={columnSeparatorWidth}
component={component}
data={data}
general={general}
renderData={false}
styling={styling}
/>
</LinkedScrollSection>
</div>
<div
className={`data-table ${editmodeClass}`}
style={{ width: general.cellWidth ? 'auto' : '100%' }}
ref={this.onDataTableRefSet}
>
<LinkedScrollSection linkHorizontal>
<HeadersTable
cellWidth={cellWidth}
columnSeparatorWidth={columnSeparatorWidth}
component={component}
data={data}
general={general}
isKpi={false}
styling={styling}
/>
</LinkedScrollSection>
<LinkedScrollSection linkHorizontal linkVertical>
<DataTable
cellWidth={cellWidth}
columnSeparatorWidth={columnSeparatorWidth}
component={component}
data={data}
general={general}
styling={styling}
/>
</LinkedScrollSection>
</div>
</LinkedScrollWrapper>
)}
</div> </div>
<div className={`data-table ${editmodeClass}`}> );
<LinkedScrollSection linkHorizontal> }
<HeadersTable }
data={state.data}
general={state.general}
isKpi={false}
qlik={qlik}
styling={state.styling}
/>
</LinkedScrollSection>
<LinkedScrollSection
linkHorizontal
linkVertical
>
<DataTable
data={state.data}
general={state.general}
qlik={qlik}
styling={state.styling}
/>
</LinkedScrollSection>
</div>
</LinkedScrollWrapper>
</div>
);
Root.propTypes = { Root.propTypes = {
qlik: PropTypes.shape({}).isRequired, component: PropTypes.shape({}).isRequired,
editmodeClass: PropTypes.string.isRequired,
state: PropTypes.shape({ state: PropTypes.shape({
data: PropTypes.object.isRequired, data: PropTypes.object,
general: PropTypes.object.isRequired, general: PropTypes.object,
styling: PropTypes.object.isRequired styling: PropTypes.object
}).isRequired, }).isRequired
editmodeClass: PropTypes.string.isRequired
}; };
export default Root; export default Root;

View File

@@ -16,7 +16,7 @@ export function Deferred () {
}); });
} }
export function injectSeparators (array, shouldHaveSeparator, suppliedOptions) { export function injectSeparators (array, columnSeparatorWidth, suppliedOptions) {
const defaultOptions = { const defaultOptions = {
atEvery: 1, atEvery: 1,
separator: { isSeparator: true } separator: { isSeparator: true }
@@ -26,7 +26,7 @@ export function injectSeparators (array, shouldHaveSeparator, suppliedOptions) {
...suppliedOptions ...suppliedOptions
}; };
if (!shouldHaveSeparator) { if (!columnSeparatorWidth) {
return array; return array;
} }
return array.reduce((result, entry, index) => { return array.reduce((result, entry, index) => {