From 073bbbccca8ef9e22a810a8a29edb48883b74694 Mon Sep 17 00:00:00 2001 From: Harshith Mullapudi Date: Wed, 25 May 2022 01:38:29 +0530 Subject: [PATCH] fix: integration tests are failing for tiktok-marketing (#13127) * fix: integration tests are failing for tiktok-marketing * fix: integration tests are failing for tiktok-marketing * chore: publish new version * chore: update seed file --- .../src/main/resources/seed/source_definitions.yaml | 2 +- .../init/src/main/resources/seed/source_specs.yaml | 3 +-- .../connectors/source-tiktok-marketing/Dockerfile | 2 +- .../integration_tests/spec.json | 11 ++++++++--- .../source_tiktok_marketing/spec.py | 4 ++-- docs/integrations/sources/tiktok-marketing.md | 1 + 6 files changed, 14 insertions(+), 9 deletions(-) diff --git a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml index a043cde1b64..b0f4e8a2747 100644 --- a/airbyte-config/init/src/main/resources/seed/source_definitions.yaml +++ b/airbyte-config/init/src/main/resources/seed/source_definitions.yaml @@ -914,7 +914,7 @@ - name: TikTok Marketing sourceDefinitionId: 4bfac00d-ce15-44ff-95b9-9e3c3e8fbd35 dockerRepository: airbyte/source-tiktok-marketing - dockerImageTag: 0.1.11 + dockerImageTag: 0.1.12 documentationUrl: https://docs.airbyte.io/integrations/sources/tiktok-marketing icon: tiktok.svg sourceType: api diff --git a/airbyte-config/init/src/main/resources/seed/source_specs.yaml b/airbyte-config/init/src/main/resources/seed/source_specs.yaml index 0b95a2c423e..c99cfce69d5 100644 --- a/airbyte-config/init/src/main/resources/seed/source_specs.yaml +++ b/airbyte-config/init/src/main/resources/seed/source_specs.yaml @@ -8767,7 +8767,7 @@ supportsNormalization: false supportsDBT: false supported_destination_sync_modes: [] -- dockerImage: "airbyte/source-tiktok-marketing:0.1.11" +- dockerImage: "airbyte/source-tiktok-marketing:0.1.12" spec: documentationUrl: "https://docs.airbyte.io/integrations/sources/tiktok-marketing" changelogUrl: "https://docs.airbyte.io/integrations/sources/tiktok-marketing" @@ -8857,7 +8857,6 @@ \ incremental streams, in the format YYYY-MM-DD. All data generated between\ \ start_date and this date will be replicated. Not setting this option\ \ will result in always syncing the data till the current date." - default: "2022-05-23" pattern: "^[0-9]{4}-[0-9]{2}-[0-9]{2}$" order: 3 type: "string" diff --git a/airbyte-integrations/connectors/source-tiktok-marketing/Dockerfile b/airbyte-integrations/connectors/source-tiktok-marketing/Dockerfile index 9c013f23f79..04834b7eab4 100644 --- a/airbyte-integrations/connectors/source-tiktok-marketing/Dockerfile +++ b/airbyte-integrations/connectors/source-tiktok-marketing/Dockerfile @@ -32,5 +32,5 @@ COPY source_tiktok_marketing ./source_tiktok_marketing ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py" ENTRYPOINT ["python", "/airbyte/integration_code/main.py"] -LABEL io.airbyte.version=0.1.11 +LABEL io.airbyte.version=0.1.12 LABEL io.airbyte.name=airbyte/source-tiktok-marketing diff --git a/airbyte-integrations/connectors/source-tiktok-marketing/integration_tests/spec.json b/airbyte-integrations/connectors/source-tiktok-marketing/integration_tests/spec.json index 796cd56be51..5d8d4799f1f 100644 --- a/airbyte-integrations/connectors/source-tiktok-marketing/integration_tests/spec.json +++ b/airbyte-integrations/connectors/source-tiktok-marketing/integration_tests/spec.json @@ -88,7 +88,6 @@ "end_date": { "title": "End Date", "description": "The date until which you'd like to replicate data for all incremental streams, in the format YYYY-MM-DD. All data generated between start_date and this date will be replicated. Not setting this option will result in always syncing the data till the current date.", - "default": "2022-05-23", "pattern": "^[0-9]{4}-[0-9]{2}-[0-9]{2}$", "order": 3, "type": "string" @@ -122,8 +121,14 @@ "title": "CompleteOauthServerInputSpecification", "type": "object", "properties": { - "app_id": { "title": "App Id", "type": "string" }, - "secret": { "title": "Secret", "type": "string" } + "app_id": { + "title": "App Id", + "type": "string" + }, + "secret": { + "title": "Secret", + "type": "string" + } }, "required": ["app_id", "secret"] }, diff --git a/airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/spec.py b/airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/spec.py index 377a1746090..3c436f47fad 100644 --- a/airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/spec.py +++ b/airbyte-integrations/connectors/source-tiktok-marketing/source_tiktok_marketing/spec.py @@ -10,7 +10,7 @@ from typing import Union from jsonschema import RefResolver from pydantic import BaseModel, Field -from .streams import DEFAULT_END_DATE, DEFAULT_START_DATE, ReportGranularity +from .streams import DEFAULT_START_DATE, ReportGranularity class OauthCredSpec(BaseModel): @@ -63,8 +63,8 @@ class SourceTiktokMarketingSpec(BaseModel): ) end_date: str = Field( + None, title="End Date", - default=DEFAULT_END_DATE, pattern="^[0-9]{4}-[0-9]{2}-[0-9]{2}$", description=( "The date until which you'd like to replicate data for all incremental streams, in the format YYYY-MM-DD. " diff --git a/docs/integrations/sources/tiktok-marketing.md b/docs/integrations/sources/tiktok-marketing.md index 38a381b5176..c50cfaafe91 100644 --- a/docs/integrations/sources/tiktok-marketing.md +++ b/docs/integrations/sources/tiktok-marketing.md @@ -524,6 +524,7 @@ The connector is restricted by [requests limitation](https://ads.tiktok.com/mark | Version | Date | Pull Request | Subject | |:--------|:-----------|:---------------------------------------------------------|:----------------------------------------------------------------------------------------------| +| 0.1.12 | 2022-05-24 | [13127](https://github.com/airbytehq/airbyte/pull/13127) | Fixed integration test | | 0.1.11 | 2022-04-27 | [12838](https://github.com/airbytehq/airbyte/pull/12838) | Added end date configuration for tiktok | | 0.1.10 | 2022-05-07 | [12545](https://github.com/airbytehq/airbyte/pull/12545) | Removed odd production authenication method | | 0.1.9 | 2022-04-30 | [12500](https://github.com/airbytehq/airbyte/pull/12500) | Improve input configuration copy |