jprdonnelly/airbyte
1
0
Fork 0
mirror of synced 2025-12-25 02:09:19 -05:00
Code Issues Packages Projects Releases Wiki Activity

🎉 Source Amazon Ads: increase report_wait_timeout 30 -> 60 minutes (#16453)

Browse Source 
Signed-off-by: Sergey Chvalyuk <grubberr@gmail.com>
This commit is contained in:
Serhii Chvaliuk
2022-09-10 13:48:00 +03:00
committed by GitHub
parent c19811fc89
commit 0ab777f23e
8 changed files with 20 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
airbyte-integrations/connectors/source-amazon-ads/Dockerfile
View File

@@ -12,5 +12,5 @@ RUN pip install .
ENV AIRBYTE_ENTRYPOINT "python /airbyte/integration_code/main.py"
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
LABEL io.airbyte.version=0.1.19
LABEL io.airbyte.version=0.1.20
LABEL io.airbyte.name=airbyte/source-amazon-ads

6
airbyte-integrations/connectors/source-amazon-ads/integration_tests/spec.json
View File

@@ -40,9 +40,9 @@
},
"report_wait_timeout": {
"title": "Report Wait Timeout *",
"description": "Timeout duration in minutes for Reports. Default is 30 minutes.",
"default": 30,
"examples": [30, 120],
"description": "Timeout duration in minutes for Reports. Default is 60 minutes.",
"default": 60,
"examples": [60, 120],
"order": 5,
"type": "integer"
},

6
airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/spec.yaml
View File

@@ -48,10 +48,10 @@ connectionSpecification:
order: 4
report_wait_timeout:
title: Report Wait Timeout *
description: Timeout duration in minutes for Reports. Default is 30 minutes.
default: 30
description: Timeout duration in minutes for Reports. Default is 60 minutes.
default: 60
examples:
- 30
- 60
- 120
order: 5
type: integer

2
airbyte-integrations/connectors/source-amazon-ads/source_amazon_ads/streams/report_streams/report_streams.py
View File

@@ -103,7 +103,7 @@ class ReportStream(BasicAmazonAdsStream, ABC):
self._authenticator = authenticator
self._session = requests.Session()
self._model = self._generate_model()
self.report_wait_timeout = config.get("report_wait_timeout", 30)
self.report_wait_timeout = config.get("report_wait_timeout", 60)
self.report_generation_maximum_retries = config.get("report_generation_max_retries", 5)
self._start_date: Optional[Date] = config.get("start_date")
super().__init__(config, profiles)

12
airbyte-integrations/connectors/source-amazon-ads/unit_tests/test_report_streams.py
View File

@@ -241,7 +241,7 @@ def test_display_report_stream_init_too_many_requests(mocker, config):
),
(
[
(lambda x: x > 5, None, "2021-01-02 03:34:05"),
(lambda x: x > 5, None, "2021-01-02 04:04:05"),
],
ReportGenerationInProgress,
),
@@ -256,11 +256,11 @@ def test_display_report_stream_init_too_many_requests(mocker, config):
(
[
(lambda x: True, "FAILURE", None),
(lambda x: x >= 10, None, "2021-01-02 03:34:05"),
(lambda x: x >= 15, None, "2021-01-02 04:04:05"),
(lambda x: x >= 20, None, "2021-01-02 04:34:05"),
(lambda x: x >= 25, None, "2021-01-02 05:04:05"),
(lambda x: x >= 30, None, "2021-01-02 05:34:05"),
(lambda x: x >= 10, None, "2021-01-02 04:04:05"),
(lambda x: x >= 15, None, "2021-01-02 05:04:05"),
(lambda x: x >= 20, None, "2021-01-02 06:04:05"),
(lambda x: x >= 25, None, "2021-01-02 07:04:05"),
(lambda x: x >= 30, None, "2021-01-02 08:04:05"),
],
ReportGenerationFailure,
),