1
0
mirror of synced 2025-12-25 02:09:19 -05:00

🐞 Fix invalid char in snowflake & bigquery namespace (#10793)

* Add namespace test for snowflake

* Enable namespace test for bigquery

* Format code

* Capitalize test case id

* Update exception message to point to test case file

* Update snowflake name transformer to prepend underscore

* Override convertStreamName instead of getIdentifier

* Add missing state message

* Remove unused import

* Disable more namespace test cases

We don't want to introduce changes that will affect existing connections for now.

* Dry method that mutates namespace

* Pass through null

* Normalize namespace

* Fix test case

* Revert consumer factory changes

* Normalize namespace in catalog

* Revert catalog normalization

* Enable namespace test for all snowflake destination tests

* Test namespace for both bigquery destination tests

* Add unit test for bigquery name transformer

* Transform bigquery schema name

* Fix avro name transformer

* Normalize avro namespace

* Standardize namespace in gcs utils

* Bump version for snowflake and bigquery

* Enable namespace test for bigquery denormalized

* Dry bigquery denormalized acceptance test

* Revert some of the variable scope change

* Fix unit test

* Bump version

* Introduce getNamespace method

* Implement getNamespace method for bigquery

* Switch to getNamespace methods

* Update comments

* Fix bigquery denormalized acceptance test

* Format code

* Dry bigquery destination test

* Skip partition test for gcs mode

* Bump version
This commit is contained in:
LiRen Tu
2022-03-19 17:47:24 -07:00
committed by GitHub
parent 0f475ce6ff
commit 21ec23cc31
32 changed files with 623 additions and 611 deletions

View File

@@ -21,6 +21,12 @@ public interface NamingConventionTransformer {
*/
String getIdentifier(String name);
/**
* Handle naming conversions of an input name to output a valid namespace for the desired
* destination.
*/
String getNamespace(String namespace);
/**
* Same as getIdentifier but returns also the name of the table for storing raw data
*

View File

@@ -22,6 +22,14 @@ public class StandardNameTransformer implements NamingConventionTransformer {
return convertStreamName(name);
}
/**
* Most destinations have the same naming requirement for namespace and stream names.
*/
@Override
public String getNamespace(final String namespace) {
return convertStreamName(namespace);
}
@Override
public String getRawTableName(final String streamName) {
return convertStreamName("_airbyte_raw_" + streamName);