From baae71390b8a229876cda2bfc7d99baeaa9db2a5 Mon Sep 17 00:00:00 2001 From: Greg Solovyev Date: Mon, 7 Mar 2022 16:41:19 -0800 Subject: [PATCH] Fix Sonar for non-python connectors (#10928) This is a quick fix that moves cat ${REPORT_FOLDER}/* inside if block for python-based connectors. --- .github/actions/ci-tests-runner/action.yml | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/.github/actions/ci-tests-runner/action.yml b/.github/actions/ci-tests-runner/action.yml index 006d3edb7a4..6366fcc97bf 100644 --- a/.github/actions/ci-tests-runner/action.yml +++ b/.github/actions/ci-tests-runner/action.yml @@ -113,8 +113,11 @@ runs: [ -f ${{ steps.ci-py-tests.outputs.coverage-paths }} ] && OPTIONS+=("-Dsonar.python.coverage.reportPaths=${{ steps.ci-py-tests.outputs.coverage-paths }}") [ -f ${{ steps.ci-py-tests.outputs.flake8-logs }} ] && OPTIONS+=("-Dsonar.python.flake8.reportPaths=${{ steps.ci-py-tests.outputs.flake8-logs }}") + # TODO: figure out how to make this check work for Java-based connectors + # See more in https://github.com/airbytehq/airbyte/issues/10924 + cat ${REPORT_FOLDER}/* fi - cat ${REPORT_FOLDER}/* + if [ ${{ inputs.module-lang }} == 'java' ]; then [ -d "./src/main/java" ] && OPTIONS+=("-Dsonar.sources=./src/main/java") [ -d "./src/test/java" ] && OPTIONS+=("-Dsonar.tests=./src/test/java")