jprdonnelly/airbyte
1
0
Fork 0
mirror of synced 2025-12-23 21:03:15 -05:00
Code Issues Packages Projects Releases Wiki Activity

Exposing SSL-only version of MySQL Source (#6605)

Browse Source 
* Source MySQL - added option to connect using ssl

* Source MySQL - updated changelog

* dummy commit

* Updated PR as per comment

* added source mysql strict encrypt

* updated code style for MySQL source

* updated code style for MySQL source

* fixed remarks

* fixed code style

* fixed remarks

Co-authored-by: ievgeniit <ievgeniit>
Co-authored-by: ievgeniit <etsybaev@gmail.com>
This commit is contained in:
andriikorotkov
2021-10-05 09:47:10 +03:00
committed by GitHub
parent 38ed5f6cef
commit d746f4922b
13 changed files with 440 additions and 31 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
airbyte-integrations/connectors/source-mysql/src/main/java/io/airbyte/integrations/source/mysql/MySqlSource.java
View File

@@ -53,6 +53,10 @@ public class MySqlSource extends AbstractJdbcSource implements Source {
"requireSSL=true",
"verifyServerCertificate=false");
public static Source sshWrappedSource() {
return new SshWrappedSource(new MySqlSource(), List.of("host"), List.of("port"));
}
public MySqlSource() {
super(DRIVER_CLASS, new MySqlJdbcStreamingQueryConfiguration());
}
@@ -178,7 +182,8 @@ public class MySqlSource extends AbstractJdbcSource implements Source {
jdbcUrl.append("&").append(config.get("jdbc_url_params").asText());
}
if (config.has("ssl") && config.get("ssl").asBoolean()) {
// assume ssl if not explicitly mentioned.
if (!config.has("ssl") || config.get("ssl").asBoolean()) {
jdbcUrl.append("&").append(String.join("&", SSL_PARAMETERS));
}
@@ -236,7 +241,7 @@ public class MySqlSource extends AbstractJdbcSource implements Source {
}
public static void main(String[] args) throws Exception {
final Source source = new SshWrappedSource(new MySqlSource(), List.of("host"), List.of("port"));
final Source source = MySqlSource.sshWrappedSource();
LOGGER.info("starting source: {}", MySqlSource.class);
new IntegrationRunner(source).run(args);
LOGGER.info("completed source: {}", MySqlSource.class);

7
airbyte-integrations/connectors/source-mysql/src/main/resources/spec.json
View File

@@ -42,6 +42,13 @@
"type": "string",
"order": 5
},
"ssl": {
"title": "SSL Connection",
"description": "Encrypt data using SSL.",
"type": "boolean",
"default": true,
"order": 7
},
"replication_method": {
"type": "string",
"title": "Replication Method",

4
airbyte-integrations/connectors/source-mysql/src/test/java/io/airbyte/integrations/source/mysql/MySqlTest.java
View File

@@ -114,8 +114,8 @@ class MySqlTest {
})
void testSmallIntTypes(String type) throws Exception {
database.query(ctx -> {
ctx.fetch(String.format("CREATE TABLE %s(id %s)", JdbcUtils.getFullyQualifiedTableName(null, TABLE_NAME), type));
ctx.fetch(String.format("INSERT INTO %s(id) VALUES (10)", JdbcUtils.getFullyQualifiedTableName(null, TABLE_NAME)));
ctx.fetch(String.format("CREATE TABLE %s(id %s)", TABLE_NAME, type));
ctx.fetch(String.format("INSERT INTO %s(id) VALUES (10)", TABLE_NAME));
return null;
});