jprdonnelly/airbyte
1
0
Fork 0
mirror of synced 2025-12-25 02:09:19 -05:00
Code Issues Packages Projects Releases Wiki Activity

Source Google Ads: upgrade google-ads package version (#9996)

Browse Source 
* upgrade google-ads package version

* add comment about use_proto_plus

* bump version

* updated spec and def yaml

Co-authored-by: auganbay <auganenu@gmail.com>
This commit is contained in:
augan-rymkhan
2022-02-04 11:28:13 +06:00
committed by GitHub
parent 3aa90a7fce
commit d7b9ae2918
7 changed files with 8 additions and 16 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
airbyte-integrations/connectors/source-google-ads/Dockerfile
View File

@@ -13,5 +13,5 @@ RUN pip install .
ENTRYPOINT ["python", "/airbyte/integration_code/main.py"]
LABEL io.airbyte.version=0.1.23
LABEL io.airbyte.version=0.1.24
LABEL io.airbyte.name=airbyte/source-google-ads

2
airbyte-integrations/connectors/source-google-ads/setup.py
View File

@@ -5,7 +5,7 @@
from setuptools import find_packages, setup
MAIN_REQUIREMENTS = ["airbyte-cdk~=0.1", "google-ads==13.0.0", "pendulum"]
MAIN_REQUIREMENTS = ["airbyte-cdk~=0.1", "google-ads==14.1.0", "pendulum"]
TEST_REQUIREMENTS = ["pytest~=6.1", "pytest-mock"]

12
airbyte-integrations/connectors/source-google-ads/source_google_ads/schemas/ad_group_ads.json
View File

@@ -479,9 +479,6 @@
"type": "string"
}
},
"ad_group_ad.ad.video_ad.bumper.companion_banner": {
"type": ["null", "string"]
},
"ad_group_ad.ad.video_ad.discovery.description1": {
"type": ["null", "string"]
},
@@ -497,15 +494,6 @@
"ad_group_ad.ad.video_ad.in_stream.action_headline": {
"type": ["null", "string"]
},
"ad_group_ad.ad.video_ad.in_stream.companion_banner": {
"type": ["null", "string"]
},
"ad_group_ad.ad.video_ad.media_file": {
"type": ["null", "string"]
},
"ad_group_ad.ad.video_ad.non_skippable.companion_banner": {
"type": ["null", "string"]
},
"ad_group_ad.ad.video_ad.out_stream.description": {
"type": ["null", "string"]
},

3
airbyte-integrations/connectors/source-google-ads/source_google_ads/source.py
View File

@@ -35,6 +35,9 @@ class SourceGoogleAds(AbstractSource):
@staticmethod
def get_credentials(config: Mapping[str, Any]) -> Mapping[str, Any]:
credentials = config["credentials"]
# use_proto_plus is set to True, because setting to False returned wrong value types, which breakes the backward compatibility.
# For more info read the related PR's description: https://github.com/airbytehq/airbyte/pull/9996
credentials.update(use_proto_plus=True)
# https://developers.google.com/google-ads/api/docs/concepts/call-structure#cid
if "login_customer_id" in config and config["login_customer_id"].strip():