jprdonnelly/airbyte
1
0
Fork 0
mirror of synced 2025-12-23 21:03:15 -05:00
Code Issues Packages Projects Releases Wiki Activity

🎉 New implementation for AWS Secret Manager for issue (#19690)

Browse Source 
* 🎉 New implementation for AWS Secret Manager for issue
#10518

Added new implementation AWSSecretManagerPersistence and integration tests AWSSecretManagerPersistenceIntegrationTest

A new implementation of SecretPersistence to support AWS Secret Manager AWSSecretManagerPersistence
New Integration tests as suggested on the open Issue, similar to GCP secret manager

* Updated version to `aws-secretsmanager-caching-java:1.0.2`
- Added new argument check for AWS Secret Manager.

* exclude jackson-databind from aws dependency and run gradle format

* bump aws-related dependencies to prevent old version of jackson-databind from being pulled in

* - Added new entry for `AWS_SECRET_MANAGER` into SecretPersistence.java
- Externalized configurations for AWS Secret Manager into Configs and EnvConfigs.java as requested.
- Adjusted test to use new constructor for `AWSSecretManagerPersistence`
- Augmented instructions configuring-airbyte.md with the new config keys.

* Formatting code.

* revert dependency version bump

Co-authored-by: pmossman <parker@airbyte.io>
Co-authored-by: mauricioalarcon <unknown>
This commit is contained in:
Mauricio
2022-12-12 18:25:23 -05:00
committed by GitHub
parent 0af6bd06ba
commit f76833e2e0
7 changed files with 238 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
docs/operator-guides/configuring-airbyte.md
View File

@@ -61,6 +61,8 @@ Set to empty values, e.g. "" to disable basic auth. **Be sure to change these va
5. `VAULT_AUTH_TOKEN` - The token used for vault authentication. Alpha Support.
6. `VAULT_AUTH_METHOD` - How vault will preform authentication. Currently, only supports Token auth. Defaults to token. Alpha Support.
7. `SECRET_PERSISTENCE` - Defines the Secret Persistence type. Defaults to NONE. Set to GOOGLE_SECRET_MANAGER to use Google Secret Manager. Set to TESTING_CONFIG_DB_TABLE to use the database as a test. Set to VAULT to use Hashicorp Vault, currently only the token based authentication is supported. Alpha support. Undefined behavior will result if this is turned on and then off.
8. `AWS_ACCESS_KEY` - Defines the aws_access_key_id from the AWS credentials to use for AWS Secret Manager.
9. `AWS_SECRET_ACCESS_KEY`- Defines aws_secret_access_key to use for the AWS Secret Manager.
#### Database