* Add primary_key noop to docs and PokeAPI connector.
* Small grammar fix in FAQ.
* Change empty string to None for noop.
Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@Abhis-MacBook-Pro.local>
Completely test the OAuth module and streams/core.py file.
Add pytest-mock as well as a convenience wrapper to run the type checker and the test together when developing.
Also configure pytest to pick up loggers at the INFO level and above, and pick up standard out for easier debugging.
Some of the script bits are unpolished - will improve them as we go along.
closes#2722
I don't love the current structure. There is a number of improvements that can be made:
JsonSchemaResolver can be refactored to have the following signature:
def __init__(schemas: Mapping[str, any], refs: Mapping[str, any])
# schemas are all json files in `schemas/`, refs are all json files in `schemas/shared/`
Then we can thoroughly test the resolving behavior in JsonSchemaResolver independently from the logic for where we actually load schemas from.
I was tempted to make this refactor now but I'd rather cover more ground with tests then revisit. I created an issue to track this: #3222
* Adding concepts docs, structure for CDK documentation
* Add more context to the CDK README
Co-authored-by: Abhi Vaidyanatha <abhivaidyanatha@Abhis-MacBook-Pro.local>
Allow us to publish CDK versions on PyPi via Github workflows.
This lets us:
- Version CDK moving forward
- Publish via Github actions to both PyPi and test PyPi for test releases.
Note, this will not work on this branch as Github only detects new workflows after they are checked into master, so I was forced to develop and test this from a fork. Browse this PR or this PR to see this command in action.
Added publishing instructions to the Release Document.