1
0
mirror of synced 2026-01-04 00:04:25 -05:00
Commit Graph

196 Commits

Author SHA1 Message Date
Benoit Moriceau
651988de52 remove sleep and repeat test to check non flakyness (#19454)
* remove sleep and repeat test to check non flakyness

* Remove repeated test
2022-11-15 16:12:28 -08:00
Benoit Moriceau
b3db914265 Change where a connection is deleted (#19096)
* Tmp

* Move when the deletion is performed

* Re-enable disable test

* PR comments

* Use cancel

* rename

* Fix test and version check position

* Log exception
2022-11-09 13:05:27 -08:00
Benoit Moriceau
b92c961499 Disable flaky test (#18932) 2022-11-03 12:01:38 -07:00
Jonathan Pearlin
657f997aae Update to latest Temporal SDK release (#18492) 2022-10-26 12:54:00 -04:00
Benoit Moriceau
434a556dd8 Fix the tag in openAPI (#18445)
* Fix the tag

* remove unused
2022-10-25 14:23:47 -07:00
Jimmy Ma
f71fe5ac15 Add message translation to GetSpec (#18130)
* Update SpecActivityImpl to build a VersionedStreamFactory

* Enable Protocol Version detection from Stream for SPEC

* Print log before the action for better debugging

* Fix buffer size for protocol detection

* Improve detectVersion error handling

* extract constan

* Rename attribute for clarity
2022-10-21 10:27:34 -07:00
Benoit Moriceau
adf2c5ff8e Bmoric/remove dep connector worker (#17977)
* test [ci skip]

* Autogenerated files

* Add missing annotation

* Remove unused json2Schema block from worker

* Move tess

* Missing deps and format

* Fix test build

* TMP

* Add missing dependencies

* PR comments

* Tmp

* [ci skip] Tmp

* Fix acceptance test and add the seed dependency

* Fix build

* For diff

* tmp

* Build pass

* make the worker to be  on the platform only

* fix setting.yaml

* remove dependency

* Fix pmd

* Fix Cron

* Add chart

* Fix cron

* Fix server build.gradle

* Fix jar conflict

* PR comments

* Add cron micronaut environemnt

* Update required build path

* remove all dependencies on worker

* Typo

* Add gradle exclusions

* Add exclusion to avoid conflict

* more exclusion

* Move more class

* Exclude worker from the general build

* Fix connector build
2022-10-18 11:51:25 -07:00
Michael Siega
71967885e4 Implement webhook operation in the sync workflow (#18022)
Implements the webhook operation as part of the sync workflow.

- Introduces the new activity implementation
- Updates the various interfaces that pass input to get the relevant configs to the sync workflow
- Hooks the new activity into the sync workflow
- Passes the webhook configs along into the sync workflow job
2022-10-17 18:36:53 -07:00
Michael Siega
d8e9f512d6 Fix multiple breakages in the platform build (#18011)
* Revert "🎉 New Destination: bit.io (#15821)"

This reverts commit c05135b336.

* Fix broken acceptance tests
2022-10-14 22:23:43 +02:00
Jimmy Ma
f16b1eb3d3 Fix legacy reset behavior (#17270)
* Fix how we force an old version of a connector in the tests
* Fix endpoint behavior, State NOT_SET should be same as LEGACY
2022-09-27 11:48:16 -07:00
Benoit Moriceau
3c457e051d Bmoric/restore temporal cleaning cron (#17258)
* Revert "Revert "Bmoric/temporal cleaning cron (#16414)" (#17192)"

This reverts commit 751667949e.

* Generate an artifact

* Change missing property from value to property
2022-09-27 10:59:39 -07:00
Benoit Moriceau
751667949e Revert "Bmoric/temporal cleaning cron (#16414)" (#17192)
This reverts commit bbb59d8675.
2022-09-26 16:58:23 -07:00
Parker Mossman
e30476e4fd Remove default value from namespaceDefinitionType (#17177)
* remove default value from namespaceDefinitionType

* fix test

* switch some tests to use PATCH-style connection update

* add default logic to connection creation

Co-authored-by: Michael Siega <michael@airbyte.io>
2022-09-26 15:43:17 -07:00
Benoit Moriceau
bbb59d8675 Bmoric/temporal cleaning cron (#16414)
* WIP Convert airbyte-workers to Micronaut framework

* Rebase cleanup

* Fix broken tests

* Simplify code

* Support control vs data plane configuration

* make WORFKLOW_PROXY_CACHE non-static to avoid cacheing mocks in unit tests

* Formatting

* Pairing on Worker Micronaut (#16364)

* add RouteToSyncTaskQueue activity

* use new route activity in connection manager workflow

* format

* call router service for task queue

* Revert temporal proxy changes

* Formatting

* Fix default value

* register new route activity in test

* fix SyncWorkflowTest now that it isn't doing any routing

* Update dependencies

* More dependency updates

* Update dependencies

* WIP Convert airbyte-workers to Micronaut framework

* Rebase cleanup

* Fix broken tests

* Simplify code

* Support control vs data plane configuration

* make WORFKLOW_PROXY_CACHE non-static to avoid cacheing mocks in unit tests

* Formatting

* Pairing on Worker Micronaut (#16364)

* add RouteToSyncTaskQueue activity

* use new route activity in connection manager workflow

* format

* call router service for task queue

* Revert temporal proxy changes

* Formatting

* Fix default value

* register new route activity in test

* fix SyncWorkflowTest now that it isn't doing any routing

* Update dependencies

* More dependency updates

* Update dependencies

* WIP Convert airbyte-workers to Micronaut framework

* Rebase cleanup

* Fix broken tests

* Simplify code

* Support control vs data plane configuration

* make WORFKLOW_PROXY_CACHE non-static to avoid cacheing mocks in unit tests

* Formatting

* Pairing on Worker Micronaut (#16364)

* add RouteToSyncTaskQueue activity

* use new route activity in connection manager workflow

* format

* call router service for task queue

* Revert temporal proxy changes

* Formatting

* Fix default value

* register new route activity in test

* fix SyncWorkflowTest now that it isn't doing any routing

* Update dependencies

* More dependency updates

* Update dependencies

* Add the injected temporal client to airbyte-cron

* Update cron to make it work

* Remove useless Bean factory

* PR comments

* WIP Convert airbyte-workers to Micronaut framework

* Rebase cleanup

* Fix broken tests

* Simplify code

* Support control vs data plane configuration

* make WORFKLOW_PROXY_CACHE non-static to avoid cacheing mocks in unit tests

* Formatting

* Pairing on Worker Micronaut (#16364)

* add RouteToSyncTaskQueue activity

* use new route activity in connection manager workflow

* format

* call router service for task queue

* Revert temporal proxy changes

* Formatting

* Fix default value

* register new route activity in test

* fix SyncWorkflowTest now that it isn't doing any routing

* Update dependencies

* More dependency updates

* Update dependencies

* Improve conditional bean check

* Match existing Optional functionality

* Add notEquals check

* Add missing env var to Helm chart

* Fix typo

* Mark LogConfigs as Singleton

* WIP Convert airbyte-workers to Micronaut framework

* Rebase cleanup

* Fix broken tests

* Simplify code

* Support control vs data plane configuration

* make WORFKLOW_PROXY_CACHE non-static to avoid cacheing mocks in unit tests

* Formatting

* Pairing on Worker Micronaut (#16364)

* add RouteToSyncTaskQueue activity

* use new route activity in connection manager workflow

* format

* call router service for task queue

* Revert temporal proxy changes

* Formatting

* Fix default value

* register new route activity in test

* fix SyncWorkflowTest now that it isn't doing any routing

* Update dependencies

* More dependency updates

* Update dependencies

* Improve conditional bean check

* Match existing Optional functionality

* Add notEquals check

* Add missing env var to Helm chart

* Fix typo

* Mark LogConfigs as Singleton

* Env vars for log/state storage type

* Remove use of Optional in bean declarations

* Fix typo in config property name

* Support Temporal Cloud namespace

* Change to @Value

* Use correct value for conditional check

* Upgrade Micronaut

* Fix merge conflict

* Formatting

* Add missing env var

* Use sync task queue environment variable

* Handle sync task queue as set

* format and force http

* Handle case where sync task queue is empty

* Add correct path to config property

* Remove unused import

* Remove conflict

* Remove unused parameter

* Formatting

* Use pattern for condition process factory beans

* Cleanup

* PR feedback

* Revert hack for testing

* Fix temporal restart by status (#16447)

* Update application.yml

* Re add worker dep

* Add missing env var

* PR comments

* Bmoric/move temporal client (#16778)

* tmp

* tmp

* View diff

* Move part of the temporal client

* tmp

* copy Temporal Utils test

* Uniq Temporal Utils

* Uniq Temporal Workflow Utils

* Move CancellationHandler

* Move commons-temporal to being shared between platform, connector and CLI

* Rm worker dependency from cron

* Fix build

* Update with right value for cron.

* Fix dep conflict

Co-authored-by: jdpgrailsdev <jpearlin1@gmail.com>
Co-authored-by: pmossman <parker@airbyte.io>
Co-authored-by: Jonathan Pearlin <jonathan@airbyte.io>
2022-09-26 15:14:35 -07:00
Parker Mossman
1a0ea82c34 Change ConnectionUpdate to PATCH behavior (#16157)
* remove operationIds from WebBackendConnectionUpdate, just use operations

* refactor connection updates to patch-style update, where null fields remain unchanged

* better comment and arg name

* format

* make sure we are still 'dual-writing' to the old schedule column, even when the patch doesn't specify anything for it

* update acceptance test to update with new schedule syntax

* add catalog sorting to preserve stream order during patch, and more tests

* format

* add description, throw runtime exception for impossible branches, move streamReset to private helper

* PR suggestions

* add nested test classes and write a test for the catalog sorting method

* format

* add comment clarifying that the catalog sort is for UX, and isn't critical

* format

* format

* update acceptance tests to send proper catalog patches instead of whole new catalog

* format

* format

* simplify catalog patching - now, if a catalog is present on the request, replace the entire catalog with it.
Otherwise, if catalog on the request is null, leave the catalog unchanged

* format

* format

* Revert "update acceptance tests to send proper catalog patches instead of whole new catalog"

This reverts commit 71922648b4e070f46ff6c468813b7ab8dd9d6651.

* adjust description
2022-09-19 18:36:34 -05:00
Michael Siega
3dfe362406 update acceptance tests to use new connection scheduling format (#16167)
* update acceptance tests to use new scheduling format now that frontend has moved over

* readability improvements in sync schedule tests

* fix pmd issues in new acceptance test
2022-09-13 17:11:24 +02:00
Jimmy Ma
9ad847bd8e Store protocol version from spec (#16416)
* Update protocol version from actor defs API operations

* Implement default airbyte protocol version support

* Add version parsing

* Add acceptance tests

* Fix Acceptance Tests

* format

* Make test package private
2022-09-08 18:21:28 -07:00
Anne
d856731029 Implement more Error Prone PMD rules (#15491)
* AvoidFieldNameMatchingTypeName rule
* AvoidInstanceofChecksInCatchClause
* compareObjectsWithEquals
* DoNotTerminateVM and ConstructorCallsOverridableMethod
* EmptyIfStmt and EmptyStatementNotInLoop
* ImplicitSwitchFallThrough, InvalidLogMessageFormat, and MoreThanOneLogger
2022-09-07 13:20:32 -07:00
letiescanciano
a9a1b61ef4 fix: Remove Fullstory leftovers (#16223) 2022-09-02 14:36:13 +03:00
terencecho
7de1e522dd Update all acceptance tests with old postgres versions (#16120) 2022-08-29 23:09:54 -07:00
terencecho
d9089ed2ce Add is_test db config to test harness (#16117)
* Add is_test db config to test harness

* Add more comments
2022-08-29 16:41:27 -07:00
terencecho
d1f44cc0f5 Revert "Refactor test harness in preparation for cloud acceptance tests (#15932)"
This reverts commit dae056c552.
2022-08-29 14:25:02 -07:00
terencecho
dae056c552 Refactor test harness in preparation for cloud acceptance tests (#15932)
* Add is_test to dbConfig

* temp fix pmd just for testing

* remove strict-enforce postgres specifics

* cleanup spacing

* move common vars to test harness

* Add comment
2022-08-29 09:04:51 -07:00
Lake Mossman
874d02a948 🪟 🔧 Remove demo mode from UI (#15746)
* remove demo mode from UI

* remove merge conflict
2022-08-23 16:43:59 -07:00
Lake Mossman
377a1499cf Move 'updateNew' logic into 'update', and remove 'updateNew' (#15863)
* save

* clean up more usages and remove withRefreshedCatalog

* make webapp use correct endpoint

* add back intercept

* fix acceptance test

* fix log

* remove 'new' from test name
2022-08-23 11:36:48 -07:00
Ryan Fu
4572b75845 Moved getConnection into a try-with block and ran gradlew format (#15805) 2022-08-22 19:54:00 -07:00
Parker Mossman
a3a650111e declare id NOT NULL so that it can be used as a cursor for incremental syncs in tests (#15774) 2022-08-18 20:59:31 -07:00
Davin Chia
c1d9ff0c7c Fix Kube Acceptance Tests and properly close the created database. (#15587)
Bug fix from #14310 . The build was broken then from before #15497 so this was hidden.

- Add the new env vars to the integration test yamls.
- Also make sure to properly close the destination test container db.
2022-08-11 21:58:00 -07:00
Evan Tahler
fdb5eb9694 Simplify the MigrationAcceptanceTest (#15497)
* disable `testAutomaticMigration`

* empty commit to retry tests

* Simplify the MigrationAcceptanceTest

* lint

* Fix PMD. Reorder some calls to make clear what is happening.

Co-authored-by: Davin Chia <davinchia@gmail.com>
2022-08-10 09:03:02 -07:00
Evan Tahler
1ad5152dc0 Disable automaticMigrationAcceptanceTest (#15492)
* disable `testAutomaticMigration`

* empty commit to retry tests
2022-08-10 08:21:52 -07:00
Anne
e9afa9bef3 Error Prone PMD rules (#15010)
* Implement ErrorProne PMD rules:
AssignmentInOperand
AvoidAccessibilityAlteration
AvoidBranchingStatementAsLastInLoop
AvoidCatchingNPE
AvoidCatchingThrowable
AvoidDuplicateLiterals rule
2022-08-09 15:30:48 -07:00
Lake Mossman
4443aeb474 Set initial waiting seconds to 5 to speed up acceptance tests (#15411)
* set initial waiting seconds to 30 to speed up acceptance tests

* bump initial wait time to 120s

* set is_test to true and lower wait time to 5s
2022-08-08 13:01:45 -07:00
Edward Gao
a93ea5c95f fix acceptance tests with updated int type (#15078) 2022-07-27 10:30:46 -07:00
Anne
555efd5360 Best Practices PMD rules (#14904)
* Implement BestPractices PMD rules:
- LiteralsFirstInComparisons
- PreserveStackTrace
- SystemPrintln rule
- switch statement should have default
- Use isEmpty rule
- UseVarargs rule
2022-07-22 11:00:36 -07:00
terencecho
08fd5ee3ac Specify postgres destination creation in acceptance tests (#14749)
* remove ssl in config

* edit postgres destination and allow for strict-enforce db schema

* fix order of params

* Fix naming

* Update new tests
2022-07-21 17:20:17 -07:00
Ryan Fu
063b01f51c De-duplicate config parameters (#14781)
* Migrated 'ssl' string to become a constant in JdbcUtils

* Migrated 'database' string to become a constant in JdbcUtils

* Migrated 'username' string to become a constant in JdbcUtils

* Migrated 'password' string to become a constant in JdbcUtils

* Migrated 'schema' string to become a constant in JdbcUtils and updated corresponding config params

* Migrated 'jdbc_url' string to become a constant in JdbcUtils

* Migrated 'connection_properties' string to become a constant in JdbcUtils

* Migrated list of 'host_key' string to become a constant in JdbcUtils

* Migrated list of 'port_key' string to become a constant in JdbcUtils

* Migrated 'host_key' string to become a constant in JdbcUtils and updated corresponding config params

* Migrated 'port_key' string to become a constant in JdbcUtils

* Migrated 'tls' string to become a constant in JdbcUtils

* Migrated 'schemas' string to become a constant in JdbcUtils

* Migrated 'encryption' string to become a constant in JdbcUtils

* Migrated 'jdbc_url_params' string to become a constant in JdbcUtils and fixed uncaught parenthesis

* Fixed linter issues with comments on AcceptanceTest and failed import statement
2022-07-21 16:05:21 -07:00
Anne
76f9fbaa54 Apply more Best Practices PMD rules (#14772)
* implement PMD rules: 
* AbstractClassWithoutAbstractMethod
* ArrayIsStoredDirectly
* AvoidPrintStackTrace, AvoidReassigningLoopVariables, AvoidReassigningParameters, AvoidUsingHardCodedIP and CheckResultSet
* DoubleBraceInitialization
* MissingOverride
* ForLoopCanBeForeach
*JUnitTest rules
2022-07-20 14:28:47 -07:00
Benoit Moriceau
243d2f0c85 Bmoric/add non cdc partial reset acceptance test (#14764)
* set per stream feature flag to true for testing

* add a second table to cdc acceptance tests

* add partial reset test

* format

* add partial reset cdc tests

* test incremental after partial reset

* remove dev image from acceptance test

* fix flag and add comment

* Revert "set per stream feature flag to true for testing"

This reverts commit 164d7da05990268b09e315eb88ff297d3a9f52f4.

* set USE_STREAM_CAPABLE_STATE flag to true in acceptance test script

* call new update endpoint

* use methods in test harness instead

* remove comment

* add env var to worker container

* format

* fix state check in basic acceptance test

* use test info for test name logging

* Re-add acceptance test

* Re-adda acceptance test

* Format

* Fix acceptance test

* Add log

* remove unwanted changes

Co-authored-by: lmossman <lake@airbyte.io>
2022-07-18 13:29:53 -07:00
Anne
730752f924 More specific PMD warning suppression (#14806) 2022-07-18 11:48:41 -07:00
Benoit Moriceau
6d81a75b40 Fix build (#14799) 2022-07-18 09:44:29 -07:00
Lake Mossman
6005a9a20e CDC partial reset acceptance test (#14551)
* set per stream feature flag to true for testing

* add a second table to cdc acceptance tests

* add partial reset test

* format

* add partial reset cdc tests

* test incremental after partial reset

* remove dev image from acceptance test

* fix flag and add comment

* Revert "set per stream feature flag to true for testing"

This reverts commit 164d7da05990268b09e315eb88ff297d3a9f52f4.

* set USE_STREAM_CAPABLE_STATE flag to true in acceptance test script

* call new update endpoint

* use methods in test harness instead

* remove comment

* format

* fix state check in basic acceptance test

* use test info for test name logging
2022-07-15 16:03:15 -07:00
Anne
e698710118 Apply Best Practices PMD rules (#14753)
* Apply Unused* Best Practices PMD rules
2022-07-15 15:01:04 -07:00
Jimmy Ma
5a7b3a5961 Move helper test functions to AirbyteAcceptanceTestHarness (#14656) 2022-07-14 11:16:45 -07:00
Jimmy Ma
d0649c993c Add legacy update test (#14432)
* Add acceptance test for legacy state when updating a connection with new streams.
2022-07-12 14:48:42 -07:00
Lake Mossman
5d4d8aded0 fix precision of timestamps in comparison (#14645) 2022-07-12 14:33:32 -07:00
Lake Mossman
f8092708bb CDC Acceptance Test (#14370)
* Use Debezium Postgres image for CDC tests

* Formatting

* add cdc acceptance tests

* make method public

* format

* add update destination definition version method

* wait for successful job

* add acceptance tests for incremental with old dest, and for delete + some refactoring

* format

* fix assignment of sourceDbConfig

* fix init

* remove logs

* increase timeout on deleteConnection test to prevent transient failures

* TEMPORARY add logs to help with debugging CI failures

* add -i to acceptance test for debugging

* add back destinationPsql start to see if it fixes the issue

* Revert "add -i to acceptance test for debugging"

This reverts commit 693a955041.

* Revert "TEMPORARY add logs to help with debugging CI failures"

This reverts commit a30efd2c54.

* fix timestamp comparison

Co-authored-by: jdpgrailsdev <jpearlin1@gmail.com>
2022-07-08 13:45:44 -07:00
Lake Mossman
e1c2ca234e remove CONTAINER_ORCHESTRATOR env var from acceptance tests as it is unnecessary (#14541) 2022-07-08 11:38:55 -07:00
Lake Mossman
d2ea57499d Run container orchestrator acceptance tests (#13699)
* Add CONTAINER_ORCHESTRATOR=true flag to kube acceptance tests

* Add CONTAINER_ORCHESTRATOR=true flag to GKE acceptance tests too

* fix downtime test

* fix the other orchestrator tests

* move container orchestrator acceptance tests to their own class
2022-07-08 09:27:01 -07:00
Lake Mossman
139e822968 Use single state aggregator when per-stream feature flag is off (#14507)
* use single state aggregator when per-stream feature flag is off

* make var final

* add acceptance test for multiple stream incremental sync
2022-07-07 13:01:28 -07:00
Jonathan Pearlin
6dadd1b4b8 Add acceptance tests for per-stream state updates (#14263)
* Add acceptance tests for per-stream state updates

* PR feedback

* Formatting

* More PR feedback

* PR feedback

* Remove unused constant
2022-06-30 15:03:45 -04:00