1
0
mirror of synced 2026-01-17 03:06:35 -05:00
Commit Graph

6 Commits

Author SHA1 Message Date
Davin Chia
d95c06d357 Remove unused imports. (#20938) 2022-12-30 14:39:51 -08:00
Davin Chia
18593d91b5 Remove sneaky throws. (#20931)
The Java 19 toolchain doesn't like sneaky throws. Not entirely sure why. However, I think it's better practice to not use sneaky throws as it makes it clearer what is throw and where.

Example error message when trying to compile the current codebase with Java 19:

error: Error during the transformation of 'io.airbyte.validation.json.JsonSchemaValidatorTest'; post-compiler 'lombok.bytecode.SneakyThrowsRemover' caused an exception: java.lang.IllegalArgumentException: Unsupported class file major version 63
        at org.objectweb.asm.ClassReader.<init>(ClassReader.java:199)
        at org.objectweb.asm.ClassReader.<init>(ClassReader.java:180)
        at org.objectweb.asm.ClassReader.<init>(ClassReader.java:166)
        at lombok.bytecode.AsmUtil.fixJSRInlining(AsmUtil.java:37)
        at lombok.bytecode.SneakyThrowsRemover.applyTransformations(SneakyThrowsRemover.java:46)
        at lombok.core.PostCompiler.applyTransformations(PostCompiler.java:44)
        at lombok.core.PostCompiler$1.close(PostCompiler.java:87)
        at jdk.compiler/com.sun.tools.javac.jvm.ClassWriter.writeClass(ClassWriter.java:1508)
        at jdk.compiler/com.sun.tools.javac.main.JavaCompiler.genCode(JavaCompiler.java:738)
2022-12-30 09:04:26 -08:00
Jimmy Ma
f71fe5ac15 Add message translation to GetSpec (#18130)
* Update SpecActivityImpl to build a VersionedStreamFactory

* Enable Protocol Version detection from Stream for SPEC

* Print log before the action for better debugging

* Fix buffer size for protocol detection

* Improve detectVersion error handling

* extract constan

* Rename attribute for clarity
2022-10-21 10:27:34 -07:00
Jimmy Ma
f267746a18 Use MessageMigration for Source Connection Check. (#17656)
* More AirbyteVersion references fix

* Propagate protocol version from sourceDef to SchedulerClient

* Propagate protocol version to LauncherConfig

* Add VersionedMigratorFactory

* Update VersionedAirbyteStreamFactory

* Fix Version Json serialization/deserialization

* Plug message migration in CheckConnection for Sources
2022-10-13 08:11:31 -07:00
Jimmy Ma
5cd605d221 Prepare injection of Versioning compatible StreamReaderFactory (#17487)
* Use Version instead of AirbyteVersion

* Update Deserializer interface to fit better in existing flow

* Add versioned migrator

* Refactor DefaultAirbyteStreamFactory to enable Versioning

* Use explicit constructor

* Add logging on failed message upgrade
2022-10-03 12:38:26 -07:00
Jimmy Ma
42800f7b37 Add AirbyteProtocol Migration and SerDe framework (#17114)
* Introduce AirbyteProtocol Migration and SerDe framework

* Update serde

* Add demo migration test

* Enable Micronaut

* Do not expose internals

* Naming consistency

* More reordering and visibility fixes

* Use jakarta instead of javax

* Rename Old->Previous New->Current

* Add comments

* Lombok.@Getter
2022-09-28 15:08:28 -07:00