1
0
mirror of synced 2026-01-05 03:04:38 -05:00
Commit Graph

14 Commits

Author SHA1 Message Date
terencecho
5e1ee8c397 Fix customer.io template ordering for auto-disable notifications (#13505) 2022-06-06 18:05:07 -04:00
Davin Chia
7788594e22 Start publishing proper artifacts. (#13484)
## What
Finale of https://github.com/airbytehq/airbyte/pull/13122.

We've renamed all directories in previous PRs. Here we remove the fat jar configuration and add publishing to all subprojects.

Explanation for what is happening:

Identically named subprojects have the following issues:
* publishing as is leads to classpath confusion when the jars with the same names are placed in the Java distribution. This leads to NoClassDefFound errors on runtime.
* deconflicting the jar names without changing directory names leads to dependency errors as the OSS jar pom files are generated using project dependencies (suggesting a dependency a sibling subproject in the same repo) that use subprojects group and name as a reference. This means the generated jars look for Jars that do not exists (as their names have been changed) and cannot compile.
* the workaround to changing a subproject's name involves resetting the subproject's name in the settings.gradle and depending on the new name in each build.gradle. This increases configuration burden and decreases the ease of reading, since one will have to check the settings.gradle to know what the right subproject name is. See https://github.com/gradle/gradle/issues/847 for more info.
* given that Gradle itself doesn't have support for identically named subprojects (see the linked issue), the simplest solution is to not allow duplicated directories. I've only renamed conflicting directories here to keep things simple. I will create a follow up issues to enforce non-identical subproject names in our builds.

## How
* Remove fat jar configuration.
* Add publishing to all subprojects.
2022-06-06 17:15:25 +08:00
Davin Chia
eb99f47746 Fat Jar: Rename Dir Part 2 (#13478)
## What
Part 2 of https://github.com/airbytehq/airbyte/pull/13122.

Follow up to #13476 .

Explanation for what is happening:

Identically named subprojects have the following issues:

* publishing as is leads to classpath confusion when the jars with the same names are placed in the Java distribution. This leads to NoClassDefFound errors on runtime.
* deconflicting the jar names without changing directory names leads to dependency errors as the OSS jar pom files are generated using project dependencies (suggesting a dependency a sibling subproject in the same repo) that use subprojects group and name as a reference. This means the generated jars look for Jars that do not exists (as their names have been changed) and cannot compile.
* the workaround to changing a subproject's name involves resetting the subproject's name in the settings.gradle and depending on the new name in each build.gradle. This increases configuration burden and decreases the ease of reading, since one will have to check the settings.gradle to know what the right subproject name is. See https://github.com/gradle/gradle/issues/847 for more info.
* given that Gradle itself doesn't have support for identically named subprojects (see the linked issue), the simplest solution is to not allow duplicated directories. I've only renamed conflicting directories here to keep things simple. I will create a follow up issues to enforce non-identical subproject names in our builds.

* Rename airbyte-config:models to airbyte-config:config-models.
* Rename airbyte-config:persistence to airbyte-config:config-persistence.
2022-06-06 02:21:54 +08:00
Alexandre Girard
3894134d11 Bump year in license short to 2022 (#13191)
* Bump to 2022

* format
2022-05-25 17:56:49 -07:00
terencecho
4ff17abcd5 Use different CustomerIO templates and edit slack notifs (#12674)
* Use different CustomerIO templates and edit slack notifs

* fix unit test

* fix file naming and comments
2022-05-09 10:28:49 -04:00
terencecho
126ca5e7d7 Clean up auto-disabled connections notification messaging and allow for slack notifications (#12154)
* Add slack notifications for auto-disable connections

* fix formatting

* Edit notification messaging and allow slack notifs

* fix unit test
2022-04-21 15:42:27 -07:00
terencecho
9619f280d4 Send Customer.io notifications and warnings for connections being auto-disabled (#11670)
* init commit to send notifications regarding connection auto-disabling

* remove debugging prints

* Add logic for warning about only failures for days

* cleanup comments

* remove deplicate code

* refactor activity to be more readable

* small cleanup

* Refactor JobNotifier

* fix formatting

* Save state of last warning

* Move last warning state to WorkflowInternalState

* Reduce spam by getting timestamp info instead of saving state

* edit tests

* Fix formatting

* cleanup checkIfWarningPreviouslySent

* fix formatting

* refactor for readability

* Add extra comments

* edit comments
2022-04-20 15:02:31 -07:00
terencecho
e0aa76d357 Create CustomerIO email notification client (#11220)
* Create CustomerIO email notification client

* remove unused docker yaml changes

* Remove unused comments

* Add unit test

* Rename to customerio specific notification client

* Rename email to customerio

* re-build
2022-03-31 08:01:46 -07:00
Charles
c1c8675366 Add readmes to all modules (#8893) 2022-03-13 14:45:36 -07:00
Charles
5fde59fdbd add spotbugs (#10522) 2022-03-11 12:05:17 -08:00
Charles
ba44f700b9 add final for params, local variables, and fields (#7084) 2021-10-15 16:41:04 -07:00
Michel Tricot
1773e41e47 Shorten our headers + adds contributors file (#6478) 2021-09-27 10:45:50 -07:00
Prasanna Ram Venkatachalam
1ff177deed 🎉 add ability to send success notifications on webhook (#5517) 2021-09-07 11:35:07 -07:00
Christophe Duong
03fdd65319 Job Failure Notification (#2706)
* Add webhook to workspace for notifications when sync fail
* API to test notifications webhook (#2809)
2021-04-09 21:56:22 +02:00