2360fe0502
## What Updates Airbyte's ingress documentation to acknowledge that ingress support exists in both Helm chart V1 and V2, while maintaining focus on the recommended V2 approach. This addresses the discovery that PR #17752 added unified ingress support to Helm V1 charts, making previous "V2 only" statements inaccurate. Related to on-call issue #9393 and feature PRs #17787 (V2 ingress) and #17752 (V1 ingress). ## How - **Removed "V2 only" language** from ingress documentation sections - **Added notes for V1 users** directing them to the [values.yaml reference](/platform/deploying-airbyte/values) page for V1-specific ingress configuration structure - **Maintained V2 as primary focus** with comprehensive configuration examples and guidance - **Updated helm chart comparison table** to show ingress availability in both versions - **Restructured documentation** to clearly separate "Helm chart ingress" vs "manual ingress" options - **Combined and simplified examples** to focus on required backend services (server + connector-builder-server) ## Review guide 1. **docs/platform/deploying-airbyte/integrations/ingress.md** - Main ingress documentation restructuring - Verify the V1 note and values.yaml link accuracy - Check that V2 examples are technically correct (backend field usage) - Ensure the two-option structure (Helm chart vs manual) is clear 2. **docs/platform/enterprise-setup/implementation-guide.md** - Enterprise ingress documentation - Verify enterprise-specific configuration (keycloak backend) - Check V1 reference note consistency with main docs - Ensure switching instructions are clear 3. **docusaurus/static/_helm-chart-2-syntax-changes.md** - Helm comparison table update - Verify ingress entry accurately represents V1 vs V2 differences - Check link to ingress documentation works ## User Impact - **Helm V1 users** now have clear guidance that ingress is available (previously told it was V2-only) - **Helm V2 users** get improved, comprehensive ingress configuration guidance - **All users** benefit from clearer separation between Helm-managed vs manual ingress approaches - **Documentation accuracy** improved to reflect actual product capabilities ## Can this PR be safely reverted and rolled back? - [x] YES 💚 This is documentation-only changes with no code modifications. Revert would restore previous "V2 only" statements but wouldn't break functionality. --- **Link to Devin run**: https://app.devin.ai/sessions/5f4a71d6776d486aa4ec93eec89bd643 **Requested by**: ian.alton@airbyte.io --------- Co-authored-by: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com> Co-authored-by: ian.alton@airbyte.io <ian.alton@airbyte.io>
4.0 KiB
4.0 KiB
| Helm chart V1 | Helm chart V2 |
|---|---|
| Not available (manual ingress only) | ingress - See Ingress |
global.database.database |
global.database.name |
workload-launcher |
workloadLauncher |
airbyte-bootloader |
airbyteBootloader |
orchestrator |
containerOrchestrator |
workload-launcher.extraEnvs[JOB_KUBE_NODE_SELECTORS] |
global.jobs.kube.nodeSelector |
workload-launcher.extraEnvs[CHECK_JOB_KUBE_NODE_SELECTORS] |
global.jobs.kube.scheduling.check.nodeSelectors |
workload-launcher.extraEnvs[DISCOVER_JOB_KUBE_NODE_SELECTORS] |
global.jobs.kube.scheduling.discover.nodeSelectors |
worker.extraEnvs[MAX_SYNC_WORKERS] |
worker.maxSyncWorkers |
worker.extraEnvs[MAX_CHECK_WORKERS] |
worker.maxCheckWorkers |
server.extraEnvs[HTTP_IDLE_TIMEOUT] |
server.httpIdleTimeout |
global.env_vars[TRACKING_STRATEGY] |
global.tracking.strategy |
server.env_vars[AUDIT_LOGGING_ENABLED] |
server.auditLoggingEnabled |
global.env_vars[STORAGE_BUCKET_AUDIT_LOGGING] |
global.storage.bucket.auditLogging |
global.env_vars[JOB_MAIN_CONTAINER_CPU_REQUEST] |
global.workloads.resources.mainContainer.cpu.request |
orchestrator.nodeSelector |
global.jobs.kube.nodeSelector |
Individual bucket env vars (S3_LOG_BUCKET, GCS_LOG_BUCKET, etc.) |
global.storage.bucket.log |
STORAGE_BUCKET_STATE |
global.storage.bucket.state |
STORAGE_BUCKET_WORKLOAD_OUTPUT |
global.storage.bucket.workloadOutput |
STORAGE_BUCKET_ACTIVITY_PAYLOAD |
global.storage.bucket.activityPayload |