Part 1 of #13122. Rename airbyte-db:lib to airbyte-db:db-lib. Rename airbyte-metrics:lib to airbyte-metrics:metrics-lib Rename airbyte-protocol:models to airbyte-protocol:protocol-models. Explanation for what is happening: Identically named subprojects have the following issues: - publishing as is leads to classpath confusion when the jars with the same names are placed in the Java distribution. This leads to NoClassDefFound errors on runtime. - deconflicting the jar names without changing directory names leads to dependency errors as the OSS jar pom files are generated using project dependencies (suggesting a dependency a sibling subproject in the same repo) that use subprojects group and name as a reference. This means the generated jars look for Jars that do not exists (as their names have been changed) and cannot compile. - the workaround to changing a subproject's name involves resetting the subproject's name in the settings.gradle and depending on the new name in each build.gradle. This increases configuration burden and decreases the ease of reading, since one will have to check the settings.gradle to know what the right subproject name is. See Projects with same name lead to unintended conflict resolution gradle/gradle#847 for more info. - given that Gradle itself doesn't have support for identically named subprojects (see the linked issue), the simplest solution is to not allow duplicated directories. I've only renamed conflicting directories here to keep things simple. I will create a follow up issues to enforce non-identical subproject names in our builds.
End-to-End Testing Source Cloud Variant
This is the Cloud variant of the E2E Test Source. It only allows the "continuous feed" mode a finite number of record messages. The two legacy modes ("infinite feed" and "exception after n") are excluded from cloud because 1) the catalog is not customized under those modes, and 2) the connector should not emit infinite records, which may result in high cost accidentally.
Local development
Building via Gradle
From the Airbyte repository root, run:
./gradlew :airbyte-integrations:connectors:source-e2e-test-cloud:build
Create credentials
No credential is needed for this connector.
Locally running the connector docker image
Build
Build the connector image via Gradle:
./gradlew :airbyte-integrations:connectors:source-e2e-test-cloud:airbyteDocker
When building via Gradle, the docker image name and tag, respectively, are the values of the io.airbyte.name and io.airbyte.version LABELs in
the Dockerfile.
Run
Then run any of the connector commands as follows:
docker run --rm airbyte/source-e2e-test-cloud:dev spec
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-e2e-test-cloud:dev check --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets airbyte/source-e2e-test-cloud:dev discover --config /secrets/config.json
docker run --rm -v $(pwd)/secrets:/secrets -v $(pwd)/integration_tests:/integration_tests airbyte/source-e2e-test-cloud:dev read --config /secrets/config.json --catalog /integration_tests/configured_catalog.json
Cloud variant
The cloud version of this connector only allows the CONTINUOUS FEED mode. When this mode is changed, please make sure that the cloud variant is updated and published accordingly as well.
Testing
We use JUnit for Java tests.
Unit and Integration Tests
Place unit tests under src/test/io/airbyte/integrations/sources/e2e-test.
Acceptance Tests
Airbyte has a standard test suite that all destination connectors must pass. See example(s) in
src/test-integration/java/io/airbyte/integrations/sources/e2e-test/.
Using gradle to run tests
All commands should be run from airbyte project root. To run unit tests:
./gradlew :airbyte-integrations:connectors:sources-e2e-test:unitTest
To run acceptance and custom integration tests:
./gradlew :airbyte-integrations:connectors:sources-e2e-test:integrationTest
Dependency Management
Publishing a new version of the connector
You've checked out the repo, implemented a million dollar feature, and you're ready to share your changes with the world. Now what?
- Make sure your changes are passing unit and integration tests.
- Bump the connector version in
Dockerfile-- just increment the value of theLABEL io.airbyte.versionappropriately (we use SemVer). - Create a Pull Request.
- Pat yourself on the back for being an awesome contributor.
- Someone from Airbyte will take a look at your PR and iterate with you to merge it into master.