eb99f47746
## What Part 2 of https://github.com/airbytehq/airbyte/pull/13122. Follow up to #13476 . Explanation for what is happening: Identically named subprojects have the following issues: * publishing as is leads to classpath confusion when the jars with the same names are placed in the Java distribution. This leads to NoClassDefFound errors on runtime. * deconflicting the jar names without changing directory names leads to dependency errors as the OSS jar pom files are generated using project dependencies (suggesting a dependency a sibling subproject in the same repo) that use subprojects group and name as a reference. This means the generated jars look for Jars that do not exists (as their names have been changed) and cannot compile. * the workaround to changing a subproject's name involves resetting the subproject's name in the settings.gradle and depending on the new name in each build.gradle. This increases configuration burden and decreases the ease of reading, since one will have to check the settings.gradle to know what the right subproject name is. See https://github.com/gradle/gradle/issues/847 for more info. * given that Gradle itself doesn't have support for identically named subprojects (see the linked issue), the simplest solution is to not allow duplicated directories. I've only renamed conflicting directories here to keep things simple. I will create a follow up issues to enforce non-identical subproject names in our builds. * Rename airbyte-config:models to airbyte-config:config-models. * Rename airbyte-config:persistence to airbyte-config:config-persistence.
25 lines
971 B
Bash
Executable File
25 lines
971 B
Bash
Executable File
#!/usr/bin/env bash
|
|
|
|
set -e
|
|
|
|
. tools/lib/lib.sh
|
|
|
|
assert_root
|
|
|
|
echo "Starting app..."
|
|
|
|
# todo (cgardens) - docker-compose 1.27.3 contained a bug that causes a failure if the volume path
|
|
# does not exist when the volume is created. It was fixed in 1.27.4. Github actions virtual envs,
|
|
# however, new ubuntu release upgraded to 1.27.3 on 09/24/20. Once github actions virtual envs
|
|
# upgrades to 1.27.4, we can stop manually making the directory.
|
|
mkdir -p /tmp/airbyte_local
|
|
|
|
# todo (airbyte-jenny), once kube tests are stable, this can potentially be reintegrated to there.
|
|
# it is separate for now because the kube tests are experiencing transient failures.
|
|
echo "Running config persistence integration tests..."
|
|
|
|
SUB_BUILD=PLATFORM USE_EXTERNAL_DEPLOYMENT=true \
|
|
SECRET_STORE_GCP_CREDENTIALS=${SECRET_STORE_GCP_CREDENTIALS} \
|
|
SECRET_STORE_GCP_PROJECT_ID=${SECRET_STORE_GCP_PROJECT_ID} \
|
|
./gradlew :airbyte-config:config-persistence:integrationTest --rerun-tasks --scan
|