1
0
mirror of synced 2025-12-20 10:32:35 -05:00
Files
airbyte/airbyte-integrations/connectors/source-github/source_github/source.py
Brian Lai 262018744a fix(source-github): Graceful error handling of invalid credentials when running all sync operations (#67584)
Fixes: https://github.com/airbytehq/airbyte-internal-issues/issues/14576

## What

We had a previous swarm issue that ended up being a customer
misconfiguration due to expired or invalid creds. That being said, the
error message was particularly unhelpful w/ a bunch of python stack
traces. This replace that with far more useful information:

```
{"type":"CONNECTION_STATUS","connectionStatus":{"status":"FAILED","message":"'Github credentials have expired or changed, please review your credentials and re-authenticate or renew your access token.'"}}
``` 

## How

The main thing to call out here is that we want to get in the habit of
using our dedicated `HttpClient` which gives us better error handling
and just default behavior as a whole instead of using the `requests`
library. Otherwise the rest is pretty straightforward

## Review guide

nah

## User Impact

none

## Can this PR be safely reverted and rolled back?

- [x] YES 💚
- [ ] NO 
2025-10-13 16:13:18 -07:00

314 lines
14 KiB
Python

#
# Copyright (c) 2023 Airbyte, Inc., all rights reserved.
#
import logging
from os import getenv
from typing import Any, List, Mapping, MutableMapping, Optional, Tuple
from urllib.parse import urlparse
from airbyte_cdk.models import FailureType
from airbyte_cdk.sources import AbstractSource
from airbyte_cdk.sources.streams import Stream
from airbyte_cdk.sources.streams.http.http_client import MessageRepresentationAirbyteTracedErrors
from airbyte_cdk.sources.streams.http.requests_native_auth import MultipleTokenAuthenticator
from airbyte_cdk.utils.traced_exception import AirbyteTracedException
from source_github.utils import MultipleTokenAuthenticatorWithRateLimiter
from . import constants
from .streams import (
Assignees,
Branches,
Collaborators,
Comments,
CommitCommentReactions,
CommitComments,
Commits,
ContributorActivity,
Deployments,
Events,
IssueCommentReactions,
IssueEvents,
IssueLabels,
IssueMilestones,
IssueReactions,
Issues,
IssueTimelineEvents,
Organizations,
ProjectCards,
ProjectColumns,
Projects,
ProjectsV2,
PullRequestCommentReactions,
PullRequestCommits,
PullRequests,
PullRequestStats,
Releases,
Repositories,
RepositoryStats,
ReviewComments,
Reviews,
Stargazers,
Tags,
TeamMembers,
TeamMemberships,
Teams,
Users,
WorkflowJobs,
WorkflowRuns,
Workflows,
)
from .utils import read_full_refresh
class SourceGithub(AbstractSource):
continue_sync_on_stream_failure = True
@staticmethod
def _get_org_repositories(
config: Mapping[str, Any], authenticator: MultipleTokenAuthenticator, is_check_connection: bool = False
) -> Tuple[List[str], List[str], Optional[str]]:
"""
Parse config/repositories and produce two lists: organizations, repositories.
Args:
config (dict): Dict representing connector's config
authenticator(MultipleTokenAuthenticator): authenticator object
"""
config_repositories = set(config.get("repositories"))
repositories = set()
organizations = set()
unchecked_repos = set()
unchecked_orgs = set()
pattern = None
for org_repos in config_repositories:
_, _, repos = org_repos.partition("/")
if "*" in repos:
unchecked_orgs.add(org_repos)
else:
unchecked_repos.add(org_repos)
if unchecked_orgs:
org_names = [org.split("/")[0] for org in unchecked_orgs]
pattern = "|".join([f"({org.replace('*', '.*')})" for org in unchecked_orgs])
stream = Repositories(authenticator=authenticator, organizations=org_names, api_url=config.get("api_url"), pattern=pattern)
stream.exit_on_rate_limit = True if is_check_connection else False
for record in read_full_refresh(stream):
repositories.add(record["full_name"])
organizations.add(record["organization"])
unchecked_repos = unchecked_repos - repositories
if unchecked_repos:
stream = RepositoryStats(
authenticator=authenticator,
repositories=list(unchecked_repos),
api_url=config.get("api_url"),
# This parameter is deprecated and in future will be used sane default, page_size: 10
page_size_for_large_streams=config.get("page_size_for_large_streams", constants.DEFAULT_PAGE_SIZE_FOR_LARGE_STREAM),
)
stream.exit_on_rate_limit = True if is_check_connection else False
for record in read_full_refresh(stream):
repositories.add(record["full_name"])
organization = record.get("organization", {}).get("login")
if organization:
organizations.add(organization)
return list(organizations), list(repositories), pattern
@staticmethod
def get_access_token(config: Mapping[str, Any]):
# Before we supported oauth, personal_access_token was called `access_token` and it lived at the
# config root. So we first check to make sure any backwards compatbility is handled.
if "access_token" in config:
return constants.PERSONAL_ACCESS_TOKEN_TITLE, config["access_token"]
credentials = config.get("credentials", {})
if "access_token" in credentials:
return constants.ACCESS_TOKEN_TITLE, credentials["access_token"]
if "personal_access_token" in credentials:
return constants.PERSONAL_ACCESS_TOKEN_TITLE, credentials["personal_access_token"]
raise Exception("Invalid config format")
def _get_authenticator(self, config: Mapping[str, Any]):
_, token = self.get_access_token(config)
tokens = [t.strip() for t in token.split(constants.TOKEN_SEPARATOR)]
return MultipleTokenAuthenticatorWithRateLimiter(tokens=tokens)
def _validate_and_transform_config(self, config: MutableMapping[str, Any]) -> MutableMapping[str, Any]:
config = self._ensure_default_values(config)
config = self._validate_repositories(config)
config = self._validate_branches(config)
return config
def _ensure_default_values(self, config: MutableMapping[str, Any]) -> MutableMapping[str, Any]:
config.setdefault("api_url", "https://api.github.com")
api_url_parsed = urlparse(config["api_url"])
if not api_url_parsed.scheme.startswith("http"):
message = "Please enter a full url for `API URL` field starting with `http`"
elif api_url_parsed.scheme == "http" and not self._is_http_allowed():
message = "HTTP connection is insecure and is not allowed in this environment. Please use `https` instead."
elif not api_url_parsed.netloc:
message = "Please provide a correct API URL."
else:
return config
raise AirbyteTracedException(message=message, failure_type=FailureType.config_error)
def _validate_repositories(self, config: MutableMapping[str, Any]) -> MutableMapping[str, Any]:
if config.get("repositories"):
pass
elif config.get("repository"):
config["repositories"] = set(filter(None, config["repository"].split(" ")))
return config
def _validate_branches(self, config: MutableMapping[str, Any]) -> MutableMapping[str, Any]:
if config.get("branches"):
pass
elif config.get("branch"):
config["branches"] = set(filter(None, config["branch"].split(" ")))
return config
@staticmethod
def _is_http_allowed() -> bool:
return getenv("DEPLOYMENT_MODE", "").upper() != "CLOUD"
def user_friendly_error_message(self, message: str) -> str:
user_message = ""
if "404 Client Error: Not Found for url: https://api.github.com/repos/" in message:
# 404 Client Error: Not Found for url: https://api.github.com/repos/airbytehq/airbyte3?per_page=100
full_repo_name = message.split("https://api.github.com/repos/")[1].split("?")[0]
user_message = f'Repo name: "{full_repo_name}" is unknown, "repository" config option should use existing full repo name <organization>/<repository>'
elif "404 Client Error: Not Found for url: https://api.github.com/orgs/" in message:
# 404 Client Error: Not Found for url: https://api.github.com/orgs/airbytehqBLA/repos?per_page=100
org_name = message.split("https://api.github.com/orgs/")[1].split("/")[0]
user_message = f'Organization name: "{org_name}" is unknown, "repository" config option should be updated. Please validate your repository config.'
elif "401 Client Error: Unauthorized for url" in message or ("Error: Unauthorized" in message and "401" in message):
# 401 Client Error: Unauthorized for url: https://api.github.com/orgs/datarootsio/repos?per_page=100&sort=updated&direction=desc
user_message = (
"Github credentials have expired or changed, please review your credentials and re-authenticate or renew your access token."
)
return user_message
def check_connection(self, logger: logging.Logger, config: Mapping[str, Any]) -> Tuple[bool, Any]:
config = self._validate_and_transform_config(config)
try:
authenticator = self._get_authenticator(config)
_, repositories, _ = self._get_org_repositories(config=config, authenticator=authenticator, is_check_connection=True)
if not repositories:
return (
False,
"Some of the provided repositories couldn't be found. Please verify if every entered repository has a valid name and it matches the following format: airbytehq/airbyte airbytehq/another-repo airbytehq/* airbytehq/airbyte.",
)
return True, None
except MessageRepresentationAirbyteTracedErrors as e:
user_message = self.user_friendly_error_message(e.message)
return False, user_message or e.message
except Exception as e:
message = repr(e)
user_message = self.user_friendly_error_message(message)
return False, user_message or message
def streams(self, config: Mapping[str, Any]) -> List[Stream]:
authenticator = self._get_authenticator(config)
config = self._validate_and_transform_config(config)
try:
organizations, repositories, pattern = self._get_org_repositories(config=config, authenticator=authenticator)
except Exception as e:
message = repr(e)
user_message = self.user_friendly_error_message(message)
if user_message:
raise AirbyteTracedException(
internal_message=message, message=user_message, failure_type=FailureType.config_error, exception=e
)
else:
raise e
if not any((organizations, repositories)):
user_message = (
"No streams available. Looks like your config for repositories or organizations is not valid."
" Please, check your permissions, names of repositories and organizations."
" Needed scopes: repo, read:org, read:repo_hook, read:user, read:discussion, workflow."
)
raise AirbyteTracedException(
internal_message="No streams available. Please check permissions",
message=user_message,
failure_type=FailureType.config_error,
)
# This parameter is deprecated and in future will be used sane default, page_size: 10
page_size = config.get("page_size_for_large_streams", constants.DEFAULT_PAGE_SIZE_FOR_LARGE_STREAM)
access_token_type, _ = self.get_access_token(config)
max_waiting_time = config.get("max_waiting_time", 10) * 60
organization_args = {
"authenticator": authenticator,
"organizations": organizations,
"api_url": config.get("api_url"),
"access_token_type": access_token_type,
"max_waiting_time": max_waiting_time,
}
start_date = config.get("start_date")
organization_args_with_start_date = {**organization_args, "start_date": start_date}
repository_args = {
"authenticator": authenticator,
"api_url": config.get("api_url"),
"repositories": repositories,
"page_size_for_large_streams": page_size,
"access_token_type": access_token_type,
"max_waiting_time": max_waiting_time,
}
repository_args_with_start_date = {**repository_args, "start_date": start_date}
pull_requests_stream = PullRequests(**repository_args_with_start_date)
projects_stream = Projects(**repository_args_with_start_date)
project_columns_stream = ProjectColumns(projects_stream, **repository_args_with_start_date)
teams_stream = Teams(**organization_args)
team_members_stream = TeamMembers(parent=teams_stream, **repository_args)
workflow_runs_stream = WorkflowRuns(**repository_args_with_start_date)
return [
IssueTimelineEvents(**repository_args),
Assignees(**repository_args),
Branches(**repository_args),
Collaborators(**repository_args),
Comments(**repository_args_with_start_date),
CommitCommentReactions(**repository_args_with_start_date),
CommitComments(**repository_args_with_start_date),
Commits(**repository_args_with_start_date, branches_to_pull=config.get("branches", [])),
ContributorActivity(**repository_args),
Deployments(**repository_args_with_start_date),
Events(**repository_args_with_start_date),
IssueCommentReactions(**repository_args_with_start_date),
IssueEvents(**repository_args_with_start_date),
IssueLabels(**repository_args),
IssueMilestones(**repository_args_with_start_date),
IssueReactions(**repository_args_with_start_date),
Issues(**repository_args_with_start_date),
Organizations(**organization_args),
ProjectCards(project_columns_stream, **repository_args_with_start_date),
project_columns_stream,
projects_stream,
PullRequestCommentReactions(**repository_args_with_start_date),
PullRequestCommits(parent=pull_requests_stream, **repository_args),
PullRequestStats(**repository_args_with_start_date),
ProjectsV2(**repository_args_with_start_date),
pull_requests_stream,
Releases(**repository_args_with_start_date),
Repositories(**organization_args_with_start_date, pattern=pattern),
ReviewComments(**repository_args_with_start_date),
Reviews(**repository_args_with_start_date),
Stargazers(**repository_args_with_start_date),
Tags(**repository_args),
teams_stream,
team_members_stream,
Users(**organization_args),
Workflows(**repository_args_with_start_date),
workflow_runs_stream,
WorkflowJobs(parent=workflow_runs_stream, **repository_args_with_start_date),
TeamMemberships(parent=team_members_stream, **repository_args),
]