1
0
mirror of synced 2026-02-02 07:01:59 -05:00
Files
airbyte/.github
Pedro S. Lopez c207a7f546 require extra review for breaking change messages (#31361)
<!--
Thanks for your contribution! 
Before you submit the pull request, 
I'd like to kindly remind you to take a moment and read through our guidelines
to ensure that your contribution aligns with the type of contributions our project accepts.
All the information you need can be found here:
   https://docs.airbyte.com/contributing-to-airbyte/

We truly appreciate your interest in contributing to Airbyte,
and we're excited to see what you have to offer! 

If you have any questions or need any assistance, feel free to reach out in #contributions Slack channel.
-->

## What

We want to add Kat as a required reviewer when breaking change releases are made. This adds some logic to our existing checks to do so.

This also sets `request-reviewers: true` on our action so reviews are automatically requested when required.

Close https://github.com/airbytehq/airbyte/issues/31141

## How

- Created new group, `breaking-change-reviewers` of which Kat is the only member currently to make a bit more flexible if we do want to change who gets notified or add more people.
- Refactor mandatory reviewer logic to support multiple required review groups at a time, rather than just requesting the first group.
- Add a method to get diff from connector metadata, + refactor the current method to get acceptance test config changes to use a common method.
    - Since it's not just acceptance test config changes that cause required reviewers, also moved out some code from `acceptance_test_config_checks` to `required-reviewer_checks`
2023-10-16 16:32:41 -07:00
..
2023-10-13 09:22:37 +02:00