3.3 KiB
3.3 KiB
What
Describe what the change is solving It helps to add screenshots if it affects the frontend.
How
Describe the solution
Recommended reading order
x.javay.python
Pre-merge Checklist
Expand the checklist which is relevant for this PR.
Connector checklist
- Issue acceptance criteria met
- PR name follows PR naming conventions
- Secrets are annotated with
airbyte_secretin the connector's spec - Credentials added to Github CI if needed and not already present. instructions for injecting secrets into CI.
- Unit & integration tests added as appropriate (and are passing)
- Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run
./gradlew :airbyte-integrations:connectors:<name>:integrationTest.
- Community members: please provide proof of this succeeding locally e.g: screenshot or copy-paste acceptance test output. To run acceptance tests for a Python connector, follow instructions in the README. For java connectors run
/test connector=connectors/<name>command as documented here is passing.- Community members can skip this, Airbyters will run this for you.
- Code reviews completed
- Documentation updated
README.mddocs/SUMMARY.mdif it's a new connector- Created or updated reference docs in
docs/integrations/<source or destination>/<name>. - Changelog in the appropriate page in
docs/integrations/.... See changelog example docs/integrations/README.mdcontains a reference to the new connector- Build status added to build page
- Build is successful
- Connector version bumped like described here
- New Connector version released on Dockerhub by running the
/publishcommand described here - No major blockers
- PR merged into master branch
- Follow up tickets have been created
- Associated tickets have been closed & stakeholders notified
Connector Generator checklist
- Issue acceptance criteria met
- PR name follows PR naming conventions
- If adding a new generator, add it to the list of scaffold modules being tested
- The generator test modules (all connectors with
-scaffoldin their name) have been updated with the latest scaffold by running./gradlew :airbyte-integrations:connector-templates:generator:testScaffoldTemplatesthen checking in your changes - Documentation which references the generator is updated as needed.