jprdonnelly/core
1
0
Fork 0
mirror of synced 2025-12-19 18:06:02 -05:00
Code Issues Projects Releases Wiki Activity

Merge pull request #8267 from buyaa-n/known-issue

Browse Source 
Add CA2009 regression into the known issues
This commit is contained in:
Buyaa Namnan
2023-03-19 19:27:44 -07:00
committed by GitHub
parent 491a02f671 c05643df6d
commit e8ec8f70f9
1 changed files with 28 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
release-notes/8.0/known-issues.md
View File

@@ -4,6 +4,34 @@ You may encounter the following known issues, which may include workarounds, mit
## .NET SDK
### [8.0.100-preview.1.23115.2] analyzer CA2009 throws InvalidCastException at runtime could cause a build failure
[CA2009](https://learn.microsoft.com/EN-US/dotnet/fundamentals/code-analysis/quality-rules/ca2009): `Do not call ToImmutableCollection on an ImmutableCollection value` analyzer regressed in .NET 8 preview 1, the regression could cause a build failure if:
- CA2009 severity is set at `warning` level: `dotnet_diagnostic.CA2009.severity = warning` (by default it is `suggestion`)
- And the AD0001 is at `warning` level (by default it is `warning`)
- And the .NET 8 preview 1 SDK is being used for build
- And the project warns as error `<TreatWarningsAsErrors>true</TreatWarningsAsErrors>`
- And the projects have a code section that calls `ToImmutableArray()` on an array instance, for example:
```cs
public ImmutableArray<int> Method(int [] arr)
{
return arr.ToImmutableArray();
}
```
Then the build would fail with an error:
```log
error AD0001: Analyzer 'Microsoft.NetCore.Analyzers.ImmutableCollections.DoNotCallToImmutableCollectionOnAnImmutableCollectionValueAnalyzer' threw an exception of type 'System.InvalidCastException' with message 'Unable to cast object of type 'Microsoft.CodeAnalysis.CSharp.Symbols.PublicModel.ArrayTypeSymbol' to type 'Microsoft.CodeAnalysis.INamedTypeSymbol'.
```
**Resolution**
- The regression is [fixed](https://github.com/dotnet/roslyn-analyzers/pull/6476) in .NET 8 preview 2. Could upgrade into .NET 8 preview 2 or above
- Lower the CA2009 analyzer severoty to `suggestion` or `none` : `dotnet_diagnostic.CA2009.severity = none`
- Lower the AD0001 diagnostic severoty to `suggestion` or `none` : `dotnet_diagnostic.CA2009.severity = suggestion`
## .NET MAUI
For details about known issues, please refer to the individual repositories: