mirror of
https://github.com/langgenius/dify.git
synced 2026-02-12 22:01:20 -05:00
573e099f6c
- Build signin URL with redirect param so users return to their original page after re-authentication - Replace naive refresh lock with token-based ownership to prevent cross-tab lock release conflicts - Add stale lock detection with max age to avoid deadlocks from crashed tabs - Add timeout to waitUntilTokenRefreshed to prevent infinite polling - Add tests for signin redirect URL building and refresh token logic
87 lines
2.9 KiB
TypeScript
87 lines
2.9 KiB
TypeScript
import { beforeEach, describe, expect, it, vi } from 'vitest'
|
|
import { refreshAccessTokenOrReLogin } from './refresh-token'
|
|
|
|
const mockFetchWithRetry = vi.fn()
|
|
|
|
vi.mock('@/utils', () => ({
|
|
fetchWithRetry: (...args: unknown[]) => mockFetchWithRetry(...args),
|
|
}))
|
|
|
|
function createDeferred<T>() {
|
|
let resolve!: (value: T) => void
|
|
let reject!: (reason?: unknown) => void
|
|
const promise = new Promise<T>((res, rej) => {
|
|
resolve = res
|
|
reject = rej
|
|
})
|
|
|
|
return { promise, resolve, reject }
|
|
}
|
|
|
|
describe('refreshAccessTokenOrReLogin', () => {
|
|
beforeEach(() => {
|
|
vi.clearAllMocks()
|
|
vi.useRealTimers()
|
|
localStorage.clear()
|
|
globalThis.fetch = vi.fn()
|
|
})
|
|
|
|
describe('stale cross-tab lock handling', () => {
|
|
it('should clean stale lock and execute refresh request', async () => {
|
|
// Arrange
|
|
localStorage.setItem('is_other_tab_refreshing', '1')
|
|
localStorage.setItem('last_refresh_time', `${Date.now() - 30_000}`)
|
|
mockFetchWithRetry.mockResolvedValue([null, new Response(null, { status: 200 })])
|
|
|
|
// Act
|
|
await refreshAccessTokenOrReLogin(5_000)
|
|
|
|
// Assert
|
|
expect(mockFetchWithRetry).toHaveBeenCalledTimes(1)
|
|
expect(localStorage.getItem('is_other_tab_refreshing')).toBeNull()
|
|
expect(localStorage.getItem('last_refresh_time')).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe('concurrent refresh requests', () => {
|
|
it('should avoid duplicate refresh calls when a refresh is already in progress', async () => {
|
|
// Arrange
|
|
const deferredRefresh = createDeferred<[null, Response]>()
|
|
mockFetchWithRetry.mockImplementation(() => deferredRefresh.promise)
|
|
|
|
// Act
|
|
const firstRefresh = refreshAccessTokenOrReLogin(5_000)
|
|
const secondRefresh = refreshAccessTokenOrReLogin(5_000)
|
|
deferredRefresh.resolve([null, new Response(null, { status: 200 })])
|
|
|
|
// Assert
|
|
await expect(firstRefresh).resolves.toBeUndefined()
|
|
await expect(secondRefresh).resolves.toBeUndefined()
|
|
expect(mockFetchWithRetry).toHaveBeenCalledTimes(1)
|
|
expect(localStorage.getItem('is_other_tab_refreshing')).toBeNull()
|
|
expect(localStorage.getItem('last_refresh_time')).toBeNull()
|
|
})
|
|
})
|
|
|
|
describe('waiter behavior', () => {
|
|
it('should wait for another tab lock to release without issuing duplicate refresh', async () => {
|
|
// Arrange
|
|
vi.useFakeTimers()
|
|
localStorage.setItem('is_other_tab_refreshing', 'other-tab-token')
|
|
localStorage.setItem('last_refresh_time', `${Date.now()}`)
|
|
|
|
// Act
|
|
const waitingRefresh = refreshAccessTokenOrReLogin(5_000)
|
|
setTimeout(() => {
|
|
localStorage.removeItem('is_other_tab_refreshing')
|
|
localStorage.removeItem('last_refresh_time')
|
|
}, 300)
|
|
await vi.advanceTimersByTimeAsync(1_000)
|
|
|
|
// Assert
|
|
await expect(waitingRefresh).resolves.toBeUndefined()
|
|
expect(mockFetchWithRetry).not.toHaveBeenCalled()
|
|
})
|
|
})
|
|
})
|