From fc0f3bb727c40586c698c7df8990bcbcc38a7c42 Mon Sep 17 00:00:00 2001 From: M Hickford Date: Wed, 28 Sep 2022 18:42:54 +0100 Subject: [PATCH 1/4] Recommend to use 127.0.0.1 instead of localhost --- .../apps/building-oauth-apps/authorizing-oauth-apps.md | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/content/developers/apps/building-oauth-apps/authorizing-oauth-apps.md b/content/developers/apps/building-oauth-apps/authorizing-oauth-apps.md index 16619daebe..b8a761b4c5 100644 --- a/content/developers/apps/building-oauth-apps/authorizing-oauth-apps.md +++ b/content/developers/apps/building-oauth-apps/authorizing-oauth-apps.md @@ -297,9 +297,9 @@ subdirectory of the callback URL. BAD: http://oauth.example.com:8080/path BAD: http://example.org -### Localhost redirect urls +### Loopback redirect urls -The optional `redirect_uri` parameter can also be used for localhost URLs. If the application specifies a localhost URL and a port, then after authorizing the application users will be redirected to the provided URL and port. The `redirect_uri` does not need to match the port specified in the callback url for the app. +The optional `redirect_uri` parameter can also be used for loopback URLs. If the application specifies a loopback URL and a port, then after authorizing the application users will be redirected to the provided URL and port. The `redirect_uri` does not need to match the port specified in the callback url for the app. For the `http://127.0.0.1/path` callback URL, you can use this `redirect_uri`: @@ -307,6 +307,8 @@ For the `http://127.0.0.1/path` callback URL, you can use this `redirect_uri`: http://127.0.0.1:1234/path ``` +Note that OAuth RFC [recommends not to use `localhost`](https://datatracker.ietf.org/doc/html/rfc8252#section-7.3), but instead to use loopback literal `127.0.0.1` or IPv6 `::1`. + ## Creating multiple tokens for OAuth Apps You can create multiple tokens for a user/application/scope combination to create tokens for specific use cases. From ac272a10ccb26eb2266c06ad1367fa6786f39863 Mon Sep 17 00:00:00 2001 From: Riadh Laabidi Date: Mon, 10 Oct 2022 14:09:12 +0000 Subject: [PATCH 2/4] Update workflow-commands-for-github-actions.md --- .../using-workflows/workflow-commands-for-github-actions.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/content/actions/using-workflows/workflow-commands-for-github-actions.md b/content/actions/using-workflows/workflow-commands-for-github-actions.md index 34308f8f03..ee7af52a45 100644 --- a/content/actions/using-workflows/workflow-commands-for-github-actions.md +++ b/content/actions/using-workflows/workflow-commands-for-github-actions.md @@ -131,6 +131,8 @@ Sets an action's output parameter. Optionally, you can also declare output parameters in an action's metadata file. For more information, see "[Metadata syntax for {% data variables.product.prodname_actions %}](/articles/metadata-syntax-for-github-actions#outputs-for-docker-container-and-javascript-actions)." +You can escape multiline strings for setting an output parameter by creating an environment variable, and then use it in a workflow command. For more information, see "[Setting an environment variable](#setting-an-environment-variable)." + ### Example: Setting an output parameter {% bash %} From 92376dd3f88a96d813958ed68f389e8fcd00a326 Mon Sep 17 00:00:00 2001 From: Rachael Rose Renk Date: Wed, 12 Oct 2022 14:21:09 -0600 Subject: [PATCH 3/4] Update workflow-commands-for-github-actions.md --- .../using-workflows/workflow-commands-for-github-actions.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/actions/using-workflows/workflow-commands-for-github-actions.md b/content/actions/using-workflows/workflow-commands-for-github-actions.md index a93be665b5..60e836a70a 100644 --- a/content/actions/using-workflows/workflow-commands-for-github-actions.md +++ b/content/actions/using-workflows/workflow-commands-for-github-actions.md @@ -169,7 +169,7 @@ Sets an action's output parameter. Optionally, you can also declare output parameters in an action's metadata file. For more information, see "[Metadata syntax for {% data variables.product.prodname_actions %}](/articles/metadata-syntax-for-github-actions#outputs-for-docker-container-and-javascript-actions)." -You can escape multiline strings for setting an output parameter by creating an environment variable, and then use it in a workflow command. For more information, see "[Setting an environment variable](#setting-an-environment-variable)." +You can escape multiline strings for setting an output parameter by creating an environment variable and using it in a workflow command. For more information, see "[Setting an environment variable](#setting-an-environment-variable)." ### Example: Setting an output parameter From 9054d9ea7049751474e2d30f8ee47b7a94356bf7 Mon Sep 17 00:00:00 2001 From: Rachael Rose Renk Date: Wed, 12 Oct 2022 14:47:36 -0600 Subject: [PATCH 4/4] Update authorizing-oauth-apps.md --- .../apps/building-oauth-apps/authorizing-oauth-apps.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/developers/apps/building-oauth-apps/authorizing-oauth-apps.md b/content/developers/apps/building-oauth-apps/authorizing-oauth-apps.md index b8a761b4c5..30741ef7ac 100644 --- a/content/developers/apps/building-oauth-apps/authorizing-oauth-apps.md +++ b/content/developers/apps/building-oauth-apps/authorizing-oauth-apps.md @@ -299,7 +299,7 @@ subdirectory of the callback URL. ### Loopback redirect urls -The optional `redirect_uri` parameter can also be used for loopback URLs. If the application specifies a loopback URL and a port, then after authorizing the application users will be redirected to the provided URL and port. The `redirect_uri` does not need to match the port specified in the callback url for the app. +The optional `redirect_uri` parameter can also be used for loopback URLs. If the application specifies a loopback URL and a port, then after authorizing the application users will be redirected to the provided URL and port. The `redirect_uri` does not need to match the port specified in the callback URL for the app. For the `http://127.0.0.1/path` callback URL, you can use this `redirect_uri`: