don't htmlencode 'title' (#33920)

components/context/ArticleContext.tsx

@@ -62,7 +62,7 @@ export const getArticleContextFromRequest = (req: any): ArticleContextT => {
   }
 
   return {
-    title: page.titlePlainText,
+    title: page.title,
     intro: page.intro,
     effectiveDate: page.effectiveDate || '',
     renderedPage: req.context.renderedPage || '',

components/context/AutomatedPageContext.tsx

@@ -28,7 +28,7 @@ export const getAutomatedPageContextFromRequest = (req: any): AutomatedPageConte
   const page = req.context.page
 
   return {
-    title: page.titlePlainText,
+    title: page.title,
     intro: page.intro,
     renderedPage: req.context.renderedPage || '',
     miniTocItems: req.context.miniTocItems || [],

components/context/TocLandingContext.tsx

@@ -34,7 +34,7 @@ export const useTocLandingContext = (): TocLandingContextT => {
 
 export const getTocLandingContextFromRequest = (req: any): TocLandingContextT => {
   return {
-    title: req.context.page.titlePlainText,
+    title: req.context.page.title,
     productCallout: req.context.page.product || '',
     introPlainText: req.context.page.introPlainText,
     tocItems: (req.context.genericTocFlat || req.context.genericTocNested || []).map((obj: any) =>

lib/page.js

@@ -178,10 +178,6 @@ class Page {
     })
     this.title = await renderContentWithFallback(this, 'rawTitle', context, {
       textOnly: true,
-      encodeEntities: true,
-    })
-    this.titlePlainText = await renderContentWithFallback(this, 'rawTitle', context, {
-      textOnly: true,
     })
     this.shortTitle = await renderContentWithFallback(this, 'shortTitle', context, {
       textOnly: true,

middleware/render-page.js

@@ -81,7 +81,7 @@ export default async function renderPage(req, res) {
   if (isConnectionDropped(req, res)) return
 
   // Create string for <title> tag
-  page.fullTitle = page.titlePlainText
+  page.fullTitle = page.title
 
   // add localized ` - GitHub Docs` suffix to <title> tag (except for the homepage)
   if (!patterns.homepagePath.test(path)) {