From 20b78c8563dbbbbe15d964cff7b078a8d5316559 Mon Sep 17 00:00:00 2001 From: Joe Clark <31087804+jc-clark@users.noreply.github.com> Date: Wed, 9 Aug 2023 01:28:29 -0700 Subject: [PATCH] Actions bug fixes for the week of July 31, 2023 (#40371) Co-authored-by: Felicity Chapman --- .../adding-self-hosted-runners.md | 2 +- .../managing-larger-runners.md | 6 +++--- .../running-jobs-on-larger-runners.md | 6 +++--- .../using-conditions-to-control-job-execution.md | 8 ++------ .../using-workflows/events-that-trigger-workflows.md | 2 +- ...orkflows-secrets-and-runners-with-your-organization.md | 4 ++-- .../about-status-checks.md | 2 ++ .../actions/about-enterprise-level-runner-groups.md | 2 +- .../actions/about-organization-level-runner-groups.md | 2 +- data/reusables/actions/about-runner-groups.md | 4 ++-- .../workflows/skipped-job-status-checks-passing.md | 5 +++++ data/reusables/copilot/enabling-in-enterprise.md | 2 +- 12 files changed, 24 insertions(+), 21 deletions(-) create mode 100644 data/reusables/actions/workflows/skipped-job-status-checks-passing.md diff --git a/content/actions/hosting-your-own-runners/managing-self-hosted-runners/adding-self-hosted-runners.md b/content/actions/hosting-your-own-runners/managing-self-hosted-runners/adding-self-hosted-runners.md index 24c27d1362..d0b05e0559 100644 --- a/content/actions/hosting-your-own-runners/managing-self-hosted-runners/adding-self-hosted-runners.md +++ b/content/actions/hosting-your-own-runners/managing-self-hosted-runners/adding-self-hosted-runners.md @@ -88,7 +88,7 @@ For more information, see "[AUTOTITLE](/actions/hosting-your-own-runners/managin ## Adding a self-hosted runner to an enterprise -{% ifversion fpt %}If you use {% data variables.product.prodname_ghe_cloud %}, you{% elsif ghec or ghes or ghae %}You{% endif %} can add self-hosted runners to an enterprise, where they can be assigned to multiple organizations. The organization admins are then able to control which repositories can use it. {% ifversion fpt %}For more information, see the [{% data variables.product.prodname_ghe_cloud %} documentation](/enterprise-cloud@latest/actions/hosting-your-own-runners/managing-self-hosted-runners/adding-self-hosted-runners#adding-a-self-hosted-runner-to-an-enterprise).{% endif %} +{% ifversion fpt %}If you use {% data variables.product.prodname_ghe_cloud %}, you{% elsif ghec or ghes or ghae %}You{% endif %} can add self-hosted runners to an enterprise, where they can be assigned to multiple organizations. The organization owner can control which repositories can use it. {% ifversion fpt %}For more information, see the [{% data variables.product.prodname_ghe_cloud %} documentation](/enterprise-cloud@latest/actions/hosting-your-own-runners/managing-self-hosted-runners/adding-self-hosted-runners#adding-a-self-hosted-runner-to-an-enterprise).{% endif %} {% ifversion ghec or ghes or ghae %} New runners are assigned to the default group. You can modify the runner's group after you've registered the runner. For more information, see "[AUTOTITLE](/actions/hosting-your-own-runners/managing-self-hosted-runners/managing-access-to-self-hosted-runners-using-groups#moving-a-self-hosted-runner-to-a-group)." diff --git a/content/actions/using-github-hosted-runners/managing-larger-runners.md b/content/actions/using-github-hosted-runners/managing-larger-runners.md index 66b689f72e..90175a68c8 100644 --- a/content/actions/using-github-hosted-runners/managing-larger-runners.md +++ b/content/actions/using-github-hosted-runners/managing-larger-runners.md @@ -10,7 +10,7 @@ versions: {% ifversion ghec %} ## Adding a {% data variables.actions.hosted_runner %} to an enterprise -Enterprise owners can add {% data variables.actions.hosted_runner %}s to an enterprise and assign them to organizations. By default, when a {% data variables.actions.hosted_runner %} is created for an enterprise, it is added to a default runner group that all organizations in the enterprise have access to. While all organizations are granted access to the runner, the repositories in each organization **are not** granted access. For each organization, an organization administrator must configure the runner group to specify which repositories have access to the enterprise runner. For more information, see "[Allowing repositories to access a runner group](#allowing-repositories-to-access-a-runner-group)." +Enterprise owners can add {% data variables.actions.hosted_runner %}s to an enterprise and assign them to organizations. By default, when a {% data variables.actions.hosted_runner %} is created for an enterprise, it is added to a default runner group that all organizations in the enterprise have access to. While all organizations are granted access to the runner, the repositories in each organization **are not** granted access. For each organization, an organization owner must configure the runner group to specify which repositories have access to the enterprise runner. For more information, see "[Allowing repositories to access a runner group](#allowing-repositories-to-access-a-runner-group)." {% data reusables.actions.add-hosted-runner-overview %} @@ -25,7 +25,7 @@ Enterprise owners can add {% data variables.actions.hosted_runner %}s to an ente ## Adding a {% data variables.actions.hosted_runner %} to an organization -You can add a {% data variables.actions.hosted_runner %} to an organization, where organization administrators can control which repositories can use it. When you create a new runner for an organization, by default, all repositories in the organization have access to the runner. To limit which repositories can use the runner, assign it to a runner group with access to specific repositories. For more information, see "[Allowing repositories to access a runner group](#allowing-repositories-to-access-a-runner-group)." +You can add a {% data variables.actions.hosted_runner %} to an organization, where organization owners can control which repositories can use it. When you create a new runner for an organization, by default, all repositories in the organization have access to the runner. To limit which repositories can use the runner, assign it to a runner group with access to specific repositories. For more information, see "[Allowing repositories to access a runner group](#allowing-repositories-to-access-a-runner-group)." {% data reusables.actions.add-hosted-runner-overview %} @@ -37,7 +37,7 @@ You can add a {% data variables.actions.hosted_runner %} to an organization, whe ## Allowing repositories to access {% data variables.actions.hosted_runner %}s -Repositories are granted access to {% data variables.actions.hosted_runner %}s through runner groups. Enterprise administrators can choose which organizations are granted access to enterprise-level runner groups, and organization administrators control repository-level access to all {% data variables.actions.hosted_runner %}s. Organization administrators can use and configure enterprise-level runner groups for the repositories in their organization, or they can create organization-level runner groups to control access. +Repositories are granted access to {% data variables.actions.hosted_runner %}s through runner groups. Enterprise administrators can choose which organizations are granted access to enterprise-level runner groups, and organization owners control repository-level access to all {% data variables.actions.hosted_runner %}s. Organization owners can use and configure enterprise-level runner groups for the repositories in their organization, or they can create organization-level runner groups to control access. - **For enterprise-level runner groups**: {% data reusables.actions.about-enterprise-level-runner-groups %} - **For organization-level runner groups**: {% data reusables.actions.about-organization-level-runner-groups %} diff --git a/content/actions/using-github-hosted-runners/running-jobs-on-larger-runners.md b/content/actions/using-github-hosted-runners/running-jobs-on-larger-runners.md index 30e49e83b9..49f8bc8d66 100644 --- a/content/actions/using-github-hosted-runners/running-jobs-on-larger-runners.md +++ b/content/actions/using-github-hosted-runners/running-jobs-on-larger-runners.md @@ -17,7 +17,7 @@ Once your runner type has been defined, you can update your workflow YAML files {% endnote %} -Only owner or administrator accounts can see the runner settings. Non-administrative users can contact the organization administrator to find out which runners are enabled. Your organization administrator can create new runners and runner groups, as well as configure permissions to specify which repositories can access a runner group. For more information, see "[AUTOTITLE](/actions/using-github-hosted-runners/managing-larger-runners#allowing-repositories-to-access-a-runner-group)." +Only owner or administrator accounts can see the runner settings. Non-administrative users can contact the organization owner to find out which runners are enabled. Your organization owner can create new runners and runner groups, as well as configure permissions to specify which repositories can access a runner group. For more information, see "[AUTOTITLE](/actions/using-github-hosted-runners/managing-larger-runners#allowing-repositories-to-access-a-runner-group)." ## Using groups to control where jobs are run @@ -51,10 +51,10 @@ jobs: ## Troubleshooting {% data variables.actions.hosted_runner %}s -If you notice the jobs that target your {% data variables.actions.hosted_runner %}s are delayed or not running, there are several factors that may be causing this. +If you notice the jobs that target your {% data variables.actions.hosted_runner %}s are delayed or not running, there are several factors that may be causing this. - **Concurrency settings**: You may have reached your maximum concurrency limit. If you would like to enable more jobs to run in parallel, you can update your autoscaling settings to a larger number. For more information, see "[AUTOTITLE](/actions/using-github-hosted-runners/managing-larger-runners#configuring-autoscaling-for-larger-runners)." -- **Repository permissions**: Ensure you have the appropriate repository permissions enabled for your {% data variables.actions.hosted_runner %}s. By default, enterprise runners are not available at the repository level and must be manually enabled by an organization administrator. For more information, see "[AUTOTITLE](/actions/using-github-hosted-runners/managing-larger-runners#allowing-repositories-to-access-larger-runners)." +- **Repository permissions**: Ensure you have the appropriate repository permissions enabled for your {% data variables.actions.hosted_runner %}s. By default, enterprise runners are not available at the repository level and must be manually enabled by an organization owner. For more information, see "[AUTOTITLE](/actions/using-github-hosted-runners/managing-larger-runners#allowing-repositories-to-access-larger-runners)." - **Billing information**: You must have a valid credit card on file in order to use {% data variables.actions.hosted_runner %}s. After adding a credit card to your account, it can take up to 10 minutes to enable the use of your {% data variables.actions.hosted_runner %}s. For more information, see "[AUTOTITLE](/billing/managing-your-github-billing-settings/adding-or-editing-a-payment-method)." - **Spending limit**: Your {% data variables.product.prodname_actions %} spending limit must be set to a value greater than zero. For more information, see "[AUTOTITLE](/billing/managing-billing-for-github-actions/managing-your-spending-limit-for-github-actions)." - **Fair use policy**: {% data variables.product.company_short %} has a fair use policy that begins to throttle jobs based on several factors, such as how many jobs you are running or how many jobs are running across the entirety of {% data variables.product.prodname_actions %}. diff --git a/content/actions/using-jobs/using-conditions-to-control-job-execution.md b/content/actions/using-jobs/using-conditions-to-control-job-execution.md index 7069dba9fb..7440c0446c 100644 --- a/content/actions/using-jobs/using-conditions-to-control-job-execution.md +++ b/content/actions/using-jobs/using-conditions-to-control-job-execution.md @@ -8,16 +8,12 @@ versions: ghae: '*' ghec: '*' --- - + {% data reusables.actions.enterprise-github-hosted-runners %} ## Overview -{% note %} - -**Note:** A job that is skipped will report its status as "Success". It will not prevent a pull request from merging, even if it is a required check. - -{% endnote %} +{% data reusables.actions.workflows.skipped-job-status-checks-passing %} {% data reusables.actions.jobs.section-using-conditions-to-control-job-execution %} diff --git a/content/actions/using-workflows/events-that-trigger-workflows.md b/content/actions/using-workflows/events-that-trigger-workflows.md index d9967cf9ee..97011135a6 100644 --- a/content/actions/using-workflows/events-that-trigger-workflows.md +++ b/content/actions/using-workflows/events-that-trigger-workflows.md @@ -942,7 +942,7 @@ jobs: {% endnote %} -Runs your workflow when you push a commit or tag. +Runs your workflow when you push a commit or tag, or when you clone a repository. For example, you can run a workflow when the `push` event occurs. diff --git a/content/actions/using-workflows/sharing-workflows-secrets-and-runners-with-your-organization.md b/content/actions/using-workflows/sharing-workflows-secrets-and-runners-with-your-organization.md index ebbf42f586..50906fb206 100644 --- a/content/actions/using-workflows/sharing-workflows-secrets-and-runners-with-your-organization.md +++ b/content/actions/using-workflows/sharing-workflows-secrets-and-runners-with-your-organization.md @@ -12,7 +12,7 @@ versions: ghec: '*' type: how_to --- - + {% data reusables.actions.enterprise-github-hosted-runners %} ## Overview @@ -67,7 +67,7 @@ When creating a secret {% ifversion actions-configuration-variables %} or variab ## Share self-hosted runners within an organization -Organization admins can add their self-hosted runners to groups, and then create policies that control which repositories can access the group. +Organization owners can add their self-hosted runners to groups, and then create policies that control which repositories can access the group. For more information, see "[AUTOTITLE](/actions/hosting-your-own-runners/managing-self-hosted-runners/managing-access-to-self-hosted-runners-using-groups)." diff --git a/content/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks.md b/content/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks.md index c887b92b3e..bef9e915c1 100644 --- a/content/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks.md +++ b/content/pull-requests/collaborating-with-pull-requests/collaborating-on-repositories-with-code-quality-features/about-status-checks.md @@ -25,6 +25,8 @@ You can see the overall state of the last commit to a branch on your repository' {% data reusables.pull_requests.required-checks-must-pass-to-merge %} +{% data reusables.actions.workflows.skipped-job-status-checks-passing %} + ## Types of status checks on {% data variables.product.product_name %} There are two types of status checks on {% data variables.product.product_name %}: diff --git a/data/reusables/actions/about-enterprise-level-runner-groups.md b/data/reusables/actions/about-enterprise-level-runner-groups.md index 69ed34c16a..cac6892dd9 100644 --- a/data/reusables/actions/about-enterprise-level-runner-groups.md +++ b/data/reusables/actions/about-enterprise-level-runner-groups.md @@ -1 +1 @@ -By default, repositories in an organization do not have access to enterprise-level runner groups. To give repositories access to enterprise runner groups, organization administrators must configure each enterprise runner group and choose which repositories have access. \ No newline at end of file +By default, repositories in an organization do not have access to enterprise-level runner groups. To give repositories access to enterprise runner groups, organization owners must configure each enterprise runner group and choose which repositories have access. \ No newline at end of file diff --git a/data/reusables/actions/about-organization-level-runner-groups.md b/data/reusables/actions/about-organization-level-runner-groups.md index d169389e2a..cf23a3b59e 100644 --- a/data/reusables/actions/about-organization-level-runner-groups.md +++ b/data/reusables/actions/about-organization-level-runner-groups.md @@ -1 +1 @@ -By default, all repositories in an organization are granted access to organization-level runner groups. To restrict which repositories have access, organization administrators must configure organization runner groups and choose which repositories have access. \ No newline at end of file +By default, all repositories in an organization are granted access to organization-level runner groups. To restrict which repositories have access, organization owners must configure organization runner groups and choose which repositories have access. \ No newline at end of file diff --git a/data/reusables/actions/about-runner-groups.md b/data/reusables/actions/about-runner-groups.md index 32b92852b6..5fc01d3039 100644 --- a/data/reusables/actions/about-runner-groups.md +++ b/data/reusables/actions/about-runner-groups.md @@ -1,8 +1,8 @@ -To control access to runners at the organization{% ifversion ghec or ghes or ghae %} and/or enterprise levels, enterprise and organization administrators can use runner groups.{% else %} level, organizations using the {% data variables.product.prodname_team %} plan can use runner groups. {% endif %} +To control access to runners at the organization{% ifversion ghec or ghes or ghae %} and/or enterprise levels, enterprise and organization owners can use runner groups.{% else %} level, organizations using the {% data variables.product.prodname_team %} plan can use runner groups. {% endif %} Runner groups are used to collect sets of runners and create a security boundary around them. You can then decide which organizations or repositories are permitted to run jobs on those sets of machines. -{%- ifversion ghec or ghes or ghae %} Enterprise administrators can configure access policies that control which organizations {% ifversion restrict-groups-to-workflows %}and workflows {% endif %}in an enterprise have access to the runner group.{% else %} Organization administrators can configure access policies that control which repositories in an organization have access to the runner group.{% endif %} +{%- ifversion ghec or ghes or ghae %} Enterprise administrators can configure access policies that control which organizations {% ifversion restrict-groups-to-workflows %}and workflows {% endif %}in an enterprise have access to the runner group.{% else %} Organization owners can configure access policies that control which repositories in an organization have access to the runner group.{% endif %} When you grant access access to a runner group, you can see the runner group listed in the organization's runner settings. Optionally, you can assign additional granular repository{% ifversion restrict-groups-to-workflows %} and workflow{% endif %} access policies to the runner group. diff --git a/data/reusables/actions/workflows/skipped-job-status-checks-passing.md b/data/reusables/actions/workflows/skipped-job-status-checks-passing.md new file mode 100644 index 0000000000..df19946690 --- /dev/null +++ b/data/reusables/actions/workflows/skipped-job-status-checks-passing.md @@ -0,0 +1,5 @@ +{% note %} + +**Note:** A job that is skipped will report its status as "Success". It will not prevent a pull request from merging, even if it is a required check. + +{% endnote %} diff --git a/data/reusables/copilot/enabling-in-enterprise.md b/data/reusables/copilot/enabling-in-enterprise.md index beff751e5b..a8cd56d72d 100644 --- a/data/reusables/copilot/enabling-in-enterprise.md +++ b/data/reusables/copilot/enabling-in-enterprise.md @@ -8,4 +8,4 @@ - To enable {% data variables.product.prodname_copilot %} for all organizations in your enterprise, both current and future, select **Allow for all organizations**. - To enable {% data variables.product.prodname_copilot %} for specific organizations, select **Allow for specific organizations**. 1. If you selected **Allow for specific organizations**, select the organizations you want to enable {% data variables.product.prodname_copilot %} for. Alternatively, you can select the organizations you want to disable {% data variables.product.prodname_copilot %} access for. -1. To finish setting up your {% data variables.product.prodname_copilot_for_business %} subscription, click **Save**. Organization administrators will receive an email with instructions on how to add members to {% data variables.product.prodname_copilot %}. +1. To finish setting up your {% data variables.product.prodname_copilot_for_business %} subscription, click **Save**. Organization owners will receive an email with instructions on how to add members to {% data variables.product.prodname_copilot %}.