From 27a301c43fd8a985cf5c897f44444a4664be52e5 Mon Sep 17 00:00:00 2001 From: Dev Prakash Sharma Date: Thu, 6 Oct 2022 23:04:06 +0530 Subject: [PATCH 1/2] Update authorizing-oauth-apps.md --- .../apps/building-oauth-apps/authorizing-oauth-apps.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/content/developers/apps/building-oauth-apps/authorizing-oauth-apps.md b/content/developers/apps/building-oauth-apps/authorizing-oauth-apps.md index 16619daebe..538980fd98 100644 --- a/content/developers/apps/building-oauth-apps/authorizing-oauth-apps.md +++ b/content/developers/apps/building-oauth-apps/authorizing-oauth-apps.md @@ -283,7 +283,7 @@ you or your users have two-factor authentication enabled. The `redirect_uri` parameter is optional. If left out, GitHub will redirect users to the callback URL configured in the OAuth Application -settings. If provided, the redirect URL's host and port must exactly +settings. If provided, the redirect URL's host(excluding sub-domains) and port must exactly match the callback URL. The redirect URL's path must reference a subdirectory of the callback URL. @@ -291,6 +291,8 @@ subdirectory of the callback URL. GOOD: http://example.com/path GOOD: http://example.com/path/subdir/other + GOOD: http://oauth.example.com/path + GOOD: http://oauth.example.com/path/subdir/other BAD: http://example.com/bar BAD: http://example.com/ BAD: http://example.com:8080/path From 06a9873b6168768accb356e1aa14c474c7b32c9c Mon Sep 17 00:00:00 2001 From: Anne-Marie Date: Mon, 10 Oct 2022 16:51:00 +0200 Subject: [PATCH 2/2] Update authorizing-oauth-apps.md --- .../apps/building-oauth-apps/authorizing-oauth-apps.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/content/developers/apps/building-oauth-apps/authorizing-oauth-apps.md b/content/developers/apps/building-oauth-apps/authorizing-oauth-apps.md index 538980fd98..a0b3a1820c 100644 --- a/content/developers/apps/building-oauth-apps/authorizing-oauth-apps.md +++ b/content/developers/apps/building-oauth-apps/authorizing-oauth-apps.md @@ -283,7 +283,7 @@ you or your users have two-factor authentication enabled. The `redirect_uri` parameter is optional. If left out, GitHub will redirect users to the callback URL configured in the OAuth Application -settings. If provided, the redirect URL's host(excluding sub-domains) and port must exactly +settings. If provided, the redirect URL's host (excluding sub-domains) and port must exactly match the callback URL. The redirect URL's path must reference a subdirectory of the callback URL.