jprdonnelly/docs
1
0
Fork 0
mirror of synced 2025-12-21 02:46:50 -05:00
Code Issues Projects Releases Wiki Activity

validate that 'pathname' is not repeated as query (#37319)

Browse Source
This commit is contained in:
Peter Bengtsson
2023-05-31 07:37:14 -04:00
committed by GitHub
parent 7d00e4036d
commit 21eeb2cc28
2 changed files with 10 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
src/pageinfo/middleware.js
View File

@@ -21,6 +21,9 @@ const validationMiddleware = (req, res, next) => {
if (!pathname) { if (!pathname) {
return res.status(400).json({ error: `No 'pathname' query` }) return res.status(400).json({ error: `No 'pathname' query` })
} }
if (Array.isArray(pathname)) {
return res.status(400).json({ error: "Multiple 'pathname' keys" })
}
if (!pathname.trim()) { if (!pathname.trim()) {
return res.status(400).json({ error: `'pathname' query empty` }) return res.status(400).json({ error: `'pathname' query empty` })
} }

7
src/pageinfo/tests/pageinfo.js
View File

@@ -63,6 +63,13 @@ describe('pageinfo api', () => {
expect(error).toBe("'pathname' query empty") expect(error).toBe("'pathname' query empty")
}) })
test('repeated pathname query string key', async () => {
const res = await get('/api/pageinfo/v1?pathname=a&pathname=b')
expect(res.statusCode).toBe(400)
const { error } = JSON.parse(res.body)
expect(error).toBe("Multiple 'pathname' keys")
})
test('redirects correct the URL', async () => { test('redirects correct the URL', async () => {
// Regular redirect from `redirect_from` // Regular redirect from `redirect_from`
{ {