jprdonnelly/docs
1
0
Fork 0
mirror of synced 2025-12-19 18:10:59 -05:00
Code Issues Projects Releases Wiki Activity

Add external GitHub CLI product (#16277)

Browse Source
This commit is contained in:
Matt Pollard
2020-11-03 08:11:49 +01:00
committed by GitHub
parent 5a31a09eb0
commit 2484cd3f16
2 changed files with 8 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
lib/all-products.js
View File

@@ -43,6 +43,12 @@ sortedProductIds.forEach(productId => {
}) })
const externalProducts = { const externalProducts = {
cli: {
id: 'cli',
name: 'GitHub CLI',
href: 'https://cli.github.com/manual',
external: true
},
atom: { atom: {
id: 'atom', id: 'atom',
name: 'Atom', name: 'Atom',

3
tests/rendering/sidebar.js
View File

@@ -24,7 +24,8 @@ describe('sidebar', () => {
expect($githubPage('.sidebar li.sidebar-product > a').text().trim()).toBe('GitHub.com') expect($githubPage('.sidebar li.sidebar-product > a').text().trim()).toBe('GitHub.com')
}) })
test('includes links to external products like Atom and Electron', async () => { test('includes links to external products like the CLI, Atom, and Electron', async () => {
expect($homePage('.sidebar a[href="https://cli.github.com/manual"]')).toHaveLength(1)
expect($homePage('.sidebar a[href="https://atom.io/docs"]')).toHaveLength(1) expect($homePage('.sidebar a[href="https://atom.io/docs"]')).toHaveLength(1)
expect($homePage('.sidebar a[href="https://electronjs.org/docs"]')).toHaveLength(1) expect($homePage('.sidebar a[href="https://electronjs.org/docs"]')).toHaveLength(1)
}) })