From 26895b8399e992ac2d31be48150a05f4eae8ced6 Mon Sep 17 00:00:00 2001 From: Kevin Heis Date: Wed, 5 Mar 2025 16:28:14 -0800 Subject: [PATCH] Auto codespaces feedback round 1 (#54690) --- .github/workflows/codespace-review-check.yml | 7 ++++--- .github/workflows/codespace-review-up.yml | 4 ---- 2 files changed, 4 insertions(+), 7 deletions(-) diff --git a/.github/workflows/codespace-review-check.yml b/.github/workflows/codespace-review-check.yml index a07d36e465..3919f0fae9 100644 --- a/.github/workflows/codespace-review-check.yml +++ b/.github/workflows/codespace-review-check.yml @@ -58,8 +58,7 @@ jobs: fi # https://stackoverflow.com/a/70716837 - # This might not need `| sed 's/"/\\"/g'` - matrix=$(echo "$branches" | jq -scR 'split("\n") | map(select(. != ""))' | sed 's/"/\\"/g') + matrix=$(echo "$branches" | jq -scR 'split("\n") | map(select(. != ""))') echo "- Matrix: $matrix" echo "matrix=$matrix" >> $GITHUB_OUTPUT @@ -76,7 +75,7 @@ jobs: matrix: value: ${{ fromJSON(needs.codespace-review-check-find.outputs.matrix) }} runs-on: ubuntu-latest - if: ${{ github.repository == 'github/docs-internal' }} + if: ${{ github.repository == 'github/docs-internal' && needs.codespace-review-check-find.outputs.matrix }} env: repo: github/docs-internal steps: @@ -84,6 +83,8 @@ jobs: - name: Find the pull request id: findPr + env: + GH_TOKEN: ${{ secrets.DOCS_BOT_PAT_CODESPACE }} run: | echo "Looking up pull request" echo "- Branch: ${{ matrix.value }}" diff --git a/.github/workflows/codespace-review-up.yml b/.github/workflows/codespace-review-up.yml index a644c63afc..8254b9129d 100644 --- a/.github/workflows/codespace-review-up.yml +++ b/.github/workflows/codespace-review-up.yml @@ -214,10 +214,6 @@ jobs: After 4 hours, you can reactivate your codespace by applying the https://github.com/${{ env.REPO }}/labels/extend-codespace label to the pull request. If the label is already applied, you can remove and reapply the label to reactivate your codespace. - #### Maximum of 100 _active_ codespaces per user - - Your codespace may be deleted if the limit is reached. -
Table of review links ${{ steps.changes.outputs.changesTable && 'The table shows the files in the `content` directory that were changed in this pull request. This helps you review your changes on the review server. Changes to the `data` directory are not included in this table.' || '' }}