From 61a777f18dc9d005e3575f7acc5c1a55c2918d6c Mon Sep 17 00:00:00 2001 From: Robert Sese <734194+rsese@users.noreply.github.com> Date: Wed, 8 Jun 2022 12:05:45 -0500 Subject: [PATCH 1/2] Update rendering tests to use different products --- tests/rendering/footer.js | 4 ++-- tests/rendering/products.js | 6 +++--- tests/rendering/sidebar.js | 2 +- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/rendering/footer.js b/tests/rendering/footer.js index d5171f4f0a..1c9055971b 100644 --- a/tests/rendering/footer.js +++ b/tests/rendering/footer.js @@ -8,7 +8,7 @@ describe('footer', () => { describe('"contact us" link', () => { test('leads to support from articles', async () => { - const $ = await getDOM(`/en/${nonEnterpriseDefaultVersion}/github`) + const $ = await getDOM(`/en/${nonEnterpriseDefaultVersion}/issues`) expect($('a#contact-us').attr('href')).toBe('https://support.github.com/contact') }) @@ -20,7 +20,7 @@ describe('footer', () => { describe('"contact us" link with nextjs', () => { test('leads to support from articles', async () => { - const $ = await getDOM(`/en/${nonEnterpriseDefaultVersion}/github?nextjs=`) + const $ = await getDOM(`/en/${nonEnterpriseDefaultVersion}/issues?nextjs=`) expect($('a#contact-us').attr('href')).toBe('https://support.github.com/contact') }) }) diff --git a/tests/rendering/products.js b/tests/rendering/products.js index f473bb4552..72462beea7 100644 --- a/tests/rendering/products.js +++ b/tests/rendering/products.js @@ -6,7 +6,7 @@ import nonEnterpriseDefaultVersion from '../../lib/non-enterprise-default-versio describe('mobile-only products nav', () => { const cases = [ // Note the unversioned homepage at `/` does not have a product selected in the mobile dropdown - ['/github', 'GitHub'], + ['/repositories', 'Repositories'], // Enterprise server ['/en/enterprise/admin', 'Enterprise administrators'], [ @@ -41,8 +41,8 @@ describe('products middleware', () => { test('adds res.context.currentProduct object', async () => { const currentProduct = await getJSON( - `/en/${nonEnterpriseDefaultVersion}/github?json=currentProduct` + `/en/${nonEnterpriseDefaultVersion}/actions?json=currentProduct` ) - expect(currentProduct).toBe('github') + expect(currentProduct).toBe('actions') }) }) diff --git a/tests/rendering/sidebar.js b/tests/rendering/sidebar.js index 228bb0323d..e6bfe97f2f 100644 --- a/tests/rendering/sidebar.js +++ b/tests/rendering/sidebar.js @@ -34,7 +34,7 @@ describe('sidebar', () => { expect($githubPage('[data-testid=sidebar] [data-testid=sidebar-product]').length).toBe(1) expect( $githubPage('[data-testid=sidebar] [data-testid=sidebar-product] > a').text().trim() - ).toBe('GitHub') + ).toBe('Get started') }) test('includes links to external products like the Atom, Electron, and CodeQL', async () => { From fa661f8f27e494974a59bf432eced7657183497a Mon Sep 17 00:00:00 2001 From: Jules Parker <19994093+jules-p@users.noreply.github.com> Date: Fri, 10 Jun 2022 09:49:28 +0200 Subject: [PATCH 2/2] adds copy button --- data/reusables/copilot/type-function-header.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/reusables/copilot/type-function-header.md b/data/reusables/copilot/type-function-header.md index bec8ab2ca7..3488f53cba 100644 --- a/data/reusables/copilot/type-function-header.md +++ b/data/reusables/copilot/type-function-header.md @@ -1,5 +1,5 @@ 1. In the JavaScript file, type the following function header. - ``` + ```javascript{:copy} function calculateDaysBetweenDates(begin, end) { ``` \ No newline at end of file