From e6fca1f42b4d35f4c80b4b4ceadebe2631932320 Mon Sep 17 00:00:00 2001 From: M Hickford Date: Wed, 9 Nov 2022 19:01:34 +0000 Subject: [PATCH 1/6] Explain that people outside organisation cannot view any teams. --- data/reusables/organizations/types-of-team-visibility.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/data/reusables/organizations/types-of-team-visibility.md b/data/reusables/organizations/types-of-team-visibility.md index c085882e60..4f3795dfa1 100644 --- a/data/reusables/organizations/types-of-team-visibility.md +++ b/data/reusables/organizations/types-of-team-visibility.md @@ -2,3 +2,5 @@ Teams can be visible or secret: - Visible teams can be [viewed and @mentioned](/articles/basic-writing-and-formatting-syntax/#mentioning-people-and-teams) by every organization member. - Secret teams are only visible to the people on the team and people with owner permissions. They're great for hiding teams with sensitive names or members, such as those used for working with external partners or clients. Secret teams cannot be nested under parent teams or have child teams. + +People outside the organisation cannot view any teams. From 3d6ed9e0a3be6a1cbbf06274aaa2f2873e72c8e4 Mon Sep 17 00:00:00 2001 From: Laura Coursen Date: Thu, 10 Nov 2022 12:54:13 -0600 Subject: [PATCH 2/6] Add :nail_care: --- data/reusables/organizations/types-of-team-visibility.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/data/reusables/organizations/types-of-team-visibility.md b/data/reusables/organizations/types-of-team-visibility.md index 4f3795dfa1..305864f75a 100644 --- a/data/reusables/organizations/types-of-team-visibility.md +++ b/data/reusables/organizations/types-of-team-visibility.md @@ -3,4 +3,4 @@ Teams can be visible or secret: - Visible teams can be [viewed and @mentioned](/articles/basic-writing-and-formatting-syntax/#mentioning-people-and-teams) by every organization member. - Secret teams are only visible to the people on the team and people with owner permissions. They're great for hiding teams with sensitive names or members, such as those used for working with external partners or clients. Secret teams cannot be nested under parent teams or have child teams. -People outside the organisation cannot view any teams. +People who are not members of the organization cannot view any teams. From 2b436719d1b6e07d3b9211171d1628b53fc90665 Mon Sep 17 00:00:00 2001 From: Per Eriksson Date: Tue, 8 Nov 2022 12:59:47 +0100 Subject: [PATCH 3/6] passing secrets to reusable workflows --- content/actions/security-guides/encrypted-secrets.md | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/content/actions/security-guides/encrypted-secrets.md b/content/actions/security-guides/encrypted-secrets.md index 693eb7bb34..b2bf6542e5 100644 --- a/content/actions/security-guides/encrypted-secrets.md +++ b/content/actions/security-guides/encrypted-secrets.md @@ -217,6 +217,12 @@ You can check which access policies are being applied to a secret in your organi {% endnote %} +{% note %} + +**Note:** Secrets are not automatically passed to reusable workflows. For more information, see "[Passing inputs and secrets to a reusable workflow](/actions/using-workflows/reusing-workflows#passing-inputs-and-secrets-to-a-reusable-workflow).". + +{% endnote %} + To provide an action with a secret as an input or environment variable, you can use the `secrets` context to access secrets you've created in your repository. For more information, see "[Contexts](/actions/learn-github-actions/contexts)" and "[Workflow syntax for {% data variables.product.prodname_actions %}](/github/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions)." {% raw %} From 7331cff24c8a311d6200a538cfb8246f8385a60d Mon Sep 17 00:00:00 2001 From: Laura Coursen Date: Tue, 8 Nov 2022 13:45:49 -0600 Subject: [PATCH 4/6] Add :nail_care: --- content/actions/security-guides/encrypted-secrets.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/content/actions/security-guides/encrypted-secrets.md b/content/actions/security-guides/encrypted-secrets.md index b2bf6542e5..b7563b6ede 100644 --- a/content/actions/security-guides/encrypted-secrets.md +++ b/content/actions/security-guides/encrypted-secrets.md @@ -217,11 +217,13 @@ You can check which access policies are being applied to a secret in your organi {% endnote %} +{% ifversion fpt or ghec or ghes > 3.3 or ghae > 3.3 %} {% note %} -**Note:** Secrets are not automatically passed to reusable workflows. For more information, see "[Passing inputs and secrets to a reusable workflow](/actions/using-workflows/reusing-workflows#passing-inputs-and-secrets-to-a-reusable-workflow).". +**Note:** Secrets are not automatically passed to reusable workflows. For more information, see "[Reusing workflows](/actions/using-workflows/reusing-workflows#passing-inputs-and-secrets-to-a-reusable-workflow)." {% endnote %} +{% endif %} To provide an action with a secret as an input or environment variable, you can use the `secrets` context to access secrets you've created in your repository. For more information, see "[Contexts](/actions/learn-github-actions/contexts)" and "[Workflow syntax for {% data variables.product.prodname_actions %}](/github/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions)." From 7a3d63e20244f8d4499e14ec0be57464896551c0 Mon Sep 17 00:00:00 2001 From: Per Eriksson Date: Tue, 8 Nov 2022 21:14:14 +0100 Subject: [PATCH 5/6] merge notes --- .../security-guides/encrypted-secrets.md | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/content/actions/security-guides/encrypted-secrets.md b/content/actions/security-guides/encrypted-secrets.md index b7563b6ede..29031a535d 100644 --- a/content/actions/security-guides/encrypted-secrets.md +++ b/content/actions/security-guides/encrypted-secrets.md @@ -213,18 +213,18 @@ You can check which access policies are being applied to a secret in your organi {% note %} -**Note:** {% data reusables.actions.forked-secrets %} +**Notes:** + +* {% data reusables.actions.forked-secrets %} + +{-% ifversion fpt or ghec or ghes > 3.3 or ghae > 3.3 %} + +* Secrets are not automatically passed to reusable workflows. For more information, see "[Reusing workflows](/actions/using-workflows/reusing-workflows#passing-inputs-and-secrets-to-a-reusable-workflow)." + +{%- endif %} {% endnote %} -{% ifversion fpt or ghec or ghes > 3.3 or ghae > 3.3 %} -{% note %} - -**Note:** Secrets are not automatically passed to reusable workflows. For more information, see "[Reusing workflows](/actions/using-workflows/reusing-workflows#passing-inputs-and-secrets-to-a-reusable-workflow)." - -{% endnote %} -{% endif %} - To provide an action with a secret as an input or environment variable, you can use the `secrets` context to access secrets you've created in your repository. For more information, see "[Contexts](/actions/learn-github-actions/contexts)" and "[Workflow syntax for {% data variables.product.prodname_actions %}](/github/automating-your-workflow-with-github-actions/workflow-syntax-for-github-actions)." {% raw %} From 06ce1708294ca1efac378e0b651b7750cd2abf57 Mon Sep 17 00:00:00 2001 From: Per Eriksson Date: Tue, 8 Nov 2022 21:24:55 +0100 Subject: [PATCH 6/6] typo --- content/actions/security-guides/encrypted-secrets.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/actions/security-guides/encrypted-secrets.md b/content/actions/security-guides/encrypted-secrets.md index 29031a535d..fe5355ee55 100644 --- a/content/actions/security-guides/encrypted-secrets.md +++ b/content/actions/security-guides/encrypted-secrets.md @@ -217,11 +217,11 @@ You can check which access policies are being applied to a secret in your organi * {% data reusables.actions.forked-secrets %} -{-% ifversion fpt or ghec or ghes > 3.3 or ghae > 3.3 %} +{% ifversion fpt or ghec or ghes > 3.3 or ghae > 3.3 %} * Secrets are not automatically passed to reusable workflows. For more information, see "[Reusing workflows](/actions/using-workflows/reusing-workflows#passing-inputs-and-secrets-to-a-reusable-workflow)." -{%- endif %} +{% endif %} {% endnote %}