From c5f97882236d901d6288a9b6bfb49f8b95dc973d Mon Sep 17 00:00:00 2001 From: Robert Sese Date: Thu, 3 Feb 2022 10:31:05 -0600 Subject: [PATCH 1/3] Version the 'All products' link (#24972) * Don't show link no matter what version you're on * Maintain current version in link * No 'All products' link on homepage for all versions --- components/sidebar/AllProductsLink.tsx | 9 ++++++++- components/sidebar/SidebarHomepage.tsx | 3 --- tests/rendering/server.js | 5 ----- 3 files changed, 8 insertions(+), 9 deletions(-) diff --git a/components/sidebar/AllProductsLink.tsx b/components/sidebar/AllProductsLink.tsx index 4a67b33541..beecbab575 100644 --- a/components/sidebar/AllProductsLink.tsx +++ b/components/sidebar/AllProductsLink.tsx @@ -1,11 +1,18 @@ import { useRouter } from 'next/router' import { ArrowLeftIcon } from '@primer/octicons-react' +import { DEFAULT_VERSION, useVersion } from 'components/hooks/useVersion' export const AllProductsLink = () => { const router = useRouter() + const { currentVersion } = useVersion() + const currentVersionPathSegment = currentVersion === DEFAULT_VERSION ? '' : `/${currentVersion}` + return (
  • - + All products diff --git a/components/sidebar/SidebarHomepage.tsx b/components/sidebar/SidebarHomepage.tsx index 93c78600d8..e94a5fa1c7 100644 --- a/components/sidebar/SidebarHomepage.tsx +++ b/components/sidebar/SidebarHomepage.tsx @@ -6,8 +6,6 @@ import { useVersion } from 'components/hooks/useVersion' import { useMainContext } from 'components/context/MainContext' import { Link } from 'components/Link' -import { AllProductsLink } from './AllProductsLink' - export const SidebarHomepage = () => { const router = useRouter() const { currentVersion } = useVersion() @@ -55,7 +53,6 @@ export const SidebarHomepage = () => { return (