jprdonnelly/docs
1
0
Fork 0
mirror of synced 2025-12-23 21:07:12 -05:00
Code Issues Projects Releases Wiki Activity

Removing webpack build step (#20405)

Browse Source 
* removing webpack build step

* keep copywebpackplugin and add fonts to assets/fonts

* update marketing font path

* update font path

* update font

* remove builtAssets

* remove copying front end code with dist

* move Inter fonts to /assets/fonts/inter

* move copy-webpack-plugin back to deps

Co-authored-by: Mike Surowiec <mikesurowiec@users.noreply.github.com>
This commit is contained in:
Grace Park
2021-07-22 09:11:30 -07:00
committed by GitHub
parent 3db2e89fcc
commit 44f451eb09
11 changed files with 251 additions and 643 deletions
Download Patch File Download Diff File Expand all files Collapse all files

68
tests/rendering/server.js
View File

@@ -3,7 +3,6 @@ import enterpriseServerReleases from '../../lib/enterprise-server-releases.js'
import { get, getDOM, head, post } from '../helpers/supertest.js'
import { describeViaActionsOnly } from '../helpers/conditional-runs.js'
import { loadPages } from '../../lib/page-data.js'
import builtAssets from '../../lib/built-asset-urls.js'
import CspParse from 'csp-parse'
import { productMap } from '../../lib/all-products.js'
import { jest } from '@jest/globals'
@@ -177,7 +176,11 @@ describe('server', () => {
const $ = await getDOM('/not-a-real-page')
expect($('h1').text()).toBe('Ooops!')
expect($.text().includes("It looks like this page doesn't exist.")).toBe(true)
expect($.text().includes('We track these errors automatically, but if the problem persists please feel free to contact us.')).toBe(true)
expect(
$.text().includes(
'We track these errors automatically, but if the problem persists please feel free to contact us.'
)
).toBe(true)
expect($.res.statusCode).toBe(404)
})
@@ -200,8 +203,12 @@ describe('server', () => {
test('renders a 500 page when errors are thrown', async () => {
const $ = await getDOM('/_500')
expect($('h1').text()).toBe('Ooops!')
expect($.text().includes("It looks like something went wrong.")).toBe(true)
expect($.text().includes("We track these errors automatically, but if the problem persists please feel free to contact us.")).toBe(true)
expect($.text().includes('It looks like something went wrong.')).toBe(true)
expect(
$.text().includes(
'We track these errors automatically, but if the problem persists please feel free to contact us.'
)
).toBe(true)
expect($.res.statusCode).toBe(500)
})
@@ -498,9 +505,7 @@ describe('server', () => {
const $ = await getDOM(
`${latestEnterprisePath}/github/getting-started-with-github/set-up-git`
)
expect(
$('a[href="/en/desktop/installing-and-configuring-github-desktop"]').length
).toBe(1)
expect($('a[href="/en/desktop/installing-and-configuring-github-desktop"]').length).toBe(1)
})
test('admin articles that link to non-admin articles have Enterprise user links', async () => {
@@ -526,16 +531,16 @@ describe('server', () => {
`${latestEnterprisePath}/admin/installation/upgrading-github-enterprise-server`
)
expect(
$(
'a[href="https://docs.microsoft.com/azure/backup/backup-azure-vms-first-look-arm"]'
).length
$('a[href="https://docs.microsoft.com/azure/backup/backup-azure-vms-first-look-arm"]')
.length
).toBe(1)
})
})
describe('article versions', () => {
test('includes links to all versions of each article', async () => {
const articlePath = 'github/setting-up-and-managing-your-github-user-account/managing-user-account-settings/about-your-personal-dashboard'
const articlePath =
'github/setting-up-and-managing-your-github-user-account/managing-user-account-settings/about-your-personal-dashboard'
const $ = await getDOM(
`/en/enterprise-server@${enterpriseServerReleases.latest}/${articlePath}`
)
@@ -545,7 +550,10 @@ describe('server', () => {
).length
).toBe(2)
// 2.13 predates this feature, so it should be excluded:
expect($(`[data-testid=article-version-picker] a[href="/en/enterprise/2.13/user/${articlePath}"]`).length).toBe(0)
expect(
$(`[data-testid=article-version-picker] a[href="/en/enterprise/2.13/user/${articlePath}"]`)
.length
).toBe(0)
})
test('is not displayed if article has only one version', async () => {
@@ -852,8 +860,9 @@ describe('GitHub Desktop URLs', () => {
describe('static assets', () => {
test('fonts', async () => {
expect((await get('/dist/fonts/Inter-Medium.woff')).statusCode).toBe(200)
expect((await get('/dist/fonts/Inter-Regular.woff')).statusCode).toBe(200)
expect((await get('/assets/fonts/inter/Inter-Bold.woff')).statusCode).toBe(200)
expect((await get('/assets/fonts/inter/Inter-Medium.woff')).statusCode).toBe(200)
expect((await get('/assets/fonts/inter/Inter-Regular.woff')).statusCode).toBe(200)
})
})
@@ -948,37 +957,6 @@ describe('?json query param for context debugging', () => {
})
})
describe('stylesheets', () => {
it('compiles and sets the right content-type header', async () => {
const stylesheetUrl = builtAssets.main.css
const res = await get(stylesheetUrl)
expect(res.statusCode).toBe(200)
expect(res.headers['content-type']).toBe('text/css; charset=UTF-8')
})
})
describe('client-side JavaScript bundle', () => {
let res
beforeAll(async () => {
const scriptUrl = builtAssets.main.js
res = await get(scriptUrl)
})
it('returns a 200 response', async () => {
expect(res.statusCode).toBe(200)
})
it('sets the right content-type header', async () => {
expect(res.headers['content-type']).toBe('application/javascript; charset=UTF-8')
})
// TODO: configure webpack to create production bundle in the test env
// it('is not too big', async () => {
// const tooBig = 10 * 1000
// expect(res.text.length).toBeLessThan(tooBig)
// })
})
describe('static routes', () => {
it('serves content from the /assets directory', async () => {
expect((await get('/assets/images/site/be-social.gif')).statusCode).toBe(200)