Fix eslint no-undef violations (#58233)

eslint.config.ts

@@ -25,6 +25,16 @@ export default [
         ...globals.node,
         ...globals.commonjs,
         ...globals.es2020,
+        // Fetch API types for TypeScript
+        RequestInit: 'readonly',
+        RequestInfo: 'readonly',
+        HeadersInit: 'readonly',
+        JSX: 'readonly',
+        // Node.js types for TypeScript
+        BufferEncoding: 'readonly',
+        NodeJS: 'readonly',
+        // cheerio namespace for TypeScript
+        cheerio: 'readonly',
       },
       parserOptions: {
         requireConfigFile: false,
@@ -87,7 +97,6 @@ export default [
       // Disabled rules to review
       'github/no-then': 'off', // 30+
       '@typescript-eslint/ban-ts-comment': 'off', // 50+
-      'no-undef': 'off', // 50+
       'no-shadow': 'off', // 150+
       'prefer-template': 'off', // 150+
       'github/array-foreach': 'off', // 250+

src/app/client-layout.tsx

@@ -1,7 +1,8 @@
 'use client'
 
+import React, { useEffect, useMemo, useState } from 'react'
+import type { JSX } from 'react'
 import { ThemeProvider } from '@primer/react'
-import { useEffect, useMemo, useState } from 'react'
 
 import { LocaleProvider } from '@/app/lib/locale-context'
 import { useDetectLocale } from '@/app/lib/use-detect-locale'

src/app/components/AppRouterLanguagesContext.tsx

@@ -1,6 +1,6 @@
 'use client'
 
-import { createContext, useContext } from 'react'
+import React, { createContext, useContext } from 'react'
 import { languages, type LanguageCode } from '@/languages/lib/languages'
 
 export type AppRouterLanguageItem = {

src/app/layout.tsx

@@ -1,6 +1,7 @@
 import '@/frame/stylesheets/index.scss'
 import type { Metadata, Viewport } from 'next'
 import { ReactNode } from 'react'
+import type { JSX } from 'react'
 
 export const metadata: Metadata = {
   title: {

src/app/lib/locale-context.tsx

@@ -1,6 +1,7 @@
 'use client'
 
 import { createContext, useContext, ReactNode, useMemo } from 'react'
+import type { JSX } from 'react'
 import { languages, languageKeys, type LanguageCode } from '@/languages/lib/languages'
 
 interface LocaleContextType {

src/app/types.ts

@@ -2,6 +2,7 @@
  * Enhanced type definitions for the app router with strict validation
  */
 
+import React from 'react'
 import type { LanguageCode } from '@/languages/lib/languages'
 
 // Core theme types with strict validation

src/automated-pipelines/components/AutomatedPage.tsx

@@ -1,3 +1,4 @@
+import React from 'react'
 import { DefaultLayout } from '@/frame/components/DefaultLayout'
 import { ArticleTitle } from '@/frame/components/article/ArticleTitle'
 import { MarkdownContent } from '@/frame/components/ui/MarkdownContent'

src/automated-pipelines/components/AutomatedPageContext.tsx

@@ -1,4 +1,5 @@
 import { createContext, useContext } from 'react'
+import type { JSX } from 'react'
 import type { MiniTocItem } from '@/frame/components/context/ArticleContext'
 
 export type AutomatedPageContextT = {

src/events/components/Survey.tsx

@@ -1,4 +1,4 @@
-import { useState, useRef, useEffect } from 'react'
+import React, { useState, useRef, useEffect } from 'react'
 import cx from 'classnames'
 import { useRouter } from 'next/router'
 import { ThumbsdownIcon, ThumbsupIcon } from '@primer/octicons-react'

src/frame/components/DefaultLayout.tsx

@@ -1,3 +1,4 @@
+import React from 'react'
 import Head from 'next/head'
 import { useRouter } from 'next/router'
 

src/frame/components/article/ArticleTitle.tsx

@@ -1,3 +1,5 @@
+import React from 'react'
+
 type Props = {
   children: React.ReactNode
 }

src/frame/components/article/HeadingLink.tsx

@@ -1,4 +1,5 @@
 import GithubSlugger from 'github-slugger'
+import type { JSX } from 'react'
 
 const slugger = new GithubSlugger()
 

src/frame/components/context/ArticleContext.tsx

@@ -1,5 +1,6 @@
 import { SupportPortalVaIframeProps } from '@/frame/components/article/SupportPortalVaIframe'
 import { createContext, useContext } from 'react'
+import type { JSX } from 'react'
 import type { JourneyContext } from '@/journeys/lib/journey-path-resolver'
 
 export type LearningTrack = {

src/frame/components/page-header/Header.tsx

@@ -1,4 +1,5 @@
 import { useCallback, useEffect, useRef, useState } from 'react'
+import type { JSX } from 'react'
 import cx from 'classnames'
 import { useRouter } from 'next/router'
 import { Dialog, IconButton } from '@primer/react'

src/frame/components/page-header/HeaderSearchAndWidgets.tsx

@@ -1,4 +1,5 @@
 import cx from 'classnames'
+import type { JSX } from 'react'
 import { KebabHorizontalIcon, LinkExternalIcon } from '@primer/octicons-react'
 import { IconButton, ActionMenu, ActionList } from '@primer/react'
 

src/frame/components/ui/Lead/Lead.tsx

@@ -1,4 +1,5 @@
 import { ReactNode } from 'react'
+import type { JSX } from 'react'
 import cx from 'classnames'
 import styles from './Lead.module.scss'
 

src/frame/components/ui/MarkdownContent/MarkdownContent.tsx

@@ -1,4 +1,5 @@
 import { ReactNode } from 'react'
+import type { JSX } from 'react'
 import cx from 'classnames'
 
 import styles from './MarkdownContent.module.scss'

src/frame/components/ui/MarkdownContent/UnrenderedMarkdownContent.tsx

@@ -1,6 +1,7 @@
 import React from 'react'
 import ReactMarkdown from 'react-markdown'
 import type { Components } from 'react-markdown'
+import type { JSX } from 'react'
 import remarkGfm from 'remark-gfm'
 import cx from 'classnames'
 import { IconButton } from '@primer/react'

src/frame/lib/fetch-utils.ts

@@ -2,6 +2,7 @@
  * Utility functions for fetch with retry and timeout functionality
  * to replace got library functionality
  */
+
 export interface FetchWithRetryOptions {
   retries?: number
   retryDelay?: number

src/graphql/components/GraphqlItem.tsx

@@ -1,3 +1,4 @@
+import React from 'react'
 import { HeadingLink } from '@/frame/components/article/HeadingLink'
 import type { GraphqlT } from './types'
 import { Notice } from './Notice'

src/graphql/components/GraphqlPage.tsx

@@ -1,4 +1,5 @@
 import React from 'react'
+import type { JSX } from 'react'
 import cx from 'classnames'
 
 import { Enum } from './Enum'

src/landings/components/LandingHero.tsx

@@ -1,4 +1,4 @@
-import { useEffect, useState } from 'react'
+import React, { useEffect, useState } from 'react'
 import cx from 'classnames'
 import { useRouter } from 'next/router'
 import { LinkExternalIcon, NoteIcon } from '@primer/octicons-react'

src/landings/components/LandingSection.tsx

@@ -1,3 +1,4 @@
+import React from 'react'
 import cx from 'classnames'
 import { HeadingLink } from '@/frame/components/article/HeadingLink'
 

src/landings/components/shared/LandingArticleGridWithFilter.tsx

@@ -1,4 +1,4 @@
-import { useState, useRef, useEffect, useMemo } from 'react'
+import React, { useState, useRef, useEffect, useMemo } from 'react'
 import { TextInput, ActionMenu, ActionList, Token, Pagination } from '@primer/react'
 import { SearchIcon } from '@primer/octicons-react'
 import cx from 'classnames'

src/rest/components/RestCodeSamples.tsx

@@ -1,4 +1,4 @@
-import { useState, useEffect, useRef, FormEvent } from 'react'
+import React, { useState, useEffect, useRef, FormEvent } from 'react'
 import { FormControl, IconButton, Select, SegmentedControl } from '@primer/react'
 import { CheckIcon, CopyIcon, InfoIcon } from '@primer/octicons-react'
 import { announce } from '@primer/live-region-element'

src/search/components/input/AskAIResults.tsx

@@ -1,4 +1,4 @@
-import { useEffect, useRef, useState } from 'react'
+import React, { useEffect, useRef, useState } from 'react'
 import { uniqBy } from 'lodash-es'
 import { executeAISearch } from '../helpers/execute-search-actions'
 import { useRouter } from 'next/router'

src/search/components/input/SearchBarButton.tsx

@@ -1,3 +1,4 @@
+import React from 'react'
 import cx from 'classnames'
 import { IconButton } from '@primer/react'
 import { CopilotIcon, SearchIcon } from '@primer/octicons-react'

src/search/components/input/SearchOverlayContainer.tsx

@@ -1,3 +1,4 @@
+import React from 'react'
 import { SearchOverlay } from './SearchOverlay'
 import { QueryParams } from '../hooks/useMultiQueryParams'
 

src/search/components/results/SearchResults.tsx

@@ -1,7 +1,7 @@
 import { Box, Pagination, Text } from '@primer/react'
 import { SearchIcon } from '@primer/octicons-react'
 import { useRouter } from 'next/router'
-import { useEffect, useRef, useState } from 'react'
+import React, { useEffect, useRef, useState } from 'react'
 import cx from 'classnames'
 
 import { useTranslation } from '@/languages/components/useTranslation'

src/tools/components/Fields.tsx

@@ -1,5 +1,5 @@
 import { ActionList } from '@primer/react'
-import { ReactNode } from 'react'
+import React, { ReactNode } from 'react'
 import cx from 'classnames'
 
 import { PickerItem } from './Picker'