From 592ca1b51f8f9a19cea0f1bcfe024e2147964ff2 Mon Sep 17 00:00:00 2001 From: Robert Sese <734194+rsese@users.noreply.github.com> Date: Thu, 2 Feb 2023 11:09:25 -0600 Subject: [PATCH] only set query params if method isn't GET or HEAD (#34288) --- components/lib/get-rest-code-samples.ts | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/components/lib/get-rest-code-samples.ts b/components/lib/get-rest-code-samples.ts index 24d57be46d..d11fde313b 100644 --- a/components/lib/get-rest-code-samples.ts +++ b/components/lib/get-rest-code-samples.ts @@ -185,13 +185,16 @@ export function getJSExample(operation: Operation, codeSample: CodeSample) { let queryParameters = '' - // Add query parameters to the request path for POST, PUT, DELETE, GET, operations in - // URL template format e.g. 'POST /repos/{owner}/{repo}/releases/{release_id}/assets{?name,label}' + // Query parameters are set automatically for GET and HEAD requests, we + // otherwise have to handle it ourselves for other request methods by adding + // the parameters to the request path in URL template format e.g.: + // + // 'POST /repos/{owner}/{repo}/releases/{release_id}/assets{?name,label}' if ( - operation.verb === 'post' || - operation.verb === 'put' || operation.verb === 'delete' || - operation.verb === 'get' + operation.verb === 'patch' || + operation.verb === 'post' || + operation.verb === 'put' ) { const queryParams = operation.parameters .filter((param) => {