From 62590cc97632b6a25195da38b4a6ae2c5c823cc2 Mon Sep 17 00:00:00 2001
From: Kevin Heis <heiskr@users.noreply.github.com>
Date: Mon, 14 Dec 2020 07:45:45 -0800
Subject: [PATCH 1/3] getPathWithoutLanguage, remove split-slice-join pattern
 (#16914)

Co-authored-by: Vanessa Yuen <6842965+vanessayuenn@users.noreply.github.com>
---
 lib/path-utils.js | 6 +-----
 1 file changed, 1 insertion(+), 5 deletions(-)

diff --git a/lib/path-utils.js b/lib/path-utils.js
index 02e75aab1d..1dcf9b5433 100644
--- a/lib/path-utils.js
+++ b/lib/path-utils.js
@@ -71,11 +71,7 @@ function getPathWithLanguage (href, languageCode) {
 // remove the language from the given HREF
 // /articles/foo -> /en/articles/foo
 function getPathWithoutLanguage (href) {
-  const newHref = href.match(patterns.hasLanguageCode)
-    ? '/' + href.split('/').slice(2).join('/')
-    : href
-
-  return slash(newHref)
+  return slash(href.replace(patterns.hasLanguageCode, '/'))
 }
 
 function getPathWithoutVersion (href) {

From 0fe0b456e0ddcc4c46667a072762c704472705d2 Mon Sep 17 00:00:00 2001
From: Kevin Heis <heiskr@users.noreply.github.com>
Date: Mon, 14 Dec 2020 07:56:05 -0800
Subject: [PATCH 2/3] Move data-directory to also mapLimit (#16921)

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
---
 lib/data-directory.js | 13 ++++++++++---
 lib/pages.js          |  3 ++-
 2 files changed, 12 insertions(+), 4 deletions(-)

diff --git a/lib/data-directory.js b/lib/data-directory.js
index d72abcbf55..851a8fb7a4 100644
--- a/lib/data-directory.js
+++ b/lib/data-directory.js
@@ -2,10 +2,13 @@ const assert = require('assert')
 const fs = require('fs').promises
 const path = require('path')
 const walk = require('walk-sync')
+const { mapLimit } = require('async')
 const yaml = require('js-yaml')
 const { isRegExp, set } = require('lodash')
 const filenameToKey = require('./filename-to-key')
 
+const FILE_READ_LIMIT = 100
+
 module.exports = async function dataDirectory (dir, opts = {}) {
   const defaultOpts = {
     preprocess: (content) => { return content },
@@ -31,7 +34,7 @@ module.exports = async function dataDirectory (dir, opts = {}) {
   const data = {}
 
   // find YAML and Markdown files in the given directory, recursively
-  await Promise.all(walk(dir, { includeBasePath: true })
+  const filenames = walk(dir, { includeBasePath: true })
     .filter(filename => {
       // ignore files that match any of ignorePatterns regexes
       if (opts.ignorePatterns.some(pattern => pattern.test(filename))) return false
@@ -39,7 +42,10 @@ module.exports = async function dataDirectory (dir, opts = {}) {
       // ignore files that don't have a whitelisted file extension
       return opts.extensions.includes(path.extname(filename).toLowerCase())
     })
-    .map(async filename => {
+  await mapLimit(
+    filenames,
+    FILE_READ_LIMIT,
+    async filename => {
       // derive `foo.bar.baz` object key from `foo/bar/baz.yml` filename
       const key = filenameToKey(path.relative(dir, filename))
       const extension = path.extname(filename).toLowerCase()
@@ -62,7 +68,8 @@ module.exports = async function dataDirectory (dir, opts = {}) {
           set(data, key, fileContent)
           break
       }
-    }))
+    }
+  )
 
   return data
 }
diff --git a/lib/pages.js b/lib/pages.js
index 4db70e7dd5..e1d2bec57b 100644
--- a/lib/pages.js
+++ b/lib/pages.js
@@ -3,7 +3,8 @@ const walk = require('walk-sync').entries
 const Page = require('./page')
 const languages = require('./languages')
 const { mapLimit, filterLimit } = require('async')
-const FILE_READ_LIMIT = 500
+
+const FILE_READ_LIMIT = 100
 
 async function loadPageList () {
   const pageList = []

From d9ab8f3b08907b4270b95ef3a1397bf58232faea Mon Sep 17 00:00:00 2001
From: Kevin Heis <heiskr@users.noreply.github.com>
Date: Mon, 14 Dec 2020 08:07:44 -0800
Subject: [PATCH 3/3] In path utils, speed up version lookups (#16915)

---
 lib/path-utils.js | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/lib/path-utils.js b/lib/path-utils.js
index 1dcf9b5433..54845166f9 100644
--- a/lib/path-utils.js
+++ b/lib/path-utils.js
@@ -6,6 +6,8 @@ const allProducts = require('./all-products')
 const allVersions = require('./all-versions')
 const { getNewVersionedPath } = require('./old-versions-utils')
 
+const supportedVersions = new Set(Object.keys(allVersions))
+
 // construct appropriate versioned path for any given HREF
 function getVersionedPathWithoutLanguage (href, version) {
   // start clean without language code or trailing slash
@@ -24,7 +26,7 @@ function getVersionedPathWithoutLanguage (href, version) {
 
   // if the version found is not a currently supported version...
   let productObjectFromPath
-  if (!Object.keys(allVersions).includes(versionFromPath)) {
+  if (!supportedVersions.has(versionFromPath)) {
     // first check if the first segment is instead a current product;
     // example: /admin/foo or /desktop/foo
     productObjectFromPath = allProducts[versionFromPath]