1
0
mirror of synced 2026-01-04 09:06:46 -05:00

log a warning if shielding discards query param keys (#49856)

This commit is contained in:
Robert Sese
2024-03-26 11:48:28 -05:00
committed by GitHub
parent f1c0119849
commit 6913471028

View File

@@ -87,6 +87,11 @@ export default function handleInvalidQuerystrings(req, res, next) {
const badToolsQuery = keys.some((key) => key.startsWith('tool%') && !query[key])
if (keys.length >= MAX_UNFAMILIAR_KEYS_REDIRECT || badKeylessQuery || badToolsQuery) {
if (process.env.NODE_ENV === 'development') {
console.warn(
'Redirecting because of a questionable query string, see https://github.com/github/docs/blob/main/src/shielding/README.md',
)
}
defaultCacheControl(res)
const sp = new URLSearchParams(query)
keys.forEach((key) => sp.delete(key))