From 1ce27538f2c41898691dd5bc62e22c6078365b60 Mon Sep 17 00:00:00 2001 From: Kensuke Nagae Date: Tue, 14 Jun 2022 18:14:59 +0900 Subject: [PATCH] Remove SAML encrypted assertions known issues from 3.4.2 and 3.4.3 (#28468) --- data/release-notes/enterprise-server/3-4/2.yml | 6 ------ data/release-notes/enterprise-server/3-4/3.yml | 6 ------ 2 files changed, 12 deletions(-) diff --git a/data/release-notes/enterprise-server/3-4/2.yml b/data/release-notes/enterprise-server/3-4/2.yml index f3a3aee274..e38ab7cd47 100644 --- a/data/release-notes/enterprise-server/3-4/2.yml +++ b/data/release-notes/enterprise-server/3-4/2.yml @@ -27,12 +27,6 @@ sections: - When "Users can search GitHub.com" is enabled with {% data variables.product.prodname_github_connect %}, issues in private and internal repositories are not included in {% data variables.product.prodname_dotcom_the_website %} search results. - The {% data variables.product.prodname_registry %} npm registry no longer returns a time value in metadata responses. This was done to allow for substantial performance improvements. We continue to have all the data necessary to return a time value as part of the metadata response and will resume returning this value in the future once we have solved the existing performance issues. - Resource limits that are specific to processing pre-receive hooks may cause some pre-receive hooks to fail. - - | - When using SAML encrypted assertions with {% data variables.product.prodname_ghe_server %} 3.4.0 and 3.4.1, a new XML attribute `WantAssertionsEncrypted` in the `SPSSODescriptor` contains an invalid attribute for SAML metadata. IdPs that consume this SAML metadata endpoint may encounter errors when validating the SAML metadata XML schema. A fix will be available in the next patch release. [Updated: 2022-04-11] - - To work around this problem, you can take one of the two following actions. - - Reconfigure the IdP by uploading a static copy of the SAML metadata without the `WantAssertionsEncrypted` attribute. - - Copy the SAML metadata, remove `WantAssertionsEncrypted` attribute, host it on a web server, and reconfigure the IdP to point to that URL. deprecations: - heading: Deprecation of GitHub Enterprise Server 3.0 diff --git a/data/release-notes/enterprise-server/3-4/3.yml b/data/release-notes/enterprise-server/3-4/3.yml index 2ec92d6680..5c409fc4aa 100644 --- a/data/release-notes/enterprise-server/3-4/3.yml +++ b/data/release-notes/enterprise-server/3-4/3.yml @@ -33,9 +33,3 @@ sections: - When "Users can search GitHub.com" is enabled with {% data variables.product.prodname_github_connect %}, issues in private and internal repositories are not included in {% data variables.product.prodname_dotcom_the_website %} search results. - The {% data variables.product.prodname_registry %} npm registry no longer returns a time value in metadata responses. This was done to allow for substantial performance improvements. We continue to have all the data necessary to return a time value as part of the metadata response and will resume returning this value in the future once we have solved the existing performance issues. - Resource limits that are specific to processing pre-receive hooks may cause some pre-receive hooks to fail. - - | - When using SAML encrypted assertions with {% data variables.product.prodname_ghe_server %} 3.4.0 and 3.4.1, a new XML attribute `WantAssertionsEncrypted` in the `SPSSODescriptor` contains an invalid attribute for SAML metadata. IdPs that consume this SAML metadata endpoint may encounter errors when validating the SAML metadata XML schema. A fix will be available in the next patch release. [Updated: 2022-04-11] - - To work around this problem, you can take one of the two following actions. - - Reconfigure the IdP by uploading a static copy of the SAML metadata without the `WantAssertionsEncrypted` attribute. - - Copy the SAML metadata, remove `WantAssertionsEncrypted` attribute, host it on a web server, and reconfigure the IdP to point to that URL.