set FAIL_ON_FLAW to fail link checking (#49444)

.github/workflows/link-check-daily.yml

@@ -75,10 +75,12 @@ jobs:
           # If we're unable to connect or the server returns a 50x error,
           # treat it as a warning and not as a broken link.
           EXTERNAL_SERVER_ERRORS_AS_WARNINGS: true
+          FAIL_ON_FLAW: false
         timeout-minutes: 30
         run: node src/links/scripts/rendered-content-link-checker.js
 
       - name: Upload artifact(s)
+        if: ${{ always() }}
         uses: actions/upload-artifact@c7d193f32edcb7bfad88892161225aeda64e9392
         with:
           name: artifacts

.github/workflows/link-check-on-pr.yml

@@ -48,6 +48,7 @@ jobs:
           # we're filtering on anyway once the list of all pages has
           # been loaded.
           ENABLED_LANGUAGES: en
+          FAIL_ON_FLAW: true
         run: node src/links/scripts/rendered-content-link-checker.js
 
       - name: Upload artifact(s)

src/links/scripts/rendered-content-link-checker.js

@@ -330,9 +330,9 @@ async function main(core, octokit, uploadArtifact, opts = {}) {
         core.setFailed(
           `${flaws.length} broken links found. See action artifact uploads for details`,
         )
+        process.exit(1)
       }
     }
-    process.exit(1)
   } else {
     // It might be that the PR got a comment about >0 flaws before,
     // and now it can update that comment to say all is well again.