jprdonnelly/docs
1
0
Fork 0
mirror of synced 2025-12-19 18:10:59 -05:00
Code Issues Projects Releases Wiki Activity

Enterprise release step bug fixes (#38892)

Browse Source
This commit is contained in:
Rachael Sewell
2023-07-11 09:56:58 -07:00
committed by GitHub
parent 6d607cbe41
commit 6e7b975354
3 changed files with 17 additions and 13 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
src/automated-pipelines/lib/update-markdown.js
View File

@@ -354,7 +354,7 @@ export async function convertVersionsToFrontmatter(versions) {
// This creates an array of the applicable releases in the same
// order as the available releases array. This is used to track when
// a release is no longer supported.
const i = docsVersion.releases.sort().indexOf(docsVersion.currentRelease)
const i = docsVersion.releases.indexOf(docsVersion.currentRelease)
if (!numberedReleases[docsVersion.shortName]) {
const availableReleases = Array(docsVersion.releases.length).fill(undefined)
availableReleases[i] = docsVersion.currentRelease
@@ -384,12 +384,12 @@ export async function convertVersionsToFrontmatter(versions) {
} else {
const semVer = []
if (!availableReleases[availableReleases.length - 1]) {
const endVersion = availableReleases.filter(Boolean).pop()
semVer.push(`<=${endVersion}`)
const startVersion = availableReleases.filter(Boolean).pop()
semVer.push(`>=${startVersion}`)
}
if (!availableReleases[0]) {
const startVersion = availableReleases.filter(Boolean).shift()
semVer.push(`>=${startVersion}`)
const endVersion = availableReleases.filter(Boolean).shift()
semVer.push(`<=${endVersion}`)
}
frontmatterVersions[key] = semVer.join(' ')
}

11
src/automated-pipelines/tests/frontmatter-versions.js
View File

@@ -12,15 +12,12 @@ describe('frontmatter versions are generated correctly from automated data', ()
version !== `enterprise-server@${supported[2]}`,
)
const expectedEneterpriseServerVersions = fromVersions
const expectedEnterpriseServerVersions = fromVersions
.map(
(version) =>
version.includes('enterprise-server@') && version.replace('enterprise-server@', ''),
)
.filter(Boolean)
const expectedEnterpriseServerVersions = expectedEneterpriseServerVersions
.sort()
.map((version) => `=${version}`)
.join(' || ')
@@ -41,7 +38,7 @@ describe('frontmatter versions are generated correctly from automated data', ()
!(version.currentRelease === version.latestRelease && version.hasNumberedReleases),
)
.map((version) => version.version)
const nextLatestRelease = [...supported].sort()[supported.length - 2]
const nextLatestRelease = supported[1]
const expectedVersions = {
fpt: '*',
ghae: '*',
@@ -53,12 +50,12 @@ describe('frontmatter versions are generated correctly from automated data', ()
})
test('greater than the oldest enterprise server version', async () => {
const oldestRelease = [...supported].sort()[0]
const oldestRelease = supported[supported.length - 1]
const fromVersions = Object.values(allVersions)
.filter((version) => !(version.version === `enterprise-server@${oldestRelease}`))
.map((version) => version.version)
const secondOldestRelease = [...supported].sort()[1]
const secondOldestRelease = supported[supported.length - 2]
const expectedVersions = {
fpt: '*',
ghae: '*',