From 4ab81eaab9171a494a05c63a12524bcfc66ce311 Mon Sep 17 00:00:00 2001 From: Courtney Wilson <77312589+cmwilson21@users.noreply.github.com> Date: Fri, 3 Jun 2022 15:51:49 -0500 Subject: [PATCH 1/4] Update PULL_REQUEST_TEMPLATE.md updating some of the phrasing --- .github/PULL_REQUEST_TEMPLATE.md | 20 ++++++++------------ 1 file changed, 8 insertions(+), 12 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 55707831a2..2464f76e66 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,30 +1,25 @@ ### Why: Closes [issue link] - + ### What's being changed: - + ### Check off the following: -- [ ] I have reviewed my changes in staging (look for "Automatically generated comment" and click **Modified** to view your latest changes). +- [ ] I have reviewed my changes in staging (look for "Automatically generated comment" and click the **Preview** links to view your latest changes). - [ ] For content changes, I have completed the [self-review checklist](https://github.com/github/docs/blob/main/contributing/self-review.md#self-review). ### Writer impact (This section is for GitHub staff members only): @@ -34,3 +29,4 @@ Closes [issue link] - [ ] I have added a description and/or a video demo of the changes below (e.g. a "before and after video") + From c98d9e0d93c67b5bf4bb413a7aede5db55d29f74 Mon Sep 17 00:00:00 2001 From: Courtney Wilson <77312589+cmwilson21@users.noreply.github.com> Date: Mon, 6 Jun 2022 16:15:53 -0500 Subject: [PATCH 2/4] Update PULL_REQUEST_TEMPLATE.md first commit cleaning up the template a bit - added notes for further updates. --- .github/PULL_REQUEST_TEMPLATE.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 2464f76e66..6e7e91a9d3 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -2,6 +2,7 @@ Thank you for contributing to this project! You must fill out the information below before we can review this pull request. By explaining why you're making a change (or linking to an issue) and what changes you've made, we can triage your pull request to the best possible team for review. +****take this piece out? If we have a bunch of site policy change request, put it back in. For changes to content in site policy (https://github.com/github/docs/tree/main/content/github/site-policy), see the CONTRIBUTING guide in the site-policy repo (https://github.com/github/site-policy/blob/main/CONTRIBUTING.md). --> @@ -12,10 +13,10 @@ Closes [issue link] -### What's being changed: +### What's being changed (if available, include any code snippets, screenshots, or gifs): +If you made changes to the `content` directory, a table will populate in a comment below with links to the preview and current production article links --> ### Check off the following: From c3e7ed129a03fb44cda728b3694532f38c11560f Mon Sep 17 00:00:00 2001 From: Courtney Wilson <77312589+cmwilson21@users.noreply.github.com> Date: Tue, 7 Jun 2022 10:53:41 -0500 Subject: [PATCH 3/4] Update PULL_REQUEST_TEMPLATE.md removed line about site policy contributions and other small updates --- .github/PULL_REQUEST_TEMPLATE.md | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index 6e7e91a9d3..a3c4ec77a5 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -1,9 +1,5 @@ ### Why: @@ -20,7 +16,7 @@ If you made changes to the `content` directory, a table will populate in a comme ### Check off the following: -- [ ] I have reviewed my changes in staging (look for "Automatically generated comment" and click the **Preview** links to view your latest changes). +- [ ] I have reviewed my changes in staging (look for the "Automatically generated comment" and click the links in the "Preview" column to view your latest changes). - [ ] For content changes, I have completed the [self-review checklist](https://github.com/github/docs/blob/main/contributing/self-review.md#self-review). ### Writer impact (This section is for GitHub staff members only): From b79367c0d5fa8eeb78df30c9b23060319bf80a74 Mon Sep 17 00:00:00 2001 From: Courtney Wilson <77312589+cmwilson21@users.noreply.github.com> Date: Wed, 8 Jun 2022 10:00:51 -0500 Subject: [PATCH 4/4] Update PULL_REQUEST_TEMPLATE.md cleaned up a bit more of the redundant language I accidentally created --- .github/PULL_REQUEST_TEMPLATE.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index a3c4ec77a5..2e92ca7e99 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -11,8 +11,8 @@ If there's _not_ an existing issue, please open one first to make it more likely ### What's being changed (if available, include any code snippets, screenshots, or gifs): - + ### Check off the following: