From e32260a358f7afb942d59fe3151423d50a17b876 Mon Sep 17 00:00:00 2001 From: Peter Bengtsson Date: Thu, 2 Jun 2022 09:51:14 -0400 Subject: [PATCH] Pin to node-version 16.15.0 to get npm 8.5.5 on all runners (#28186) * why is 'npm ci' no longer working * ls * check * check * check3 * ubuntu-latest * debugging more * debugging more * before and after * ubuntu-latest * try upgrading actions/setup-node * pin to exactly 16.15.0 for npm 8.5.5 * node-version 16.15.1 EVERYWHERE * fix cleanup --- .github/workflows/autoupdate-branch.yml | 4 ++-- .github/workflows/azure-prod-build-deploy.yml | 4 ++-- .github/workflows/azure-staging-build-deploy.yml | 4 ++-- .github/workflows/browser-test.yml | 4 ++-- .github/workflows/check-all-english-links.yml | 4 ++-- .github/workflows/check-broken-links-github-github.yml | 4 ++-- .github/workflows/code-lint.yml | 4 ++-- .github/workflows/content-changes-table-comment.yml | 4 ++-- .github/workflows/create-translation-batch-pr.yml | 4 ++-- .github/workflows/crowdin-cleanup.yml | 4 ++-- .github/workflows/docs-review-collect.yml | 4 ++-- .github/workflows/enterprise-dates.yml | 4 ++-- .github/workflows/enterprise-release-sync-search-index.yml | 4 ++-- .github/workflows/link-check-all.yml | 4 ++-- .github/workflows/msft-create-translation-batch-pr.yml | 4 ++-- .github/workflows/open-enterprise-issue.yml | 4 ++-- .github/workflows/openapi-decorate.yml | 4 ++-- .github/workflows/openapi-schema-check.yml | 4 ++-- .github/workflows/orphaned-assets-check.yml | 4 ++-- .github/workflows/os-ready-for-review.yml | 4 ++-- .github/workflows/pa11y.yml | 4 ++-- .github/workflows/package-lock-lint.yml | 4 ++-- .github/workflows/ready-for-doc-review.yml | 4 ++-- .github/workflows/remove-unused-assets.yml | 4 ++-- .github/workflows/repo-sync.yml | 4 ++-- .github/workflows/sync-search-indices.yml | 4 ++-- .github/workflows/sync-search-pr.yml | 4 ++-- .github/workflows/test.yml | 4 ++-- .github/workflows/triage-unallowed-internal-changes.yml | 4 ++-- .github/workflows/update-graphql-files.yml | 4 ++-- 30 files changed, 60 insertions(+), 60 deletions(-) diff --git a/.github/workflows/autoupdate-branch.yml b/.github/workflows/autoupdate-branch.yml index 1a6c0baa5a..9ab9c7eeaa 100644 --- a/.github/workflows/autoupdate-branch.yml +++ b/.github/workflows/autoupdate-branch.yml @@ -43,9 +43,9 @@ jobs: uses: actions/checkout@dcd71f646680f2efd8db4afa5ad64fdcba30e748 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install dependencies diff --git a/.github/workflows/azure-prod-build-deploy.yml b/.github/workflows/azure-prod-build-deploy.yml index e43529dce6..01b50d25a0 100644 --- a/.github/workflows/azure-prod-build-deploy.yml +++ b/.github/workflows/azure-prod-build-deploy.yml @@ -60,9 +60,9 @@ jobs: run: git lfs checkout - name: Setup node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Clone docs-early-access diff --git a/.github/workflows/azure-staging-build-deploy.yml b/.github/workflows/azure-staging-build-deploy.yml index b127eb3bfc..5967fed3bd 100644 --- a/.github/workflows/azure-staging-build-deploy.yml +++ b/.github/workflows/azure-staging-build-deploy.yml @@ -78,9 +78,9 @@ jobs: echo "DOCKER_IMAGE=${{ secrets.NONPROD_REGISTRY_SERVER }}/${{ env.IMAGE_REPO }}:${{ env.COMMIT_REF }}-${{ github.run_number }}-${{ github.run_attempt }}" >> $GITHUB_ENV - name: Setup node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Clone docs-early-access diff --git a/.github/workflows/browser-test.yml b/.github/workflows/browser-test.yml index 8e052579b7..c473fd59b0 100644 --- a/.github/workflows/browser-test.yml +++ b/.github/workflows/browser-test.yml @@ -40,9 +40,9 @@ jobs: run: git lfs checkout - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install dependencies diff --git a/.github/workflows/check-all-english-links.yml b/.github/workflows/check-all-english-links.yml index 36355085ca..d2738c991c 100644 --- a/.github/workflows/check-all-english-links.yml +++ b/.github/workflows/check-all-english-links.yml @@ -28,9 +28,9 @@ jobs: - name: Check out repo's default branch uses: actions/checkout@dcd71f646680f2efd8db4afa5ad64fdcba30e748 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install dependencies diff --git a/.github/workflows/check-broken-links-github-github.yml b/.github/workflows/check-broken-links-github-github.yml index d7273d7b20..8cc3ad0fe1 100644 --- a/.github/workflows/check-broken-links-github-github.yml +++ b/.github/workflows/check-broken-links-github-github.yml @@ -42,9 +42,9 @@ jobs: uses: actions/checkout@dcd71f646680f2efd8db4afa5ad64fdcba30e748 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install Node.js dependencies diff --git a/.github/workflows/code-lint.yml b/.github/workflows/code-lint.yml index 2215aee697..edb183ea35 100644 --- a/.github/workflows/code-lint.yml +++ b/.github/workflows/code-lint.yml @@ -37,9 +37,9 @@ jobs: uses: actions/checkout@dcd71f646680f2efd8db4afa5ad64fdcba30e748 - name: Setup node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install dependencies diff --git a/.github/workflows/content-changes-table-comment.yml b/.github/workflows/content-changes-table-comment.yml index 01ec4d1fcf..5f7a1a988b 100644 --- a/.github/workflows/content-changes-table-comment.yml +++ b/.github/workflows/content-changes-table-comment.yml @@ -57,9 +57,9 @@ jobs: run: .github/actions-scripts/get-preview-app-info.sh - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install temporary dependencies diff --git a/.github/workflows/create-translation-batch-pr.yml b/.github/workflows/create-translation-batch-pr.yml index 7aa85eed4f..3246434e65 100644 --- a/.github/workflows/create-translation-batch-pr.yml +++ b/.github/workflows/create-translation-batch-pr.yml @@ -116,9 +116,9 @@ jobs: git commit -m "Add crowdin translations" || echo "Nothing to commit" - name: 'Setup node' - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' - run: npm ci diff --git a/.github/workflows/crowdin-cleanup.yml b/.github/workflows/crowdin-cleanup.yml index 2912c1cdff..0613a489c0 100644 --- a/.github/workflows/crowdin-cleanup.yml +++ b/.github/workflows/crowdin-cleanup.yml @@ -29,9 +29,9 @@ jobs: uses: actions/checkout@dcd71f646680f2efd8db4afa5ad64fdcba30e748 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install dependencies diff --git a/.github/workflows/docs-review-collect.yml b/.github/workflows/docs-review-collect.yml index cb8883b79b..fa940213fd 100644 --- a/.github/workflows/docs-review-collect.yml +++ b/.github/workflows/docs-review-collect.yml @@ -23,9 +23,9 @@ jobs: uses: actions/checkout@dcd71f646680f2efd8db4afa5ad64fdcba30e748 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install dependencies diff --git a/.github/workflows/enterprise-dates.yml b/.github/workflows/enterprise-dates.yml index 330a0ae1ef..8114dc0fac 100644 --- a/.github/workflows/enterprise-dates.yml +++ b/.github/workflows/enterprise-dates.yml @@ -39,9 +39,9 @@ jobs: uses: actions/checkout@dcd71f646680f2efd8db4afa5ad64fdcba30e748 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install Node.js dependencies diff --git a/.github/workflows/enterprise-release-sync-search-index.yml b/.github/workflows/enterprise-release-sync-search-index.yml index 5b7cd035dc..238b4f3ed1 100644 --- a/.github/workflows/enterprise-release-sync-search-index.yml +++ b/.github/workflows/enterprise-release-sync-search-index.yml @@ -50,9 +50,9 @@ jobs: token: ${{ secrets.DOCUBOT_REPO_PAT }} - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install dependencies diff --git a/.github/workflows/link-check-all.yml b/.github/workflows/link-check-all.yml index 8e273bede3..c8fa5c9075 100644 --- a/.github/workflows/link-check-all.yml +++ b/.github/workflows/link-check-all.yml @@ -30,9 +30,9 @@ jobs: uses: actions/checkout@dcd71f646680f2efd8db4afa5ad64fdcba30e748 - name: Setup node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install diff --git a/.github/workflows/msft-create-translation-batch-pr.yml b/.github/workflows/msft-create-translation-batch-pr.yml index a50bf0f8f7..0bb8bc5c70 100644 --- a/.github/workflows/msft-create-translation-batch-pr.yml +++ b/.github/workflows/msft-create-translation-batch-pr.yml @@ -95,9 +95,9 @@ jobs: git commit -m "Add crowdin translations" || echo "Nothing to commit" - name: 'Setup node' - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' - run: npm ci diff --git a/.github/workflows/open-enterprise-issue.yml b/.github/workflows/open-enterprise-issue.yml index 174ac7a438..37bf449fe5 100644 --- a/.github/workflows/open-enterprise-issue.yml +++ b/.github/workflows/open-enterprise-issue.yml @@ -22,9 +22,9 @@ jobs: uses: actions/checkout@dcd71f646680f2efd8db4afa5ad64fdcba30e748 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install dependencies diff --git a/.github/workflows/openapi-decorate.yml b/.github/workflows/openapi-decorate.yml index e803204c0c..fd97b27545 100644 --- a/.github/workflows/openapi-decorate.yml +++ b/.github/workflows/openapi-decorate.yml @@ -42,9 +42,9 @@ jobs: token: ${{ secrets.DOCUBOT_REPO_PAT }} - name: Setup node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install dependencies diff --git a/.github/workflows/openapi-schema-check.yml b/.github/workflows/openapi-schema-check.yml index 12a59b3db8..3134575719 100644 --- a/.github/workflows/openapi-schema-check.yml +++ b/.github/workflows/openapi-schema-check.yml @@ -42,9 +42,9 @@ jobs: uses: actions/checkout@dcd71f646680f2efd8db4afa5ad64fdcba30e748 - name: Setup node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install dependencies diff --git a/.github/workflows/orphaned-assets-check.yml b/.github/workflows/orphaned-assets-check.yml index b546f867de..367e0f93c6 100644 --- a/.github/workflows/orphaned-assets-check.yml +++ b/.github/workflows/orphaned-assets-check.yml @@ -25,9 +25,9 @@ jobs: token: ${{ secrets.DOCUBOT_REPO_PAT }} - name: Setup node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install diff --git a/.github/workflows/os-ready-for-review.yml b/.github/workflows/os-ready-for-review.yml index 5c336a47e7..18fb56f88d 100644 --- a/.github/workflows/os-ready-for-review.yml +++ b/.github/workflows/os-ready-for-review.yml @@ -47,9 +47,9 @@ jobs: uses: actions/checkout@dcd71f646680f2efd8db4afa5ad64fdcba30e748 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install dependencies diff --git a/.github/workflows/pa11y.yml b/.github/workflows/pa11y.yml index b8b4961b61..79be4845c4 100644 --- a/.github/workflows/pa11y.yml +++ b/.github/workflows/pa11y.yml @@ -21,9 +21,9 @@ jobs: uses: actions/checkout@dcd71f646680f2efd8db4afa5ad64fdcba30e748 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install dependencies diff --git a/.github/workflows/package-lock-lint.yml b/.github/workflows/package-lock-lint.yml index ed400d05bf..e2baf6b564 100644 --- a/.github/workflows/package-lock-lint.yml +++ b/.github/workflows/package-lock-lint.yml @@ -27,9 +27,9 @@ jobs: uses: actions/checkout@dcd71f646680f2efd8db4afa5ad64fdcba30e748 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' - name: Run check run: | diff --git a/.github/workflows/ready-for-doc-review.yml b/.github/workflows/ready-for-doc-review.yml index 4fa906cdb6..2a2d3df1eb 100644 --- a/.github/workflows/ready-for-doc-review.yml +++ b/.github/workflows/ready-for-doc-review.yml @@ -23,9 +23,9 @@ jobs: uses: actions/checkout@dcd71f646680f2efd8db4afa5ad64fdcba30e748 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install dependencies diff --git a/.github/workflows/remove-unused-assets.yml b/.github/workflows/remove-unused-assets.yml index e966727b9a..f4524dba54 100644 --- a/.github/workflows/remove-unused-assets.yml +++ b/.github/workflows/remove-unused-assets.yml @@ -27,9 +27,9 @@ jobs: - name: Checkout uses: actions/checkout@dcd71f646680f2efd8db4afa5ad64fdcba30e748 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: npm ci run: npm ci diff --git a/.github/workflows/repo-sync.yml b/.github/workflows/repo-sync.yml index 1d4910a640..ea5a074de5 100644 --- a/.github/workflows/repo-sync.yml +++ b/.github/workflows/repo-sync.yml @@ -102,9 +102,9 @@ jobs: # Set up npm and run npm ci to run husky to get githooks for LFS - name: Setup node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install dependencies run: npm ci diff --git a/.github/workflows/sync-search-indices.yml b/.github/workflows/sync-search-indices.yml index 51e0975f74..6257c0e3a5 100644 --- a/.github/workflows/sync-search-indices.yml +++ b/.github/workflows/sync-search-indices.yml @@ -56,9 +56,9 @@ jobs: token: ${{ secrets.DOCS_BOT_FR }} - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install dependencies diff --git a/.github/workflows/sync-search-pr.yml b/.github/workflows/sync-search-pr.yml index eb867b341c..9a4b399871 100644 --- a/.github/workflows/sync-search-pr.yml +++ b/.github/workflows/sync-search-pr.yml @@ -29,9 +29,9 @@ jobs: uses: actions/checkout@dcd71f646680f2efd8db4afa5ad64fdcba30e748 - name: Setup node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install dependencies diff --git a/.github/workflows/test.yml b/.github/workflows/test.yml index cc146ee909..7bd2619fa3 100644 --- a/.github/workflows/test.yml +++ b/.github/workflows/test.yml @@ -123,9 +123,9 @@ jobs: echo "${{ steps.get_diff_files.outputs.files }}" > get_diff_files.txt - name: Setup node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install dependencies diff --git a/.github/workflows/triage-unallowed-internal-changes.yml b/.github/workflows/triage-unallowed-internal-changes.yml index 498866d74e..45bc281c32 100644 --- a/.github/workflows/triage-unallowed-internal-changes.yml +++ b/.github/workflows/triage-unallowed-internal-changes.yml @@ -59,9 +59,9 @@ jobs: token: ${{ secrets.DOCUBOT_REPO_PAT }} - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install dependencies diff --git a/.github/workflows/update-graphql-files.yml b/.github/workflows/update-graphql-files.yml index 900dfe74f4..0383ff3598 100644 --- a/.github/workflows/update-graphql-files.yml +++ b/.github/workflows/update-graphql-files.yml @@ -34,9 +34,9 @@ jobs: - name: Checkout uses: actions/checkout@dcd71f646680f2efd8db4afa5ad64fdcba30e748 - name: Setup Node - uses: actions/setup-node@1f8c6b94b26d0feae1e387ca63ccbdc44d27b561 + uses: actions/setup-node@17f8bd926464a1afa4c6a11669539e9c1ba77048 with: - node-version: 16.15.x + node-version: '16.15.0' cache: npm - name: Install Node.js dependencies run: npm ci