jprdonnelly/docs
1
0
Fork 0
mirror of synced 2025-12-22 03:16:52 -05:00
Code Issues Projects Releases Wiki Activity

Make the HEROKU_PRODUCTION_APP_NAME env var required for prod deployment (#21910)

Browse Source
This commit is contained in:
James M. Greene
2021-10-06 11:53:28 -05:00
committed by GitHub
parent 47f3eb42ec
commit 8771695531
2 changed files with 5 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
script/deploy.js
View File

@@ -158,11 +158,9 @@ async function deployProduction() {
const { HEROKU_PRODUCTION_APP_NAME, DOCUBOT_REPO_PAT, FASTLY_TOKEN, FASTLY_SERVICE_ID } = const { HEROKU_PRODUCTION_APP_NAME, DOCUBOT_REPO_PAT, FASTLY_TOKEN, FASTLY_SERVICE_ID } =
process.env process.env
// Warn if Heroku App name is not found // Exit if Heroku App name is not found
if (!HEROKU_PRODUCTION_APP_NAME) { if (!HEROKU_PRODUCTION_APP_NAME) {
console.warn( throw new Error('You must supply a HEROKU_PRODUCTION_APP_NAME environment variable!')
'⚠️ You did not supply a HEROKU_PRODUCTION_APP_NAME environment variable.\nWithout it, this deployment will not end up in our production environment!'
)
} }
// Warn if @docubot PAT is not found // Warn if @docubot PAT is not found

13
script/deployment/deploy-to-production.js
View File

@@ -64,16 +64,9 @@ export default async function deployToProduction({
let deploymentId = null let deploymentId = null
let logUrl = workflowRunLog let logUrl = workflowRunLog
let appName, environment, homepageUrl const appName = process.env.HEROKU_PRODUCTION_APP_NAME
if (process.env.HEROKU_PRODUCTION_APP_NAME) { const environment = 'production'
appName = process.env.HEROKU_PRODUCTION_APP_NAME const homepageUrl = 'https://docs.github.com/'
environment = 'production'
homepageUrl = 'https://docs.github.com/'
} else {
appName = 'help-docs-prod-gha'
environment = appName
homepageUrl = `https://${appName}.herokuapp.com/`
}
try { try {
const title = `branch '${branch}' at commit '${sha}' in the '${environment}' environment` const title = `branch '${branch}' at commit '${sha}' in the '${environment}' environment`