1
0
mirror of synced 2025-12-21 10:57:10 -05:00

Rename GitHub product (#20347)

This commit is contained in:
Laura Coursen
2021-07-21 06:22:30 -05:00
committed by GitHub
parent 1ab86dc933
commit 88dd272f29
5 changed files with 14 additions and 15 deletions

View File

@@ -1,5 +1,5 @@
---
title: GitHub.com
title: GitHub
redirect_from:
- /articles/
- /common-issues-and-questions/

View File

@@ -20,7 +20,7 @@ describe('breadcrumbs', () => {
const $breadcrumbs = $('.breadcrumbs a')
expect($breadcrumbs).toHaveLength(4)
expect($breadcrumbs[0].attribs.title).toBe('product: GitHub.com')
expect($breadcrumbs[0].attribs.title).toBe('product: GitHub')
expect($breadcrumbs[1].attribs.title).toBe('category: Authentication')
expect($breadcrumbs[2].attribs.title).toBe('mapTopic: Troubleshooting SSH')
expect($breadcrumbs[3].attribs.title).toBe('article: Use SSH over HTTPS port')
@@ -33,7 +33,7 @@ describe('breadcrumbs', () => {
const $breadcrumbs = $('.breadcrumbs a')
expect($breadcrumbs).toHaveLength(3)
expect($breadcrumbs[0].attribs.title).toBe('product: GitHub.com')
expect($breadcrumbs[0].attribs.title).toBe('product: GitHub')
expect($breadcrumbs[1].attribs.title).toBe('category: Authentication')
expect($breadcrumbs[2].attribs.title).toBe('mapTopic: Account security')
expect($breadcrumbs[2].attribs.class.includes('color-text-tertiary')).toBe(true)
@@ -45,8 +45,7 @@ describe('breadcrumbs', () => {
)
const $breadcrumbs = $('.breadcrumbs a')
expect($breadcrumbs).toHaveLength(4)
// The product is still GitHub.com on an Enterprise Server version
expect($breadcrumbs[0].attribs.title).toBe('product: GitHub.com')
expect($breadcrumbs[0].attribs.title).toBe('product: GitHub')
})
test('parses Liquid variables inside titles', async () => {
@@ -85,7 +84,7 @@ describe('breadcrumbs', () => {
expect($breadcrumbSpans).toHaveLength(2)
expect($breadcrumbLinks).toHaveLength(2)
expect($breadcrumbSpans[0].children[0].data).toBe('Early Access documentation')
expect($breadcrumbSpans[1].children[0].data).toBe('GitHub.com')
expect($breadcrumbSpans[1].children[0].data).toBe('GitHub')
expect($breadcrumbLinks[0].attribs.title).toBe(
'category: Enforcing best practices with GitHub Policies'
)
@@ -101,7 +100,7 @@ describe('breadcrumbs', () => {
{
documentType: 'product',
href: '/en/github',
title: 'GitHub.com',
title: 'GitHub',
},
]
expect(breadcrumbs).toEqual(expected)
@@ -113,7 +112,7 @@ describe('breadcrumbs', () => {
{
documentType: 'product',
href: '/en/github',
title: 'GitHub.com',
title: 'GitHub',
},
{
documentType: 'category',
@@ -132,7 +131,7 @@ describe('breadcrumbs', () => {
{
documentType: 'product',
href: '/en/github',
title: 'GitHub.com',
title: 'GitHub',
},
{
documentType: 'category',
@@ -156,7 +155,7 @@ describe('breadcrumbs', () => {
{
documentType: 'product',
href: '/en/github',
title: 'GitHub.com',
title: 'GitHub',
},
{
documentType: 'category',
@@ -185,7 +184,7 @@ describe('breadcrumbs', () => {
{
documentType: 'product',
href: '/en/github',
title: 'GitHub.com',
title: 'GitHub',
},
{
documentType: 'category',

View File

@@ -130,7 +130,7 @@ describe('header', () => {
const $ = await getDOM('/en/articles/enabling-required-status-checks')
const github = $('#homepages a.active[href="/en/github"]')
expect(github.length).toBe(1)
expect(github.text().trim()).toBe('GitHub.com')
expect(github.text().trim()).toBe('GitHub')
expect(github.attr('class').includes('active')).toBe(true)
const ghe = $(`#homepages a[href="/en/enterprise-server@${latest}/admin"]`)

View File

@@ -23,7 +23,7 @@ describe('sidebar', () => {
test('highlights active product on GitHub pages', async () => {
expect($githubPage('.sidebar-products li.sidebar-product').length).toBe(1)
expect($githubPage('.sidebar-products li.sidebar-product > a').text().trim()).toBe('GitHub.com')
expect($githubPage('.sidebar-products li.sidebar-product > a').text().trim()).toBe('GitHub')
})
test('includes links to external products like the CLI, Atom, Electron, and CodeQL', async () => {

View File

@@ -25,7 +25,7 @@ describe('products module', () => {
describe('mobile-only products nav', () => {
test('renders current product on various product pages for each product', async () => {
// Note the unversioned homepage at `/` does not have a product selected in the mobile dropdown
expect((await getDOM('/github'))('#current-product').text().trim()).toBe('GitHub.com')
expect((await getDOM('/github'))('#current-product').text().trim()).toBe('GitHub')
// Enterprise server
expect((await getDOM('/en/enterprise/admin'))('#current-product').text().trim()).toBe(
@@ -39,7 +39,7 @@ describe('mobile-only products nav', () => {
)('#current-product')
.text()
.trim()
).toBe('GitHub.com')
).toBe('GitHub')
expect((await getDOM('/desktop'))('#current-product').text().trim()).toBe('GitHub Desktop')