jprdonnelly/docs
1
0
Fork 0
mirror of synced 2025-12-25 02:17:36 -05:00
Code Issues Projects Releases Wiki Activity

End AB test on moving helpfulness prompt to bottom (#16552)

Browse Source 
* End AB test on moving helpfulness prompt to bottom

* Move helpfulness to bottom of page only

* Update helpfulness.js

Co-authored-by: Chiedo John <2156688+chiedo@users.noreply.github.com>
This commit is contained in:
Kevin Heis
2020-11-20 12:24:33 -08:00
committed by GitHub
parent da4559517c
commit 912ac50034
5 changed files with 24 additions and 56 deletions
Download Patch File Download Diff File Expand all files Collapse all files

24
includes/helpfulness.html
View File

@@ -1,5 +1,5 @@
{% unless enterpriseServerReleases.isOldestReleaseDeprecated and currentVersion contains enterpriseServerReleases.oldestSupported %}
<form class="js-helpfulness mt-4 f5" id="helpfulness-{{ helpId }}">
<form class="js-helpfulness mt-4 f5">
<h4
data-help-start
data-help-yes
@@ -19,24 +19,24 @@
>
<input
hidden
id="helpfulness-yes-{{ helpId }}"
id="helpfulness-yes"
type="radio"
name="helpfulness-vote"
value="Yes"
aria-label="{% data ui.helpfulness.yes %}"
/>
<label class="btn x-radio-label" for="helpfulness-yes-{{ helpId }}">
<label class="btn x-radio-label" for="helpfulness-yes">
{% octicon "thumbsup" height="24" %}
</label>
<input
hidden
id="helpfulness-no-{{ helpId }}"
id="helpfulness-no"
type="radio"
name="helpfulness-vote"
value="No"
aria-label="{% data ui.helpfulness.no %}"
/>
<label class="btn x-radio-label" for="helpfulness-no-{{ helpId }}">
<label class="btn x-radio-label" for="helpfulness-no">
{% octicon "thumbsdown" height="24" %}
</label>
</p>
@@ -55,7 +55,7 @@
<p hidden data-help-no>
<label
class="d-block mb-1 f6"
for="helpfulness-category-{{ helpId }}"
for="helpfulness-category"
>
{% data ui.helpfulness.category_label %}
<span class="text-normal text-gray-light float-right ml-1">
@@ -65,7 +65,7 @@
<select
class="form-control select-sm width-full"
name="helpfulness-category"
id="helpfulness-category-{{ helpId }}"
id="helpfulness-category"
>
<option value="">
{% data ui.helpfulness.category_default %}
@@ -87,7 +87,7 @@
<p hidden data-help-no>
<label
class="d-block mb-1 f6"
for="helpfulness-comment-{{ helpId }}"
for="helpfulness-comment"
>
<span>{% data ui.helpfulness.comment_label %}</span>
<span class="text-normal text-gray-light float-right ml-1">
@@ -97,13 +97,13 @@
<textarea
class="form-control input-sm width-full"
name="helpfulness-comment"
id="helpfulness-comment-{{ helpId }}"
id="helpfulness-comment"
></textarea>
</p>
<p>
<label
class="d-block mb-1 f6"
for="helpfulness-email-{{ helpId }}"
for="helpfulness-email"
hidden
data-help-no
>
@@ -116,7 +116,7 @@
type="email"
class="form-control input-sm width-full"
name="helpfulness-email"
id="helpfulness-email-{{ helpId }}"
id="helpfulness-email"
placeholder="{% data ui.helpfulness.email_placeholder %}"
hidden
data-help-yes
@@ -137,4 +137,4 @@
{% data ui.helpfulness.feedback %}
</p>
</form>
{% endunless %}
{% endunless %}