From 9574c7c2d83dea367452db5a49783328f1b26705 Mon Sep 17 00:00:00 2001 From: Robert Sese <734194+rsese@users.noreply.github.com> Date: Thu, 21 Aug 2025 16:35:23 -0500 Subject: [PATCH] set `--no-experimental-strip-types` node option (#57226) --- .github/workflows/headless-tests.yml | 3 +++ .github/workflows/local-dev.yml | 2 ++ Dockerfile | 2 +- package-lock.json | 2 +- package.json | 2 +- 5 files changed, 8 insertions(+), 3 deletions(-) diff --git a/.github/workflows/headless-tests.yml b/.github/workflows/headless-tests.yml index 01d35526fb..5c1ced60b3 100644 --- a/.github/workflows/headless-tests.yml +++ b/.github/workflows/headless-tests.yml @@ -57,6 +57,9 @@ jobs: - name: Run Playwright tests env: PLAYWRIGHT_WORKERS: ${{ fromJSON('[1, 4]')[github.repository == 'github/docs-internal'] }} + # workaround for https://github.com/nodejs/node/issues/59364 as of 22.18.0 + NODE_OPTIONS: '--no-experimental-strip-types' + # Run playwright rendering tests and a11y tests (axe scans) as distinct checks # so that we can run them without blocking merges until we can be confident # results for a11y tests are meaningul and scenarios we're testing are correct. diff --git a/.github/workflows/local-dev.yml b/.github/workflows/local-dev.yml index e706c212b1..55acf15eaf 100644 --- a/.github/workflows/local-dev.yml +++ b/.github/workflows/local-dev.yml @@ -50,6 +50,8 @@ jobs: # by default failures are marked as "flaky" instead of "failed". PLAYWRIGHT_RETRIES: 0 TEST_EARLY_ACCESS: ${{ github.repository == 'github/docs-internal' }} + # workaround for https://github.com/nodejs/node/issues/59364 as of 22.18.0 + NODE_OPTIONS: '--no-experimental-strip-types' run: npm run playwright-test -- playwright-local-dev - name: Start server in the background diff --git a/Dockerfile b/Dockerfile index 4fdcedbace..5a8c618aae 100644 --- a/Dockerfile +++ b/Dockerfile @@ -18,7 +18,7 @@ FROM ghcr.io/github/gh-base-image/gh-base-noble:20250805-204228-g50c20871f AS ba # Must run as root RUN apt-get -qq update && apt-get -qq install --no-install-recommends curl git \ && curl -sL https://deb.nodesource.com/setup_22.x | bash - \ - && apt-get install -y nodejs=22.17.0-1nodesource1 \ + && apt-get install -y nodejs \ && node --version # Create the node user and home directory diff --git a/package-lock.json b/package-lock.json index c18dccfcee..a56d076799 100644 --- a/package-lock.json +++ b/package-lock.json @@ -175,7 +175,7 @@ "website-scraper": "^5.3.1" }, "engines": { - "node": "^20 || >=22.0.0 <22.18.0" + "node": "^20 || ^22" }, "optionalDependencies": { "esm": "^3.2.25" diff --git a/package.json b/package.json index 4ef3a13984..675f556ac2 100644 --- a/package.json +++ b/package.json @@ -328,7 +328,7 @@ "esm": "^3.2.25" }, "engines": { - "node": "^20 || >=22.0.0 <22.18.0" + "node": "^20 || ^22" }, "cacheDirectories": [ "node_modules",