Bump commander from 11.1.0 to 12.0.0 (#49068)

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Peter Bengtsson <mail@peterbe.com>

.github/workflows/move-content.yml

@@ -11,6 +11,10 @@ on:
       - src/content-render/scripts/test-move-content.ts
       - 'src/frame/lib/**/*.js'
       - .github/workflows/move-content.yml
+      # In case any of the dependencies affect the script
+      - 'package*.json'
+      - src/fixtures/fixtures/content/get-started/
+      - src/fixtures/fixtures/content/code-security/
 
 permissions:
   contents: read
@@ -38,12 +42,12 @@ jobs:
           ROOT: src/fixtures/fixtures
         run: |
           npm run move-content -- \
-            src/fixtures/fixtures/content/get-started/quickstart/hello-world.md \
-            src/fixtures/fixtures/content/get-started/quickstart/hello-wurld.md
+            src/fixtures/fixtures/content/get-started/start-your-journey/hello-world.md \
+            src/fixtures/fixtures/content/get-started/start-your-journey/hello-wurld.md
 
           npm run test-moved-content -- \
-            src/fixtures/fixtures/content/get-started/quickstart/hello-world.md \
-            src/fixtures/fixtures/content/get-started/quickstart/hello-wurld.md
+            src/fixtures/fixtures/content/get-started/start-your-journey/hello-world.md \
+            src/fixtures/fixtures/content/get-started/start-your-journey/hello-wurld.md
 
           # TODO: Add tests that inspects the git log
           git log | head -n 100

.github/workflows/orphaned-assets-check.yml

@@ -8,6 +8,16 @@ on:
   workflow_dispatch:
   schedule:
     - cron: '20 16 * * 1' # Run every Monday at 16:20 UTC / 8:20 PST
+  pull_request:
+    paths:
+      - .github/workflows/orphaned-assets-check.yml
+      # In case any of the dependencies affect the script
+      - 'package*.json'
+      - src/assets/scripts/find-orphaned-assets.js
+      - src/workflows/walk-files.js
+      - src/languages/lib/languages.js
+      - .github/actions/clone-translations/action.yml
+      - .github/actions/node-npm-setup/action.yml
 
 permissions:
   contents: read
@@ -38,6 +48,7 @@ jobs:
         env:
           # Needed for gh
           GITHUB_TOKEN: ${{ secrets.DOCS_BOT_PAT_READPUBLICKEY }}
+          DRY_RUN: ${{ github.event_name == 'pull_request'}}
         run: |
           set -e
 
@@ -53,6 +64,13 @@ jobs:
           # If nothing to commit, exit now. It's fine. No orphans.
           git status -- ':!translations*' | grep 'nothing to commit' && exit 0
 
+          # When run on a pull_request, we're just testing the tooling.
+          # Exit before it actually pushes the possible changes.
+          if [ "$DRY_RUN" = "true" ]; then
+            echo "Dry-run mode when run in a pull request"
+            exit 0
+          fi
+
           # Replicated from the translation pipeline PR-maker Action
           git config --global user.name "docs-bot"
           git config --global user.email "77750099+docs-bot@users.noreply.github.com"
@@ -82,7 +100,7 @@ jobs:
             --label docs-content-fr
 
       - uses: ./.github/actions/slack-alert
-        if: ${{ failure() && github.event_name != 'workflow_dispatch' }}
+        if: ${{ failure() && github.event_name == 'schedule' }}
         with:
           slack_channel_id: ${{ secrets.DOCS_ALERTS_SLACK_CHANNEL_ID }}
           slack_token: ${{ secrets.SLACK_DOCS_BOT_TOKEN }}

package-lock.json

@@ -113,7 +113,7 @@
         "@typescript-eslint/parser": "6.17.0",
         "chalk": "^5.0.1",
         "change-case": "^5.0.2",
-        "commander": "^11.0.0",
+        "commander": "^12.0.0",
         "cross-env": "^7.0.3",
         "csp-parse": "0.0.2",
         "dedent": "^1.0.1",
@@ -5039,12 +5039,12 @@
       }
     },
     "node_modules/commander": {
-      "version": "11.1.0",
-      "resolved": "https://registry.npmjs.org/commander/-/commander-11.1.0.tgz",
-      "integrity": "sha512-yPVavfyCcRhmorC7rWlkHn15b4wDVgVmBA7kV4QVBsF7kv/9TKJAbAXVTxvTnwP8HHKjRCJDClKbciiYS7p0DQ==",
+      "version": "12.0.0",
+      "resolved": "https://registry.npmjs.org/commander/-/commander-12.0.0.tgz",
+      "integrity": "sha512-MwVNWlYjDTtOjX5PiD7o5pK0UrFU/OYgcJfjjK4RaHZETNtjJqrZa9Y9ds88+A+f+d5lv+561eZ+yCKoS3gbAA==",
       "dev": true,
       "engines": {
-        "node": ">=16"
+        "node": ">=18"
       }
     },
     "node_modules/compute-gcd": {
@@ -10156,6 +10156,15 @@
         "url": "https://opencollective.com/lint-staged"
       }
     },
+    "node_modules/lint-staged/node_modules/commander": {
+      "version": "11.1.0",
+      "resolved": "https://registry.npmjs.org/commander/-/commander-11.1.0.tgz",
+      "integrity": "sha512-yPVavfyCcRhmorC7rWlkHn15b4wDVgVmBA7kV4QVBsF7kv/9TKJAbAXVTxvTnwP8HHKjRCJDClKbciiYS7p0DQ==",
+      "dev": true,
+      "engines": {
+        "node": ">=16"
+      }
+    },
     "node_modules/lint-staged/node_modules/execa": {
       "version": "8.0.1",
       "resolved": "https://registry.npmjs.org/execa/-/execa-8.0.1.tgz",

package.json

@@ -334,7 +334,7 @@
     "@typescript-eslint/parser": "6.17.0",
     "chalk": "^5.0.1",
     "change-case": "^5.0.2",
-    "commander": "^11.0.0",
+    "commander": "^12.0.0",
     "cross-env": "^7.0.3",
     "csp-parse": "0.0.2",
     "dedent": "^1.0.1",