From e5522b80c03bc56085e6c2369524353b3dbdb42f Mon Sep 17 00:00:00 2001 From: Philippe Berthonneau <52540205+pberthonneau@users.noreply.github.com> Date: Thu, 4 Nov 2021 19:21:15 +0100 Subject: [PATCH 1/5] add anchor to link the list of supported secrets --- content/code-security/secret-scanning/about-secret-scanning.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/content/code-security/secret-scanning/about-secret-scanning.md b/content/code-security/secret-scanning/about-secret-scanning.md index 27a730e089..c4e2125e40 100644 --- a/content/code-security/secret-scanning/about-secret-scanning.md +++ b/content/code-security/secret-scanning/about-secret-scanning.md @@ -71,6 +71,8 @@ Repository administrators and organization owners can grant users and teams acce {% ifversion fpt or ghes > 3.0 or ghec %} To monitor results from {% data variables.product.prodname_secret_scanning %} across your private repositories or your organization, you can use the {% data variables.product.prodname_secret_scanning %} API. For more information about API endpoints, see "[{% data variables.product.prodname_secret_scanning_caps %}](/rest/reference/secret-scanning)."{% endif %} +## List of supported secrets + {% data variables.product.prodname_dotcom %} currently scans{% ifversion fpt or ghec %} private{% endif %} repositories for secrets issued by the following service providers. {% data reusables.secret-scanning.partner-secret-list-private-repo %} From 3e9d332470df3ab953f959fe82b1f259f58e4a37 Mon Sep 17 00:00:00 2001 From: mc <42146119+mchammer01@users.noreply.github.com> Date: Wed, 10 Nov 2021 11:27:51 +0000 Subject: [PATCH 2/5] Update about-secret-scanning.md --- content/code-security/secret-scanning/about-secret-scanning.md | 2 ++ 1 file changed, 2 insertions(+) diff --git a/content/code-security/secret-scanning/about-secret-scanning.md b/content/code-security/secret-scanning/about-secret-scanning.md index c4e2125e40..64d31615bb 100644 --- a/content/code-security/secret-scanning/about-secret-scanning.md +++ b/content/code-security/secret-scanning/about-secret-scanning.md @@ -36,6 +36,8 @@ If your project communicates with an external service, you might use a token or When {% data variables.product.prodname_secret_scanning %} detects a set of credentials, we notify the service provider who issued the secret. The service provider validates the credential and then decides whether they should revoke the secret, issue a new secret, or reach out to you directly, which will depend on the associated risks to you or the service provider. For an overview of how we work with token-issuing partners, see "[Secret scanning partner program](/developers/overview/secret-scanning-partner-program)." +### List of supported secrets + {% data variables.product.product_name %} currently scans public repositories for secrets issued by the following service providers. {% data reusables.secret-scanning.partner-secret-list-public-repo %} From 8c9e79596f6ccfebbb69d00b0c8c288cc32f7f2b Mon Sep 17 00:00:00 2001 From: mc <42146119+mchammer01@users.noreply.github.com> Date: Wed, 10 Nov 2021 11:31:50 +0000 Subject: [PATCH 3/5] Update content/code-security/secret-scanning/about-secret-scanning.md --- .../code-security/secret-scanning/about-secret-scanning.md | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/content/code-security/secret-scanning/about-secret-scanning.md b/content/code-security/secret-scanning/about-secret-scanning.md index 64d31615bb..6788ccf099 100644 --- a/content/code-security/secret-scanning/about-secret-scanning.md +++ b/content/code-security/secret-scanning/about-secret-scanning.md @@ -73,7 +73,10 @@ Repository administrators and organization owners can grant users and teams acce {% ifversion fpt or ghes > 3.0 or ghec %} To monitor results from {% data variables.product.prodname_secret_scanning %} across your private repositories or your organization, you can use the {% data variables.product.prodname_secret_scanning %} API. For more information about API endpoints, see "[{% data variables.product.prodname_secret_scanning_caps %}](/rest/reference/secret-scanning)."{% endif %} -## List of supported secrets +{% ifversion ghes or ghae %} +## List of supported secrets{% else %} +### List of supported secrets +{% endif %} {% data variables.product.prodname_dotcom %} currently scans{% ifversion fpt or ghec %} private{% endif %} repositories for secrets issued by the following service providers. From b263d2d1caac4b5904a68ac8299eabc59c1334f4 Mon Sep 17 00:00:00 2001 From: mc <42146119+mchammer01@users.noreply.github.com> Date: Wed, 10 Nov 2021 12:03:39 +0000 Subject: [PATCH 4/5] Apply suggestions from code review --- .../code-security/secret-scanning/about-secret-scanning.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/code-security/secret-scanning/about-secret-scanning.md b/content/code-security/secret-scanning/about-secret-scanning.md index 6788ccf099..d2d07238f4 100644 --- a/content/code-security/secret-scanning/about-secret-scanning.md +++ b/content/code-security/secret-scanning/about-secret-scanning.md @@ -36,7 +36,7 @@ If your project communicates with an external service, you might use a token or When {% data variables.product.prodname_secret_scanning %} detects a set of credentials, we notify the service provider who issued the secret. The service provider validates the credential and then decides whether they should revoke the secret, issue a new secret, or reach out to you directly, which will depend on the associated risks to you or the service provider. For an overview of how we work with token-issuing partners, see "[Secret scanning partner program](/developers/overview/secret-scanning-partner-program)." -### List of supported secrets +### List of supported secrets for public repositories {% data variables.product.product_name %} currently scans public repositories for secrets issued by the following service providers. @@ -75,7 +75,7 @@ To monitor results from {% data variables.product.prodname_secret_scanning %} ac {% ifversion ghes or ghae %} ## List of supported secrets{% else %} -### List of supported secrets +### List of supported secrets for private repositories {% endif %} {% data variables.product.prodname_dotcom %} currently scans{% ifversion fpt or ghec %} private{% endif %} repositories for secrets issued by the following service providers. From e2434125119f31e3a7a33b91579409e2d9d52741 Mon Sep 17 00:00:00 2001 From: mc <42146119+mchammer01@users.noreply.github.com> Date: Wed, 10 Nov 2021 12:12:55 +0000 Subject: [PATCH 5/5] Adding frontmatter item to show H3 levels in mini-ToC --- content/code-security/secret-scanning/about-secret-scanning.md | 1 + 1 file changed, 1 insertion(+) diff --git a/content/code-security/secret-scanning/about-secret-scanning.md b/content/code-security/secret-scanning/about-secret-scanning.md index d2d07238f4..7d62a67574 100644 --- a/content/code-security/secret-scanning/about-secret-scanning.md +++ b/content/code-security/secret-scanning/about-secret-scanning.md @@ -2,6 +2,7 @@ title: About secret scanning intro: '{% data variables.product.product_name %} scans repositories for known types of secrets, to prevent fraudulent use of secrets that were committed accidentally.' product: '{% data reusables.gated-features.secret-scanning %}' +miniTocMaxHeadingLevel: 3 redirect_from: - /github/administering-a-repository/about-token-scanning - /articles/about-token-scanning