diff --git a/.github/workflows/confirm-internal-staff-work-in-docs.yml b/.github/workflows/confirm-internal-staff-work-in-docs.yml index 76406163c4..cf10eacc96 100644 --- a/.github/workflows/confirm-internal-staff-work-in-docs.yml +++ b/.github/workflows/confirm-internal-staff-work-in-docs.yml @@ -61,7 +61,7 @@ jobs: owner: 'github', repo: 'docs-internal', title: `@${context.payload.sender.login} confirm that \#${issueNo} should be in the public github/docs repo`, - body: `@${context.payload.sender.login} opened https://github.com/github/docs/issues/${issueNo} publicly in the github/docs repo, instead of the private github/docs-internal repo.\n\n@${context.payload.sender.login}, please confirm that this belongs in the public repo and that no sensitive information was disclosed by commenting below and closing the issue.\n\nIf this was not intentional and sensitive information was shared, please delete https://github.com/github/docs/issues/${issueNo} and notify us in the \#docs-open-source channel.\n\nThanks! \n\n/cc @github/docs @github/docs-engineering`, + body: `@${context.payload.sender.login} opened https://github.com/github/docs/issues/${issueNo} publicly in the github/docs repo, instead of the private github/docs-internal repo.\n\n@${context.payload.sender.login}, please confirm that this belongs in the public repo and that no sensitive information was disclosed by commenting below and closing the issue.\n\nIf this was not intentional and sensitive information was shared, please delete https://github.com/github/docs/issues/${issueNo} and notify us in the \#docs-open-source channel.\n\nThanks!`, labels: ['OS confirmation'], }); diff --git a/.github/workflows/update-status-labels-on-tracking-issues.yml b/.github/workflows/update-status-labels-on-tracking-issues.yml index a26b0c2826..feffdff89e 100644 --- a/.github/workflows/update-status-labels-on-tracking-issues.yml +++ b/.github/workflows/update-status-labels-on-tracking-issues.yml @@ -17,11 +17,11 @@ jobs: const repo = context.payload.repository.name const allStatusLabels = [ - 'Status: GREEN', - 'Status: GREY', - 'Status: YELLOW', - 'Status: BLACK', - 'Status: RED' + 'green', + 'grey', + 'yellow', + 'black', + 'red' ]; const currentLabels = await github.issues.listLabelsOnIssue({ @@ -33,7 +33,7 @@ jobs: const newLabels = currentLabels.data.filter( label => allStatusLabels.includes(label.name) === false) allStatusLabels.forEach( label => { - if(context.payload.comment.body.includes(label)) { + if(context.payload.comment.body.toLowerCase().includes(`status: ${label}`)) { newLabels.push(label) } }); diff --git a/assets/images/help/repository/code-scanning-free-text-search-areas.png b/assets/images/help/repository/code-scanning-free-text-search-areas.png new file mode 100644 index 0000000000..0799feb0a8 Binary files /dev/null and b/assets/images/help/repository/code-scanning-free-text-search-areas.png differ diff --git a/assets/images/help/repository/code-scanning-search-alerts.png b/assets/images/help/repository/code-scanning-search-alerts.png new file mode 100644 index 0000000000..e274f632dd Binary files /dev/null and b/assets/images/help/repository/code-scanning-search-alerts.png differ diff --git a/components/Breadcrumbs.tsx b/components/Breadcrumbs.tsx index a6cdae79e0..090a1321ae 100644 --- a/components/Breadcrumbs.tsx +++ b/components/Breadcrumbs.tsx @@ -12,7 +12,7 @@ export type BreadcrumbT = { type Props = {} export const Breadcrumbs = (props: Props) => { const router = useRouter() - const pathWithLocale = `/${router.locale}${router.asPath}` + const pathWithLocale = `/${router.locale}${router.asPath.split('?')[0]}` // remove query string const { breadcrumbs } = useMainContext() return ( diff --git a/components/HeaderNotifications.tsx b/components/HeaderNotifications.tsx index 4e6d296af2..735b87576f 100644 --- a/components/HeaderNotifications.tsx +++ b/components/HeaderNotifications.tsx @@ -70,7 +70,7 @@ export const HeaderNotifications = () => { return ( <> {allNotifications.map(({ type, content }, i) => { - const isLast = i !== allNotifications.length - 1 + const isLast = i === allNotifications.length - 1 return (
{ return (
- + {selectedLang.nativeName || selectedLang.name} diff --git a/components/ScrollButton.tsx b/components/ScrollButton.tsx index 7694e9a2ae..a32bd2fc60 100644 --- a/components/ScrollButton.tsx +++ b/components/ScrollButton.tsx @@ -45,17 +45,6 @@ export const ScrollButton = () => { > -
) } diff --git a/components/TruncateLines.tsx b/components/TruncateLines.tsx index 7f29bdb707..f2685ddad1 100644 --- a/components/TruncateLines.tsx +++ b/components/TruncateLines.tsx @@ -8,14 +8,15 @@ type Props = { className?: string } export const TruncateLines = (props: Props) => { - const Component = props.as || 'div' + const { as, maxLines, className, children } = props + const Component = as || 'div' return ( - - {props.children} + + {children}