From 74b4daf9052b8a6c8993366dd9995b189f737a72 Mon Sep 17 00:00:00 2001 From: Alex Kyllo Date: Sat, 16 Oct 2021 16:21:13 -0700 Subject: [PATCH 1/5] add quotes around python versions in gha examples --- .../building-and-testing-python.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/content/actions/automating-builds-and-tests/building-and-testing-python.md b/content/actions/automating-builds-and-tests/building-and-testing-python.md index b015a85b3a..2d1608fcb0 100644 --- a/content/actions/automating-builds-and-tests/building-and-testing-python.md +++ b/content/actions/automating-builds-and-tests/building-and-testing-python.md @@ -60,7 +60,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - python-version: [3.6, 3.7, 3.8, 3.9] + python-version: ["3.6", "3.7", "3.8", "3.9"] steps: - uses: actions/checkout@v2 @@ -119,7 +119,7 @@ jobs: # You can use PyPy versions in python-version. # For example, pypy2 and pypy3 matrix: - python-version: [2.7, 3.6, 3.7, 3.8, 3.9] + python-version: ["2.7", "3.6", "3.7", "3.8", "3.9"] steps: - uses: actions/checkout@v2 @@ -182,12 +182,12 @@ jobs: strategy: matrix: os: [ubuntu-latest, macos-latest, windows-latest] - python-version: [3.6, 3.7, 3.8, 3.9, pypy2, pypy3] + python-version: ["3.6", "3.7", "3.8", "3.9", pypy2, pypy3] exclude: - os: macos-latest - python-version: 3.6 + python-version: "3.6" - os: windows-latest - python-version: 3.6 + python-version: "3.6" ``` {% endraw %} @@ -344,7 +344,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - python: [3.7, 3.8, 3.9] + python: ["3.7", "3.8", "3.9"] steps: - uses: actions/checkout@v2 @@ -378,7 +378,7 @@ jobs: runs-on: ubuntu-latest strategy: matrix: - python-version: [3.6, 3.7, 3.8, 3.9] + python-version: ["3.6", "3.7", "3.8", "3.9"] steps: - uses: actions/checkout@v2 From 06a3a7b91c011ddddabe213d7c27a9ce1e221251 Mon Sep 17 00:00:00 2001 From: Anil Seervi Date: Sun, 17 Oct 2021 11:10:01 +0530 Subject: [PATCH 2/5] Link to developers page --- components/page-footer/SmallFooter.tsx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/components/page-footer/SmallFooter.tsx b/components/page-footer/SmallFooter.tsx index 4e0892dda0..3a1a7af9d1 100644 --- a/components/page-footer/SmallFooter.tsx +++ b/components/page-footer/SmallFooter.tsx @@ -45,7 +45,7 @@ export const SmallFooter = () => { {t('product.links.pricing')}
  • - {t('platform.links.developer_api')} + {t('platform.links.developer_api')}
  • {t('support.links.training')} From 8189f38035159c9e2c95054c0e7fc12f7c56e594 Mon Sep 17 00:00:00 2001 From: Anil Seervi Date: Mon, 18 Oct 2021 15:13:47 +0000 Subject: [PATCH 3/5] Make internal footer links dynamic to language picker : Fixes #11274 --- components/page-footer/SmallFooter.tsx | 14 +++++++++++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/components/page-footer/SmallFooter.tsx b/components/page-footer/SmallFooter.tsx index 3a1a7af9d1..1ffc18e21d 100644 --- a/components/page-footer/SmallFooter.tsx +++ b/components/page-footer/SmallFooter.tsx @@ -1,19 +1,25 @@ +import { useRouter } from 'next/router' import { MarkGithubIcon } from '@primer/octicons-react' import { useTranslation } from 'components/hooks/useTranslation' export const SmallFooter = () => { + const router = useRouter() const { t } = useTranslation('footer') return (