From a60db5d2b9a9ce117e7f8dfda3b174741c358117 Mon Sep 17 00:00:00 2001 From: Rachael Sewell Date: Thu, 11 Aug 2022 09:53:59 -0700 Subject: [PATCH] Revert "fix: show content table preview urls after deploy" (#29853) --- .../content-changes-table-comment.js | 23 ++++--------------- .../content-changes-table-comment.yml | 5 +--- 2 files changed, 5 insertions(+), 23 deletions(-) diff --git a/.github/actions-scripts/content-changes-table-comment.js b/.github/actions-scripts/content-changes-table-comment.js index 32400b46c8..4aecea4709 100755 --- a/.github/actions-scripts/content-changes-table-comment.js +++ b/.github/actions-scripts/content-changes-table-comment.js @@ -2,7 +2,6 @@ import * as github from '@actions/github' import { setOutput } from '@actions/core' -import got from 'got' import { getContents } from '../../script/helpers/git-utils.js' import parse from '../../lib/read-frontmatter.js' @@ -48,13 +47,6 @@ const articleFiles = files.filter( const lines = await Promise.all( articleFiles.map(async (file) => { - // Action triggered on PR and after preview env is deployed. Check health to determine if preview env is ready (healthy) - let appUrlIsHealthy = false - try { - const res = await got.head(`${APP_URL}/healthz`, { retry: { limit: 0 } }) - appUrlIsHealthy = res.statusCode === 200 - } catch (err) {} - const sourceUrl = file.blob_url const fileName = file.filename.slice(pathPrefix.length) const fileUrl = fileName.slice(0, fileName.lastIndexOf('.')) @@ -78,8 +70,7 @@ const lines = await Promise.all( const { data } = parse(fileContents) let contentCell = '' - let previewCell = appUrlIsHealthy ? '' : '_Deployment pending..._' - + let previewCell = '' let prodCell = '' if (file.status === 'added') contentCell = 'New file: ' @@ -107,16 +98,12 @@ const lines = await Promise.all( if (versions.toString() === nonEnterpriseDefaultVersion) { // omit version from fpt url - previewCell += appUrlIsHealthy ? `[${plan}](${APP_URL}/${fileUrl})
` : '' + previewCell += `[${plan}](${APP_URL}/${fileUrl})
` prodCell += `[${plan}](${PROD_URL}/${fileUrl})
` } else { // for non-versioned releases (ghae, ghec) use full url - if (appUrlIsHealthy) { - previewCell += appUrlIsHealthy - ? `[${plan}](${APP_URL}/${versions}/${fileUrl})
` - : '' - } + previewCell += `[${plan}](${APP_URL}/${versions}/${fileUrl})
` prodCell += `[${plan}](${PROD_URL}/${versions}/${fileUrl})
` } } else if (versions.length) { @@ -126,9 +113,7 @@ const lines = await Promise.all( prodCell += `${plan}@ ` versions.forEach((version) => { - previewCell += appUrlIsHealthy - ? `[${version.split('@')[1]}](${APP_URL}/${version}/${fileUrl}) ` - : '' + previewCell += `[${version.split('@')[1]}](${APP_URL}/${version}/${fileUrl}) ` prodCell += `[${version.split('@')[1]}](${PROD_URL}/${version}/${fileUrl}) ` }) previewCell += '
' diff --git a/.github/workflows/content-changes-table-comment.yml b/.github/workflows/content-changes-table-comment.yml index 355af58d08..51fa2ce095 100644 --- a/.github/workflows/content-changes-table-comment.yml +++ b/.github/workflows/content-changes-table-comment.yml @@ -5,10 +5,6 @@ name: Content Changes Table Comment # **Who does it impact**: docs-internal/docs maintainers and contributors on: - # Trigger this workflow after preview deployment runs - workflow_run: - workflows: - - Azure - Deploy Preview Environment workflow_dispatch: pull_request_target: @@ -44,6 +40,7 @@ jobs: filters: | filterContentDir: - 'content/**/*' + filterContentDir: needs: PR-Preview-Links if: ${{ needs.PR-Preview-Links.outputs.filterContentDir == 'true' }}