jprdonnelly/docs
1
0
Fork 0
mirror of synced 2025-12-25 02:17:36 -05:00
Code Issues Projects Releases Wiki Activity

Revert "sitetree optimizations"

Browse Source
This commit is contained in:
Sarah Schneider
2020-12-14 16:53:04 -05:00
committed by GitHub
parent 5ae479356d
commit b38eec9964
11 changed files with 93 additions and 71 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
tests/content/site-tree.js
View File

@@ -24,23 +24,23 @@ describe('siteTree', () => {
test('object order', () => {
expect(Object.keys(siteTree)[0]).toBe('en')
expect(Object.keys(siteTree.en)[0]).toBe(nonEnterpriseDefaultVersion)
expect(Object.keys(siteTree.en[nonEnterpriseDefaultVersion].products.github.categories)[0]).toBe(`/en/${nonEnterpriseDefaultVersion}/github/getting-started-with-github`)
expect(Object.keys(siteTree.en[nonEnterpriseDefaultVersion].products.github.categories)[0]).toBe(`/${nonEnterpriseDefaultVersion}/github/getting-started-with-github`)
})
test('object structure', () => {
expect(nonEnterpriseDefaultVersion in siteTree.en).toBe(true)
expect(`enterprise-server@${latestEnterpriseRelease}` in siteTree.en).toBe(true)
expect(flatTree[`en.${nonEnterpriseDefaultVersion}.products.github.href`]).toBe(`/en/${nonEnterpriseDefaultVersion}/github`)
expect(flatTree[`en.${nonEnterpriseDefaultVersion}.products.github.categories./en/${nonEnterpriseDefaultVersion}/github/getting-started-with-github.href`]).toBe(`/en/${nonEnterpriseDefaultVersion}/github/getting-started-with-github`)
expect(flatTree[`en.${nonEnterpriseDefaultVersion}.products.github.href`]).toBe(`/${nonEnterpriseDefaultVersion}/github`)
expect(flatTree[`en.${nonEnterpriseDefaultVersion}.products.github.categories./${nonEnterpriseDefaultVersion}/github/getting-started-with-github.href`]).toBe(`/${nonEnterpriseDefaultVersion}/github/getting-started-with-github`)
})
describe('localized titles', () => {
test('titles for categories', () => {
const japaneseTitle = flatTree[`ja.${nonEnterpriseDefaultVersion}.products.github.categories./ja/${nonEnterpriseDefaultVersion}/github/getting-started-with-github.title`]
const japaneseTitle = flatTree[`ja.${nonEnterpriseDefaultVersion}.products.github.categories./${nonEnterpriseDefaultVersion}/github/getting-started-with-github.title`]
expect(typeof japaneseTitle).toBe('string')
expect(japaneseCharacters.presentIn(japaneseTitle)).toBe(true)
const englishTitle = flatTree[`en.${nonEnterpriseDefaultVersion}.products.github.categories./en/${nonEnterpriseDefaultVersion}/github/getting-started-with-github.title`]
const englishTitle = flatTree[`en.${nonEnterpriseDefaultVersion}.products.github.categories./${nonEnterpriseDefaultVersion}/github/getting-started-with-github.title`]
expect(typeof englishTitle).toBe('string')
expect(japaneseCharacters.presentIn(englishTitle)).toBe(false)
})
@@ -52,7 +52,7 @@ describe('siteTree', () => {
test('articles that include site data in liquid templating', () => {
const pageWithDynamicTitle = siteTree.en[`enterprise-server@${latestEnterpriseRelease}`]
.products.admin
.categories[`/en/enterprise-server@${latestEnterpriseRelease}/admin/enterprise-support`]
.categories[`/enterprise-server@${latestEnterpriseRelease}/admin/enterprise-support`]
// Source frontmatter from article:
// title: 'Working with {{ site.data.variables.contact.github_support }}'
expect(pageWithDynamicTitle.title).toEqual('Working with GitHub Support')

26
tests/rendering/breadcrumbs.js
View File

@@ -88,7 +88,7 @@ describe('breadcrumbs', () => {
const breadcrumbs = await getJSON('/en/github?json=breadcrumbs')
const expected = {
product: {
href: `/en/${nonEnterpriseDefaultVersion}/github`,
href: `/${nonEnterpriseDefaultVersion}/github`,
title: 'GitHub.com'
}
}
@@ -99,11 +99,11 @@ describe('breadcrumbs', () => {
const breadcrumbs = await getJSON('/en/github/authenticating-to-github?json=breadcrumbs')
const expected = {
product: {
href: `/en/${nonEnterpriseDefaultVersion}/github`,
href: `/${nonEnterpriseDefaultVersion}/github`,
title: 'GitHub.com'
},
category: {
href: `/en/${nonEnterpriseDefaultVersion}/github/authenticating-to-github`,
href: `/${nonEnterpriseDefaultVersion}/github/authenticating-to-github`,
title: 'Authentication'
}
}
@@ -114,15 +114,15 @@ describe('breadcrumbs', () => {
const breadcrumbs = await getJSON('/en/github/authenticating-to-github/keeping-your-account-and-data-secure?json=breadcrumbs')
const expected = {
product: {
href: `/en/${nonEnterpriseDefaultVersion}/github`,
href: `/${nonEnterpriseDefaultVersion}/github`,
title: 'GitHub.com'
},
category: {
href: `/en/${nonEnterpriseDefaultVersion}/github/authenticating-to-github`,
href: `/${nonEnterpriseDefaultVersion}/github/authenticating-to-github`,
title: 'Authentication'
},
maptopic: {
href: `/en/${nonEnterpriseDefaultVersion}/github/authenticating-to-github/keeping-your-account-and-data-secure`,
href: `/${nonEnterpriseDefaultVersion}/github/authenticating-to-github/keeping-your-account-and-data-secure`,
title: 'Keeping your account and data secure'
}
}
@@ -133,19 +133,19 @@ describe('breadcrumbs', () => {
const breadcrumbs = await getJSON('/en/github/authenticating-to-github/creating-a-strong-password?json=breadcrumbs')
const expected = {
product: {
href: `/en/${nonEnterpriseDefaultVersion}/github`,
href: `/${nonEnterpriseDefaultVersion}/github`,
title: 'GitHub.com'
},
category: {
href: `/en/${nonEnterpriseDefaultVersion}/github/authenticating-to-github`,
href: `/${nonEnterpriseDefaultVersion}/github/authenticating-to-github`,
title: 'Authentication'
},
maptopic: {
href: `/en/${nonEnterpriseDefaultVersion}/github/authenticating-to-github/keeping-your-account-and-data-secure`,
href: `/${nonEnterpriseDefaultVersion}/github/authenticating-to-github/keeping-your-account-and-data-secure`,
title: 'Keeping your account and data secure'
},
article: {
href: `/en/${nonEnterpriseDefaultVersion}/github/authenticating-to-github/creating-a-strong-password`,
href: `/${nonEnterpriseDefaultVersion}/github/authenticating-to-github/creating-a-strong-password`,
title: 'Creating a strong password'
}
}
@@ -156,15 +156,15 @@ describe('breadcrumbs', () => {
const breadcrumbs = await getJSON('/github/site-policy/github-privacy-statement?json=breadcrumbs')
const expected = {
product: {
href: `/en/${nonEnterpriseDefaultVersion}/github`,
href: `/${nonEnterpriseDefaultVersion}/github`,
title: 'GitHub.com'
},
category: {
href: `/en/${nonEnterpriseDefaultVersion}/github/site-policy`,
href: `/${nonEnterpriseDefaultVersion}/github/site-policy`,
title: 'Site policy'
},
article: {
href: `/en/${nonEnterpriseDefaultVersion}/github/site-policy/github-privacy-statement`,
href: `/${nonEnterpriseDefaultVersion}/github/site-policy/github-privacy-statement`,
title: 'GitHub Privacy Statement'
}
}